gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-08-22 23:04:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Same-line shellcheck comment explanations

Browse Source 
These are obvious even with `git grep shellcheck`.
This commit is contained in:
Rangi
2026-07-06 04:43:08 +02:00
committed by Eldred Habert
parent 09da4e001a
commit 0adbb92e50
4 changed files with 7 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/asm/test.sh
+3 -8
View File
@@ -11,8 +11,7 @@ input="$(mktemp)"
output="$(mktemp)"
errput="$(mktemp)"
# Immediate expansion is the desired behavior.
# shellcheck disable=SC2064
# shellcheck disable=SC2064 # (Immediate expansion is the desired behavior.)
trap "rm -f ${o@Q} ${gb@Q} ${input@Q} ${output@Q} ${errput@Q}" EXIT
tests=0
@@ -91,11 +90,7 @@ for i in *.asm notexist.asm; do
continue
fi
# Stop! This is not a Useless Use Of Cat. Using cat instead of
# stdin redirection makes the input an unseekable pipe - a scenario
# that's harder to deal with and was broken when the feature was
# first implemented.
# shellcheck disable=SC2002
# shellcheck disable=SC2002 # (This use of `cat` intentionally makes the input an unseekable pipe.)
cat "$i" | "$RGBASM" "${RGBASMFLAGS[@]}" -o "$o" - >"$output" 2>"$errput"
# Use two otherwise unused files for temp storage
@@ -230,7 +225,7 @@ for variant in '' '.pipe'; do
if [ -z "$variant" ]; then
"$RGBASM" "${RGBASMFLAGS[@]}" -s "$state_features:$state_outname" "$i"/a.asm >"$output" 2>"$errput"
else
# shellcheck disable=SC2002
# shellcheck disable=SC2002 # (This use of `cat` intentionally makes the input an unseekable pipe.)
cat "$i"/a.asm | "$RGBASM" "${RGBASMFLAGS[@]}" -s "$state_features:$state_outname" - >"$output" 2>"$errput"
fi