gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 10:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Output error messages for command line includes

Browse Source 
The code that adds an include path to the array of paths doesn't check
the lenght of the path (which can cause overflows because of strcpy).

It doesn't check if the max number of paths has been reached, either.

This patch adds error messages for such cases, giving the user more
information than before and crashing the assembly instead of
continuing and failing when it can't find a file to include.
This commit is contained in:
AntonioND
2017-01-22 22:56:47 +00:00
parent f8531ed410
commit 0b5e074591
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/asm/fstack.c
View File

@@ -179,6 +179,16 @@ fstk_Dump(void)
void void
fstk_AddIncludePath(char *s) fstk_AddIncludePath(char *s)
{ {
if (NextIncPath == MAXINCPATHS) {
fatalerror("Too many include directories passed from command line");
return;
}
if (strlen(s) > _MAX_PATH) {
fatalerror("Include path too long '%s'",s);
return;
}
strcpy(IncludePaths[NextIncPath++], s); strcpy(IncludePaths[NextIncPath++], s);
} }