Use concrete types instead of auto when convenient and not redundant (#1757)

src/link/assign.cpp

@@ -351,9 +351,9 @@ static void categorizeSection(Section &section) {
 	}
 
 	std::deque<Section *> &sections = unassignedSections[constraints];
-	auto pos = sections.begin();
 
 	// Insert section while keeping the list sorted by decreasing size
+	auto pos = sections.begin();
 	while (pos != sections.end() && (*pos)->size > section.size) {
 		pos++;
 	}

src/link/output.cpp

@@ -86,12 +86,12 @@ void out_AddSection(Section const &section) {
 	std::deque<Section const *> &bankSections =
 	    section.size ? sections[section.type][targetBank].sections
 	                 : sections[section.type][targetBank].zeroLenSections;
-	auto pos = bankSections.begin();
 
+	// Insert section while keeping the list sorted by increasing org
+	auto pos = bankSections.begin();
 	while (pos != bankSections.end() && (*pos)->org < section.org) {
 		pos++;
 	}
-
 	bankSections.insert(pos, &section);
 }
 
@@ -347,7 +347,7 @@ static void writeSymBank(SortedSections const &bankSections, SectionType type, u
 				std::string parentName = sym->name.substr(0, pos);
 				if (Symbol const *parentSym = sym_GetSymbol(parentName);
 				    parentSym && std::holds_alternative<Label>(parentSym->data)) {
-					auto const &parentLabel = parentSym->label();
+					Label const &parentLabel = parentSym->label();
 					Section const &parentSection = *parentLabel.section;
 					parentAddr = static_cast<uint16_t>(parentLabel.offset + parentSection.org);
 				}

src/link/sdas_obj.cpp

@@ -857,7 +857,7 @@ void sdobj_ReadFile(FileStackNode const &src, FILE *file, std::vector<Symbol> &f
 
 		// RAM sections can have a size, but don't get any data (they shouldn't have any)
 		if (section->type != SECTTYPE_INVALID) {
-			auto const &typeInfo = sectionTypeInfo[section->type];
+			SectionTypeInfo const &typeInfo = sectionTypeInfo[section->type];
 			// Otherwise, how would the type already be known at this point?
 			assume(section->isAddressFixed);
 

src/link/section.cpp

@@ -16,7 +16,7 @@ std::vector<std::unique_ptr<Section>> sectionList;
 std::unordered_map<std::string, size_t> sectionMap; // Indexes into `sectionList`
 
 void sect_ForEach(void (*callback)(Section &)) {
-	for (auto &ptr : sectionList) {
+	for (std::unique_ptr<Section> &ptr : sectionList) {
 		callback(*ptr);
 	}
 }