gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-22 11:12:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Consistent behavior with missing or incorrect parameters (#1179)

Browse Source
This commit is contained in:
Rangi
2023-11-02 12:40:40 -04:00
committed by GitHub
parent a64f28de5c
commit 0d72ba886b
8 changed files with 61 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/fix/main.c
View File

@@ -67,7 +67,7 @@ static void printUsage(void)
fputs(
"Usage: rgbfix [-jOsVv] [-C | -c] [-f <fix_spec>] [-i <game_id>] [-k <licensee>]\n"
" [-l <licensee_byte>] [-m <mbc_type>] [-n <rom_version>]\n"
" [-p <pad_value>] [-r <ram_size>] [-t <title_str>] [<file> ...]\n"
" [-p <pad_value>] [-r <ram_size>] [-t <title_str>] <file> ...\n"
"Useful options:\n"
" -m, --mbc-type <value> set the MBC type byte to this value; refer\n"
" to the man page for a list of values\n"
@@ -1224,9 +1224,8 @@ finish:
int main(int argc, char *argv[])
{
nbErrors = 0;
int ch;
while ((ch = musl_getopt_long_only(argc, argv, optstring, longopts, NULL)) != -1) {
for (int ch; (ch = musl_getopt_long_only(argc, argv, optstring, longopts, NULL)) != -1;) {
switch (ch) {
size_t len;
#define parseByte(output, name) \
@@ -1447,12 +1446,15 @@ do { \
bool failed = nbErrors;
if (!*argv) {
failed |= processFilename("-");
} else {
do {
failed |= processFilename(*argv);
} while (*++argv);
fputs("FATAL: Please specify an input file (pass `-` to read from standard input)\n",
stderr);
printUsage();
exit(1);
}
do {
failed |= processFilename(*argv);
} while (*++argv);
return failed;
}