mirror of
https://github.com/gbdev/rgbds.git
synced 2025-11-20 10:12:06 +00:00
Implement warning diagnostic flags for RGBFIX (#1766)
* Implement warning diagnostic flags for RGBFIX * `-m/--mbc-type help` prints to stdout * Support `-m list` as well as `-m help` * Make invalid `rgbfix -l` characters a fatal error, like other invalid CLI arguments * Refactor fix/main.cpp into multiple files
This commit is contained in:
Rangi
GitHub
611
src/fix/mbc.cpp
Normal file
611
src/fix/mbc.cpp
Normal file
@@ -0,0 +1,611 @@
|
||||
#include "fix/mbc.hpp"
|
||||
|
||||
#include <stdlib.h>
|
||||
|
||||
#include "helpers.hpp" // unreachable_
|
||||
#include "platform.hpp" // strcasecmp
|
||||
|
||||
#include "fix/warning.hpp"
|
||||
|
||||
[[gnu::format(printf, 1, 2), noreturn]]
|
||||
static void fatalWithMBCNames(char const *fmt, ...) {
|
||||
va_list ap;
|
||||
fputs("FATAL: ", stderr);
|
||||
va_start(ap, fmt);
|
||||
vfprintf(stderr, fmt, ap);
|
||||
va_end(ap);
|
||||
putc('\n', stderr);
|
||||
|
||||
mbc_PrintAcceptedNames(stderr);
|
||||
exit(1);
|
||||
}
|
||||
|
||||
void mbc_PrintAcceptedNames(FILE *file) {
|
||||
fputs("Accepted MBC names:\n", file);
|
||||
fputs("\tROM ($00) [aka ROM_ONLY]\n", file);
|
||||
fputs("\tMBC1 ($01), MBC1+RAM ($02), MBC1+RAM+BATTERY ($03)\n", file);
|
||||
fputs("\tMBC2 ($05), MBC2+BATTERY ($06)\n", file);
|
||||
fputs("\tROM+RAM ($08) [deprecated], ROM+RAM+BATTERY ($09) [deprecated]\n", file);
|
||||
fputs("\tMMM01 ($0B), MMM01+RAM ($0C), MMM01+RAM+BATTERY ($0D)\n", file);
|
||||
fputs("\tMBC3+TIMER+BATTERY ($0F), MBC3+TIMER+RAM+BATTERY ($10)\n", file);
|
||||
fputs("\tMBC3 ($11), MBC3+RAM ($12), MBC3+RAM+BATTERY ($13)\n", file);
|
||||
fputs("\tMBC5 ($19), MBC5+RAM ($1A), MBC5+RAM+BATTERY ($1B)\n", file);
|
||||
fputs("\tMBC5+RUMBLE ($1C), MBC5+RUMBLE+RAM ($1D), MBC5+RUMBLE+RAM+BATTERY ($1E)\n", file);
|
||||
fputs("\tMBC6 ($20)\n", file);
|
||||
fputs("\tMBC7+SENSOR+RUMBLE+RAM+BATTERY ($22)\n", file);
|
||||
fputs("\tPOCKET_CAMERA ($FC)\n", file);
|
||||
fputs("\tBANDAI_TAMA5 ($FD) [aka TAMA5]\n", file);
|
||||
fputs("\tHUC3 ($FE)\n", file);
|
||||
fputs("\tHUC1+RAM+BATTERY ($FF)\n", file);
|
||||
|
||||
fputs("\n\tTPP1_1.0, TPP1_1.0+RUMBLE, TPP1_1.0+MULTIRUMBLE, TPP1_1.0+TIMER,\n", file);
|
||||
fputs("\tTPP1_1.0+TIMER+RUMBLE, TPP1_1.0+TIMER+MULTIRUMBLE, TPP1_1.0+BATTERY,\n", file);
|
||||
fputs("\tTPP1_1.0+BATTERY+RUMBLE, TPP1_1.0+BATTERY+MULTIRUMBLE,\n", file);
|
||||
fputs("\tTPP1_1.0+BATTERY+TIMER, TPP1_1.0+BATTERY+TIMER+RUMBLE,\n", file);
|
||||
fputs("\tTPP1_1.0+BATTERY+TIMER+MULTIRUMBLE\n", file);
|
||||
}
|
||||
|
||||
bool mbc_HasRAM(MbcType type) {
|
||||
switch (type) {
|
||||
case ROM_RAM:
|
||||
case ROM_RAM_BATTERY:
|
||||
case MBC1_RAM:
|
||||
case MBC1_RAM_BATTERY:
|
||||
case MMM01_RAM:
|
||||
case MMM01_RAM_BATTERY:
|
||||
case MBC3_TIMER_RAM_BATTERY:
|
||||
case MBC3_RAM:
|
||||
case MBC3_RAM_BATTERY:
|
||||
case MBC5_RAM:
|
||||
case MBC5_RAM_BATTERY:
|
||||
case MBC5_RUMBLE_RAM:
|
||||
case MBC5_RUMBLE_RAM_BATTERY:
|
||||
case MBC6: // "Net de Get - Minigame @ 100" has RAM size 3 (32 KiB)
|
||||
case MBC7_SENSOR_RUMBLE_RAM_BATTERY:
|
||||
case POCKET_CAMERA:
|
||||
case HUC3:
|
||||
case HUC1_RAM_BATTERY:
|
||||
return true;
|
||||
|
||||
case ROM:
|
||||
case MBC1:
|
||||
case MBC2: // Technically has RAM, but not marked as such
|
||||
case MBC2_BATTERY:
|
||||
case MMM01:
|
||||
case MBC3:
|
||||
case MBC3_TIMER_BATTERY:
|
||||
case MBC5:
|
||||
case MBC5_RUMBLE:
|
||||
case BANDAI_TAMA5: // "Game de Hakken!! Tamagotchi - Osutchi to Mesutchi" has RAM size 0
|
||||
case MBC_NONE:
|
||||
return false;
|
||||
|
||||
// TPP1 may or may not have RAM, don't call this function for it
|
||||
case TPP1:
|
||||
case TPP1_RUMBLE:
|
||||
case TPP1_MULTIRUMBLE:
|
||||
case TPP1_MULTIRUMBLE_RUMBLE:
|
||||
case TPP1_TIMER:
|
||||
case TPP1_TIMER_RUMBLE:
|
||||
case TPP1_TIMER_MULTIRUMBLE:
|
||||
case TPP1_TIMER_MULTIRUMBLE_RUMBLE:
|
||||
case TPP1_BATTERY:
|
||||
case TPP1_BATTERY_RUMBLE:
|
||||
case TPP1_BATTERY_MULTIRUMBLE:
|
||||
case TPP1_BATTERY_MULTIRUMBLE_RUMBLE:
|
||||
case TPP1_BATTERY_TIMER:
|
||||
case TPP1_BATTERY_TIMER_RUMBLE:
|
||||
case TPP1_BATTERY_TIMER_MULTIRUMBLE:
|
||||
case TPP1_BATTERY_TIMER_MULTIRUMBLE_RUMBLE:
|
||||
break;
|
||||
}
|
||||
|
||||
unreachable_(); // LCOV_EXCL_LINE
|
||||
}
|
||||
|
||||
char const *mbc_Name(MbcType type) {
|
||||
switch (type) {
|
||||
case ROM:
|
||||
return "ROM";
|
||||
case ROM_RAM:
|
||||
return "ROM+RAM";
|
||||
case ROM_RAM_BATTERY:
|
||||
return "ROM+RAM+BATTERY";
|
||||
case MBC1:
|
||||
return "MBC1";
|
||||
case MBC1_RAM:
|
||||
return "MBC1+RAM";
|
||||
case MBC1_RAM_BATTERY:
|
||||
return "MBC1+RAM+BATTERY";
|
||||
case MBC2:
|
||||
return "MBC2";
|
||||
case MBC2_BATTERY:
|
||||
return "MBC2+BATTERY";
|
||||
case MMM01:
|
||||
return "MMM01";
|
||||
case MMM01_RAM:
|
||||
return "MMM01+RAM";
|
||||
case MMM01_RAM_BATTERY:
|
||||
return "MMM01+RAM+BATTERY";
|
||||
case MBC3:
|
||||
return "MBC3";
|
||||
case MBC3_TIMER_BATTERY:
|
||||
return "MBC3+TIMER+BATTERY";
|
||||
case MBC3_TIMER_RAM_BATTERY:
|
||||
return "MBC3+TIMER+RAM+BATTERY";
|
||||
case MBC3_RAM:
|
||||
return "MBC3+RAM";
|
||||
case MBC3_RAM_BATTERY:
|
||||
return "MBC3+RAM+BATTERY";
|
||||
case MBC5:
|
||||
return "MBC5";
|
||||
case MBC5_RAM:
|
||||
return "MBC5+RAM";
|
||||
case MBC5_RAM_BATTERY:
|
||||
return "MBC5+RAM+BATTERY";
|
||||
case MBC5_RUMBLE:
|
||||
return "MBC5+RUMBLE";
|
||||
case MBC5_RUMBLE_RAM:
|
||||
return "MBC5+RUMBLE+RAM";
|
||||
case MBC5_RUMBLE_RAM_BATTERY:
|
||||
return "MBC5+RUMBLE+RAM+BATTERY";
|
||||
case MBC6:
|
||||
return "MBC6";
|
||||
case MBC7_SENSOR_RUMBLE_RAM_BATTERY:
|
||||
return "MBC7+SENSOR+RUMBLE+RAM+BATTERY";
|
||||
case POCKET_CAMERA:
|
||||
return "POCKET CAMERA";
|
||||
case BANDAI_TAMA5:
|
||||
return "BANDAI TAMA5";
|
||||
case HUC3:
|
||||
return "HUC3";
|
||||
case HUC1_RAM_BATTERY:
|
||||
return "HUC1+RAM+BATTERY";
|
||||
case TPP1:
|
||||
return "TPP1";
|
||||
case TPP1_RUMBLE:
|
||||
return "TPP1+RUMBLE";
|
||||
case TPP1_MULTIRUMBLE:
|
||||
case TPP1_MULTIRUMBLE_RUMBLE:
|
||||
return "TPP1+MULTIRUMBLE";
|
||||
case TPP1_TIMER:
|
||||
return "TPP1+TIMER";
|
||||
case TPP1_TIMER_RUMBLE:
|
||||
return "TPP1+TIMER+RUMBLE";
|
||||
case TPP1_TIMER_MULTIRUMBLE:
|
||||
case TPP1_TIMER_MULTIRUMBLE_RUMBLE:
|
||||
return "TPP1+TIMER+MULTIRUMBLE";
|
||||
case TPP1_BATTERY:
|
||||
return "TPP1+BATTERY";
|
||||
case TPP1_BATTERY_RUMBLE:
|
||||
return "TPP1+BATTERY+RUMBLE";
|
||||
case TPP1_BATTERY_MULTIRUMBLE:
|
||||
case TPP1_BATTERY_MULTIRUMBLE_RUMBLE:
|
||||
return "TPP1+BATTERY+MULTIRUMBLE";
|
||||
case TPP1_BATTERY_TIMER:
|
||||
return "TPP1+BATTERY+TIMER";
|
||||
case TPP1_BATTERY_TIMER_RUMBLE:
|
||||
return "TPP1+BATTERY+TIMER+RUMBLE";
|
||||
case TPP1_BATTERY_TIMER_MULTIRUMBLE:
|
||||
case TPP1_BATTERY_TIMER_MULTIRUMBLE_RUMBLE:
|
||||
return "TPP1+BATTERY+TIMER+MULTIRUMBLE";
|
||||
case MBC_NONE:
|
||||
break;
|
||||
}
|
||||
|
||||
unreachable_(); // LCOV_EXCL_LINE
|
||||
}
|
||||
|
||||
static void skipWhitespace(char const *&ptr) {
|
||||
while (*ptr == ' ' || *ptr == '\t') {
|
||||
++ptr;
|
||||
}
|
||||
}
|
||||
|
||||
static void skipMBCSpace(char const *&ptr) {
|
||||
while (*ptr == ' ' || *ptr == '\t' || *ptr == '_') {
|
||||
++ptr;
|
||||
}
|
||||
}
|
||||
|
||||
static char normalizeMBCChar(char c) {
|
||||
if (c >= 'a' && c <= 'z') { // Uppercase for comparison with `mbc_Name`s
|
||||
c = c - 'a' + 'A';
|
||||
} else if (c == '_') { // Treat underscores as spaces
|
||||
c = ' ';
|
||||
}
|
||||
return c;
|
||||
}
|
||||
|
||||
static bool readMBCSlice(char const *&name, char const *expected) {
|
||||
while (*expected) {
|
||||
// If `name` is too short, the character will be '\0' and this will return `false`
|
||||
if (normalizeMBCChar(*name++) != *expected++) {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
return true;
|
||||
}
|
||||
|
||||
[[noreturn]]
|
||||
static void fatalUnknownMBC(char const *fullName) {
|
||||
fatalWithMBCNames("Unknown MBC \"%s\"", fullName);
|
||||
}
|
||||
|
||||
[[noreturn]]
|
||||
static void fatalWrongMBCFeatures(char const *fullName) {
|
||||
fatalWithMBCNames("Features incompatible with MBC (\"%s\")", fullName);
|
||||
}
|
||||
|
||||
MbcType mbc_ParseName(char const *name, uint8_t &tpp1Major, uint8_t &tpp1Minor) {
|
||||
char const *fullName = name;
|
||||
|
||||
if (!strcasecmp(name, "help") || !strcasecmp(name, "list")) {
|
||||
mbc_PrintAcceptedNames(stdout);
|
||||
exit(0);
|
||||
}
|
||||
|
||||
if ((name[0] >= '0' && name[0] <= '9') || name[0] == '$') {
|
||||
int base = 0;
|
||||
|
||||
if (name[0] == '$') {
|
||||
++name;
|
||||
base = 16;
|
||||
}
|
||||
// Parse number, and return it as-is (unless it's too large)
|
||||
char *endptr;
|
||||
unsigned long mbc = strtoul(name, &endptr, base);
|
||||
|
||||
if (*endptr) {
|
||||
fatalUnknownMBC(fullName);
|
||||
}
|
||||
if (mbc > 0xFF) {
|
||||
fatal("Specified MBC ID out of range 0-255: %s", fullName);
|
||||
}
|
||||
return static_cast<MbcType>(mbc);
|
||||
}
|
||||
|
||||
// Begin by reading the MBC type:
|
||||
uint16_t mbc;
|
||||
char const *ptr = name;
|
||||
|
||||
skipWhitespace(ptr); // Trim off leading whitespace
|
||||
|
||||
#define tryReadSlice(expected) \
|
||||
do { \
|
||||
if (!readMBCSlice(ptr, expected)) { \
|
||||
fatalUnknownMBC(fullName); \
|
||||
} \
|
||||
} while (0)
|
||||
|
||||
switch (*ptr++) {
|
||||
case 'R': // ROM / ROM_ONLY
|
||||
case 'r':
|
||||
tryReadSlice("OM");
|
||||
// Handle optional " ONLY"
|
||||
skipMBCSpace(ptr);
|
||||
if (*ptr == 'O' || *ptr == 'o') {
|
||||
++ptr;
|
||||
tryReadSlice("NLY");
|
||||
}
|
||||
mbc = ROM;
|
||||
break;
|
||||
|
||||
case 'M': // MBC{1, 2, 3, 5, 6, 7} / MMM01
|
||||
case 'm':
|
||||
switch (*ptr++) {
|
||||
case 'B':
|
||||
case 'b':
|
||||
switch (*ptr++) {
|
||||
case 'C':
|
||||
case 'c':
|
||||
break;
|
||||
default:
|
||||
fatalUnknownMBC(fullName);
|
||||
}
|
||||
switch (*ptr++) {
|
||||
case '1':
|
||||
mbc = MBC1;
|
||||
break;
|
||||
case '2':
|
||||
mbc = MBC2;
|
||||
break;
|
||||
case '3':
|
||||
mbc = MBC3;
|
||||
break;
|
||||
case '5':
|
||||
mbc = MBC5;
|
||||
break;
|
||||
case '6':
|
||||
mbc = MBC6;
|
||||
break;
|
||||
case '7':
|
||||
mbc = MBC7_SENSOR_RUMBLE_RAM_BATTERY;
|
||||
break;
|
||||
default:
|
||||
fatalUnknownMBC(fullName);
|
||||
}
|
||||
break;
|
||||
case 'M':
|
||||
case 'm':
|
||||
tryReadSlice("M01");
|
||||
mbc = MMM01;
|
||||
break;
|
||||
default:
|
||||
fatalUnknownMBC(fullName);
|
||||
}
|
||||
break;
|
||||
|
||||
case 'P': // POCKET_CAMERA
|
||||
case 'p':
|
||||
tryReadSlice("OCKET CAMERA");
|
||||
mbc = POCKET_CAMERA;
|
||||
break;
|
||||
|
||||
case 'B': // BANDAI_TAMA5
|
||||
case 'b':
|
||||
tryReadSlice("ANDAI TAMA5");
|
||||
mbc = BANDAI_TAMA5;
|
||||
break;
|
||||
|
||||
case 'T': // TAMA5 / TPP1
|
||||
case 't':
|
||||
switch (*ptr++) {
|
||||
case 'A':
|
||||
tryReadSlice("MA5");
|
||||
mbc = BANDAI_TAMA5;
|
||||
break;
|
||||
case 'P': {
|
||||
tryReadSlice("P1");
|
||||
// Parse version
|
||||
skipMBCSpace(ptr);
|
||||
// Major
|
||||
char *endptr;
|
||||
unsigned long val = strtoul(ptr, &endptr, 10);
|
||||
|
||||
if (endptr == ptr) {
|
||||
fatal("Failed to parse TPP1 major revision number");
|
||||
}
|
||||
ptr = endptr;
|
||||
if (val != 1) {
|
||||
fatal("RGBFIX only supports TPP1 version 1.0");
|
||||
}
|
||||
tpp1Major = val;
|
||||
tryReadSlice(".");
|
||||
// Minor
|
||||
val = strtoul(ptr, &endptr, 10);
|
||||
if (endptr == ptr) {
|
||||
fatal("Failed to parse TPP1 minor revision number");
|
||||
}
|
||||
ptr = endptr;
|
||||
if (val > 0xFF) {
|
||||
fatal("TPP1 minor revision number must be 8-bit");
|
||||
}
|
||||
tpp1Minor = val;
|
||||
mbc = TPP1;
|
||||
break;
|
||||
}
|
||||
default:
|
||||
fatalUnknownMBC(fullName);
|
||||
}
|
||||
break;
|
||||
|
||||
case 'H': // HuC{1, 3}
|
||||
case 'h':
|
||||
tryReadSlice("UC");
|
||||
switch (*ptr++) {
|
||||
case '1':
|
||||
mbc = HUC1_RAM_BATTERY;
|
||||
break;
|
||||
case '3':
|
||||
mbc = HUC3;
|
||||
break;
|
||||
default:
|
||||
fatalUnknownMBC(fullName);
|
||||
}
|
||||
break;
|
||||
|
||||
default:
|
||||
fatalUnknownMBC(fullName);
|
||||
}
|
||||
|
||||
// Read "additional features"
|
||||
uint8_t features = 0;
|
||||
// clang-format off: vertically align values
|
||||
static constexpr uint8_t RAM = 1 << 7;
|
||||
static constexpr uint8_t BATTERY = 1 << 6;
|
||||
static constexpr uint8_t TIMER = 1 << 5;
|
||||
static constexpr uint8_t RUMBLE = 1 << 4;
|
||||
static constexpr uint8_t SENSOR = 1 << 3;
|
||||
static constexpr uint8_t MULTIRUMBLE = 1 << 2;
|
||||
// clang-format on
|
||||
|
||||
for (;;) {
|
||||
skipWhitespace(ptr); // Trim off trailing whitespace
|
||||
|
||||
// If done, start processing "features"
|
||||
if (!*ptr) {
|
||||
break;
|
||||
}
|
||||
// We expect a '+' at this point
|
||||
skipMBCSpace(ptr);
|
||||
if (*ptr++ != '+') {
|
||||
fatalUnknownMBC(fullName);
|
||||
}
|
||||
skipMBCSpace(ptr);
|
||||
|
||||
switch (*ptr++) {
|
||||
case 'B': // BATTERY
|
||||
case 'b':
|
||||
tryReadSlice("ATTERY");
|
||||
features |= BATTERY;
|
||||
break;
|
||||
|
||||
case 'M':
|
||||
case 'm':
|
||||
tryReadSlice("ULTIRUMBLE");
|
||||
features |= MULTIRUMBLE;
|
||||
break;
|
||||
|
||||
case 'R': // RAM or RUMBLE
|
||||
case 'r':
|
||||
switch (*ptr++) {
|
||||
case 'U':
|
||||
case 'u':
|
||||
tryReadSlice("MBLE");
|
||||
features |= RUMBLE;
|
||||
break;
|
||||
case 'A':
|
||||
case 'a':
|
||||
tryReadSlice("M");
|
||||
features |= RAM;
|
||||
break;
|
||||
default:
|
||||
fatalUnknownMBC(fullName);
|
||||
}
|
||||
break;
|
||||
|
||||
case 'S': // SENSOR
|
||||
case 's':
|
||||
tryReadSlice("ENSOR");
|
||||
features |= SENSOR;
|
||||
break;
|
||||
|
||||
case 'T': // TIMER
|
||||
case 't':
|
||||
tryReadSlice("IMER");
|
||||
features |= TIMER;
|
||||
break;
|
||||
|
||||
default:
|
||||
fatalUnknownMBC(fullName);
|
||||
}
|
||||
}
|
||||
#undef tryReadSlice
|
||||
|
||||
switch (mbc) {
|
||||
case ROM:
|
||||
if (!features) {
|
||||
break;
|
||||
}
|
||||
mbc = ROM_RAM - 1;
|
||||
static_assert(ROM_RAM + 1 == ROM_RAM_BATTERY, "Enum sanity check failed!");
|
||||
static_assert(MBC1 + 1 == MBC1_RAM, "Enum sanity check failed!");
|
||||
static_assert(MBC1 + 2 == MBC1_RAM_BATTERY, "Enum sanity check failed!");
|
||||
static_assert(MMM01 + 1 == MMM01_RAM, "Enum sanity check failed!");
|
||||
static_assert(MMM01 + 2 == MMM01_RAM_BATTERY, "Enum sanity check failed!");
|
||||
[[fallthrough]];
|
||||
case MBC1:
|
||||
case MMM01:
|
||||
if (features == RAM) {
|
||||
++mbc;
|
||||
} else if (features == (RAM | BATTERY)) {
|
||||
mbc += 2;
|
||||
} else if (features) {
|
||||
fatalWrongMBCFeatures(fullName);
|
||||
}
|
||||
break;
|
||||
|
||||
case MBC2:
|
||||
if (features == BATTERY) {
|
||||
mbc = MBC2_BATTERY;
|
||||
} else if (features) {
|
||||
fatalWrongMBCFeatures(fullName);
|
||||
}
|
||||
break;
|
||||
|
||||
case MBC3:
|
||||
// Handle timer, which also requires battery
|
||||
if (features & TIMER) {
|
||||
if (!(features & BATTERY)) {
|
||||
warning(WARNING_MBC, "MBC3+TIMER implies BATTERY");
|
||||
}
|
||||
features &= ~(TIMER | BATTERY); // Reset those bits
|
||||
mbc = MBC3_TIMER_BATTERY;
|
||||
// RAM is handled below
|
||||
}
|
||||
static_assert(MBC3 + 1 == MBC3_RAM, "Enum sanity check failed!");
|
||||
static_assert(MBC3 + 2 == MBC3_RAM_BATTERY, "Enum sanity check failed!");
|
||||
static_assert(
|
||||
MBC3_TIMER_BATTERY + 1 == MBC3_TIMER_RAM_BATTERY, "Enum sanity check failed!"
|
||||
);
|
||||
if (features == RAM) {
|
||||
++mbc;
|
||||
} else if (features == (RAM | BATTERY)) {
|
||||
mbc += 2;
|
||||
} else if (features) {
|
||||
fatalWrongMBCFeatures(fullName);
|
||||
}
|
||||
break;
|
||||
|
||||
case MBC5:
|
||||
if (features & RUMBLE) {
|
||||
features &= ~RUMBLE;
|
||||
mbc = MBC5_RUMBLE;
|
||||
}
|
||||
static_assert(MBC5 + 1 == MBC5_RAM, "Enum sanity check failed!");
|
||||
static_assert(MBC5 + 2 == MBC5_RAM_BATTERY, "Enum sanity check failed!");
|
||||
static_assert(MBC5_RUMBLE + 1 == MBC5_RUMBLE_RAM, "Enum sanity check failed!");
|
||||
static_assert(MBC5_RUMBLE + 2 == MBC5_RUMBLE_RAM_BATTERY, "Enum sanity check failed!");
|
||||
if (features == RAM) {
|
||||
++mbc;
|
||||
} else if (features == (RAM | BATTERY)) {
|
||||
mbc += 2;
|
||||
} else if (features) {
|
||||
fatalWrongMBCFeatures(fullName);
|
||||
}
|
||||
break;
|
||||
|
||||
case MBC6:
|
||||
case POCKET_CAMERA:
|
||||
case BANDAI_TAMA5:
|
||||
case HUC3:
|
||||
// No extra features accepted
|
||||
if (features) {
|
||||
fatalWrongMBCFeatures(fullName);
|
||||
}
|
||||
break;
|
||||
|
||||
case MBC7_SENSOR_RUMBLE_RAM_BATTERY:
|
||||
if (features != (SENSOR | RUMBLE | RAM | BATTERY)) {
|
||||
fatalWrongMBCFeatures(fullName);
|
||||
}
|
||||
break;
|
||||
|
||||
case HUC1_RAM_BATTERY:
|
||||
if (features != (RAM | BATTERY)) { // HuC1 expects RAM+BATTERY
|
||||
fatalWrongMBCFeatures(fullName);
|
||||
}
|
||||
break;
|
||||
|
||||
case TPP1:
|
||||
if (features & RAM) {
|
||||
warning(WARNING_MBC, "TPP1 requests RAM implicitly if given a non-zero RAM size");
|
||||
}
|
||||
if (features & BATTERY) {
|
||||
mbc |= 0x08;
|
||||
}
|
||||
if (features & TIMER) {
|
||||
mbc |= 0x04;
|
||||
}
|
||||
if (features & MULTIRUMBLE) {
|
||||
mbc |= 0x03; // Also set the rumble flag
|
||||
}
|
||||
if (features & RUMBLE) {
|
||||
mbc |= 0x01;
|
||||
}
|
||||
if (features & SENSOR) {
|
||||
fatalWrongMBCFeatures(fullName);
|
||||
}
|
||||
break;
|
||||
}
|
||||
|
||||
skipWhitespace(ptr); // Trim off trailing whitespace
|
||||
|
||||
// If there is still something past the whitespace, error out
|
||||
if (*ptr) {
|
||||
fatalUnknownMBC(fullName);
|
||||
}
|
||||
|
||||
return static_cast<MbcType>(mbc);
|
||||
}
|
||||
Reference in New Issue
Block a user