gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-29 06:17:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Report any section overflows at the end of assembly (#1482)

Browse Source 
* Report any section overflows at the end of assembly

* Immediately handle overflow of the 32-bit size counter
This commit is contained in:
Sylvie
2024-08-22 12:51:52 -04:00
committed by GitHub
parent 7bc9a24bf0
commit 0e8a17ce82
9 changed files with 94 additions and 119 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/asm/incbin-empty-bad.err
View File

@@ -1,3 +1,3 @@
error: incbin-empty-bad.asm(3):
Specified range in INCBIN is out of bounds (0 + 1 > 0)
Specified range in INCBIN file 'empty.bin' is out of bounds (0 + 1 > 0)
error: Assembly aborted (1 error)!

2
test/asm/incbin-end-bad.err
View File

@@ -1,3 +1,3 @@
error: incbin-end-bad.asm(3):
Specified range in INCBIN is out of bounds (123 + 1 > 123)
Specified range in INCBIN file 'data.bin' is out of bounds (123 + 1 > 123)
error: Assembly aborted (1 error)!

22
test/asm/load-overflow.asm
View File

@@ -1,25 +1,25 @@
SECTION "Overflow", ROM0
ds $6000
LOAD "oops",WRAM0
; We might get an error for "oops", but it can also make sense to no-op the directive
ds $2001
; We shouldn't get any more errors for "Overflow" nor "oops"
ds $2000
db
db
ENDL
SECTION "Moar overflow", ROM0
ds $6001
ds $4000
ds $4000
LOAD "hmm", WRAM0
ds $2000
; Since the `ds` overflows "Moar overflow", it could be no-op'd, making this `db` not error
db
ds $2000
ENDL
ds $1000
SECTION "Not overflowing", ROM0
ds $5FFF
ds $800
LOAD "lol", WRAM0
ds $2000
db
; Since the LOAD block is overflowed, this may be no-op'd, not affecting the "parent"
ds $1000
ds $1000
ds $1000
ENDL
dw ; This, however...
ds $800

24
test/asm/load-overflow.err
View File

@@ -1,11 +1,15 @@
error: load-overflow.asm(5):
Section 'Overflow' grew too big (max size = 0x8000 bytes, reached 0x8001).
error: load-overflow.asm(5):
Section 'oops' grew too big (max size = 0x2000 bytes, reached 0x2001).
error: load-overflow.asm(13):
Section 'Moar overflow' grew too big (max size = 0x8000 bytes, reached 0x8001).
error: load-overflow.asm(22):
Section 'lol' grew too big (max size = 0x2000 bytes, reached 0x2001).
error: load-overflow.asm(25):
Section 'Not overflowing' grew too big (max size = 0x8000 bytes, reached 0x8001).
warning: load-overflow.asm(5): [-Wempty-data-directive]
DB directive without data in ROM
warning: load-overflow.asm(6): [-Wempty-data-directive]
DB directive without data in ROM
error: load-overflow.asm(26):
Section 'Overflow' grew too big (max size = 0x8000 bytes, reached 0x8002).
error: load-overflow.asm(26):
Section 'oops' grew too big (max size = 0x2000 bytes, reached 0x2002).
error: load-overflow.asm(26):
Section 'Moar overflow' grew too big (max size = 0x8000 bytes, reached 0xD000).
error: load-overflow.asm(26):
Section 'hmm' grew too big (max size = 0x2000 bytes, reached 0x4000).
error: load-overflow.asm(26):
Section 'lol' grew too big (max size = 0x2000 bytes, reached 0x3000).
error: Assembly aborted (5 errors)!

9
test/asm/section-unsigned-overflow.asm Normal file
View File

@@ -0,0 +1,9 @@
section "overflow", rom0
rept 10
ds $4000_0000
endr
section "moar overflow", romx
rept 10
ds $4000_0000
endr

2
test/asm/section-unsigned-overflow.err Normal file
View File

@@ -0,0 +1,2 @@
FATAL: section-unsigned-overflow.asm(2) -> section-unsigned-overflow.asm::REPT~4(3):
Section size would overflow internal counter