From 148985493242cc14ea8831a8a667e417eacf86fb Mon Sep 17 00:00:00 2001 From: Rangi42 Date: Fri, 14 Feb 2025 16:30:06 +0100 Subject: [PATCH] Use more const references when possible --- include/asm/section.hpp | 10 +++++----- src/asm/section.cpp | 14 ++++++-------- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/include/asm/section.hpp b/include/asm/section.hpp index a776bcc4..9df672da 100644 --- a/include/asm/section.hpp +++ b/include/asm/section.hpp @@ -91,11 +91,11 @@ void sect_ByteString(std::vector const &string); void sect_WordString(std::vector const &string); void sect_LongString(std::vector const &string); void sect_Skip(uint32_t skip, bool ds); -void sect_RelByte(Expression &expr, uint32_t pcShift); -void sect_RelBytes(uint32_t n, std::vector &exprs); -void sect_RelWord(Expression &expr, uint32_t pcShift); -void sect_RelLong(Expression &expr, uint32_t pcShift); -void sect_PCRelByte(Expression &expr, uint32_t pcShift); +void sect_RelByte(Expression const &expr, uint32_t pcShift); +void sect_RelBytes(uint32_t n, std::vector const &exprs); +void sect_RelWord(Expression const &expr, uint32_t pcShift); +void sect_RelLong(Expression const &expr, uint32_t pcShift); +void sect_PCRelByte(Expression const &expr, uint32_t pcShift); void sect_BinaryFile(std::string const &name, int32_t startPos); void sect_BinaryFileSlice(std::string const &name, int32_t startPos, int32_t length); diff --git a/src/asm/section.cpp b/src/asm/section.cpp index 0af2c435..6415c7af 100644 --- a/src/asm/section.cpp +++ b/src/asm/section.cpp @@ -768,7 +768,7 @@ void sect_Skip(uint32_t skip, bool ds) { } // Output a byte that can be relocatable or constant -void sect_RelByte(Expression &expr, uint32_t pcShift) { +void sect_RelByte(Expression const &expr, uint32_t pcShift) { if (!requireCodeSection()) { return; } @@ -782,15 +782,13 @@ void sect_RelByte(Expression &expr, uint32_t pcShift) { } // Output several bytes that can be relocatable or constant -void sect_RelBytes(uint32_t n, std::vector &exprs) { +void sect_RelBytes(uint32_t n, std::vector const &exprs) { if (!requireCodeSection()) { return; } for (uint32_t i = 0; i < n; i++) { - Expression &expr = exprs[i % exprs.size()]; - - if (!expr.isKnown()) { + if (Expression const &expr = exprs[i % exprs.size()]; !expr.isKnown()) { createPatch(PATCHTYPE_BYTE, expr, i); writeByte(0); } else { @@ -800,7 +798,7 @@ void sect_RelBytes(uint32_t n, std::vector &exprs) { } // Output a word that can be relocatable or constant -void sect_RelWord(Expression &expr, uint32_t pcShift) { +void sect_RelWord(Expression const &expr, uint32_t pcShift) { if (!requireCodeSection()) { return; } @@ -814,7 +812,7 @@ void sect_RelWord(Expression &expr, uint32_t pcShift) { } // Output a long that can be relocatable or constant -void sect_RelLong(Expression &expr, uint32_t pcShift) { +void sect_RelLong(Expression const &expr, uint32_t pcShift) { if (!requireCodeSection()) { return; } @@ -828,7 +826,7 @@ void sect_RelLong(Expression &expr, uint32_t pcShift) { } // Output a PC-relative byte that can be relocatable or constant -void sect_PCRelByte(Expression &expr, uint32_t pcShift) { +void sect_PCRelByte(Expression const &expr, uint32_t pcShift) { if (!requireCodeSection()) { return; }