gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 10:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Using C++20 [[unlikely]] here would be excessive micro-optimization

Browse Source
This commit is contained in:
Rangi42
2024-12-23 14:14:10 -05:00
parent 22838ce2d8
commit 151f83db6d
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/link/object.cpp
View File

@@ -30,13 +30,11 @@ static std::vector<std::vector<FileStackNode>> nodes;
// Helper functions for reading object files // Helper functions for reading object files
// Internal, DO NOT USE. // For internal use only by `tryReadLong` and `tryGetc`!
// For helper wrapper macros defined below, such as `tryReadLong`
#define tryRead(func, type, errval, vartype, var, file, ...) \ #define tryRead(func, type, errval, vartype, var, file, ...) \
do { \ do { \
FILE *tmpFile = file; \ FILE *tmpFile = file; \
type tmpVal = func(tmpFile); \ type tmpVal = func(tmpFile); \
/* TODO: maybe mark the condition as `unlikely`; how to do that portably? */ \
if (tmpVal == (errval)) { \ if (tmpVal == (errval)) { \
errx(__VA_ARGS__, feof(tmpFile) ? "Unexpected end of file" : strerror(errno)); \ errx(__VA_ARGS__, feof(tmpFile) ? "Unexpected end of file" : strerror(errno)); \
} \ } \