gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-26 21:12:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow PUSHS to be used before a section

Browse Source 
Previously, a PUSHS before a SECTION directive would cause rgbasm to crash when encountering a subsequent POPS.

This is because the subsequently-called out_setCurrentSection() expected the new section to be non-null, which wasn’t the case in this situation. This has been addressed by allowing the ‘null’ section to be set in this function, and only dereferencing it (to set nPC) if a non-null section is to be set.

In practice, this means that PUSHS/POPS can now be used to push/restore a context without a section.
This commit is contained in:
Ben Hetherington
2019-08-16 13:20:15 +01:00
parent b019b03946
commit 16111f46ef
10 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/asm/pops-restore-no-section.asm Normal file
View File

@@ -0,0 +1,10 @@
PUSHS
SECTION "Test", ROM0
SomeContent:
db 1, 2, 3, 4, 5, 6, 7, 8, 9
POPS
DisallowedContent:
db 0