Reduce the header declarations (#1342)

- Since we have style rules to include foo.hpp at the top of its
  corresponding foo.cpp, this takes any headers included by foo.hpp
  as being also guaranteed for foo.cpp.

- Use C-style <foo.h> instead of <cfoo>, since the latter only
  guarantees putting symbols in the `std` namespace, which we are
  not using for C functions (e.g. `printf` not `std::printf`).

- Remove now-unused `__PRETTY_FUNCTION__` reporting

src/asm/charmap.cpp

@@ -5,12 +5,10 @@
 #include <errno.h>
 #include <map>
 #include <stack>
-#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <string>
-#include <vector>
 
 #include "util.hpp"
 

src/asm/fixpoint.cpp

@@ -4,9 +4,7 @@
 
 #include "asm/fixpoint.hpp"
 
-#include <inttypes.h>
 #include <math.h>
-#include <stdint.h>
 
 #include "asm/symbol.hpp"
 #include "asm/warning.hpp"

src/asm/format.cpp

@@ -6,7 +6,6 @@
 #include <assert.h>
 #include <inttypes.h>
 #include <math.h>
-#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>

src/asm/fstack.cpp

@@ -8,13 +8,8 @@
 #include <new>
 #include <optional>
 #include <stack>
-#include <stdint.h>
-#include <stdio.h>
 #include <stdlib.h>
-#include <string>
 #include <string_view>
-#include <variant>
-#include <vector>
 
 #include "error.hpp"
 #include "platform.hpp" // S_ISDIR (stat macro)

src/asm/lexer.cpp

@@ -11,20 +11,15 @@
 #include <limits.h>
 #include <math.h>
 #include <new>
-#include <optional>
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <string>
 #include <unordered_map>
-#include <variant>
-#include <vector>
 #ifndef _MSC_VER
 	#include <unistd.h>
 #endif
 
-#include "platform.hpp" // For `ssize_t` and `AT`
 #include "util.hpp"
 
 #include "asm/fixpoint.hpp"

src/asm/macro.cpp

@@ -6,11 +6,7 @@
 #include <inttypes.h>
 #include <new>
 #include <stdio.h>
-#include <stdlib.h>
 #include <string.h>
-#include <vector>
-
-#include "asm/warning.hpp"
 
 #define MAXMACROARGS 99999
 

src/asm/main.cpp

@@ -9,16 +9,12 @@
 #include <limits.h>
 #include <math.h>
 #include <stdarg.h>
-#include <stdint.h>
-#include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <string>
 #include <time.h>
 
 #include "error.hpp"
 #include "extern/getopt.hpp"
-#include "helpers.hpp"
 #include "parser.hpp"
 #include "version.hpp"
 

src/asm/opt.cpp

@@ -3,7 +3,6 @@
 #include <ctype.h>
 #include <errno.h>
 #include <stack>
-#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>

src/asm/output.cpp

@@ -1,7 +1,5 @@
 /* SPDX-License-Identifier: MIT */
 
-// Outputs an objectfile
-
 #include "asm/output.hpp"
 
 #include <algorithm>
@@ -9,7 +7,6 @@
 #include <deque>
 #include <errno.h>
 #include <inttypes.h>
-#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -17,7 +14,6 @@
 #include <vector>
 
 #include "error.hpp"
-#include "linkdefs.hpp"
 
 #include "asm/charmap.hpp"
 #include "asm/fstack.hpp"

src/asm/rpn.cpp

@@ -1,7 +1,5 @@
 /* SPDX-License-Identifier: MIT */
 
-// Controls RPN expressions for objectfiles
-
 #include "asm/rpn.hpp"
 
 #include <assert.h>
@@ -9,11 +7,9 @@
 #include <inttypes.h>
 #include <limits.h>
 #include <new>
-#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <vector>
 
 #include "opmath.hpp"
 

src/asm/section.cpp

@@ -4,7 +4,6 @@
 
 #include <algorithm>
 #include <assert.h>
-#include <deque>
 #include <errno.h>
 #include <inttypes.h>
 #include <optional>
@@ -13,10 +12,8 @@
 #include <stdlib.h>
 #include <string.h>
 #include <string>
-#include <vector>
 
 #include "error.hpp"
-#include "linkdefs.hpp"
 
 #include "asm/fstack.hpp"
 #include "asm/main.hpp"

src/asm/symbol.cpp

@@ -8,14 +8,7 @@
 #include <limits.h>
 #include <map>
 #include <new>
-#include <optional>
-#include <stdint.h>
 #include <stdio.h>
-#include <string.h>
-#include <string>
-#include <string_view>
-#include <time.h>
-#include <variant>
 
 #include "error.hpp"
 #include "helpers.hpp"
@@ -27,7 +20,6 @@
 #include "asm/macro.hpp"
 #include "asm/main.hpp"
 #include "asm/output.hpp"
-#include "asm/section.hpp"
 #include "asm/warning.hpp"
 
 std::map<std::string, Symbol> symbols;