Reduce the header declarations (#1342)

- Since we have style rules to include foo.hpp at the top of its
  corresponding foo.cpp, this takes any headers included by foo.hpp
  as being also guaranteed for foo.cpp.

- Use C-style <foo.h> instead of <cfoo>, since the latter only
  guarantees putting symbols in the `std` namespace, which we are
  not using for C functions (e.g. `printf` not `std::printf`).

- Remove now-unused `__PRETTY_FUNCTION__` reporting

src/gfx/main.cpp

@@ -4,15 +4,13 @@
 
 #include <algorithm>
 #include <assert.h>
-#include <cinttypes>
-#include <cstdint>
 #include <ctype.h>
 #include <fstream>
+#include <inttypes.h>
 #include <ios>
 #include <limits>
 #include <numeric>
 #include <stdarg.h>
-#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -27,7 +25,6 @@
 #include "gfx/pal_spec.hpp"
 #include "gfx/process.hpp"
 #include "gfx/reverse.hpp"
-#include "gfx/rgba.hpp"
 
 using namespace std::literals::string_view_literals;
 

src/gfx/pal_packing.cpp

@@ -5,20 +5,16 @@
 #include <algorithm>
 #include <assert.h>
 #include <bitset>
-#include <cinttypes>
 #include <deque>
+#include <inttypes.h>
 #include <numeric>
 #include <optional>
 #include <queue>
-#include <tuple>
 #include <type_traits>
 #include <unordered_set>
-#include <vector>
 
-#include "defaultinitalloc.hpp"
 #include "helpers.hpp"
 
-#include "gfx/main.hpp"
 #include "gfx/proto_palette.hpp"
 
 using std::swap;

src/gfx/pal_sorting.cpp

@@ -3,8 +3,6 @@
 #include "gfx/pal_sorting.hpp"
 
 #include <algorithm>
-#include <png.h>
-#include <vector>
 
 #include "helpers.hpp"
 

src/gfx/pal_spec.cpp

@@ -3,20 +3,19 @@
 #include "gfx/pal_spec.hpp"
 
 #include <algorithm>
-#include <cassert>
+#include <assert.h>
 #include <charconv>
-#include <cinttypes>
-#include <climits>
-#include <cstdint>
-#include <cstdio>
-#include <cstring>
 #include <fstream>
-#include <limits>
+#include <inttypes.h>
+#include <limits.h>
 #include <optional>
 #include <ostream>
+#include <stdint.h>
+#include <stdio.h>
 #include <streambuf>
-#include <string>
+#include <string.h>
 #include <string_view>
+#include <string>
 #include <tuple>
 #include <type_traits>
 #include <unordered_map>

src/gfx/process.cpp

@@ -4,16 +4,16 @@
 
 #include <algorithm>
 #include <assert.h>
-#include <cinttypes>
-#include <climits>
-#include <cstdio>
 #include <errno.h>
 #include <fstream>
+#include <inttypes.h>
+#include <limits.h>
 #include <memory>
 #include <optional>
 #include <png.h>
 #include <setjmp.h>
 #include <stdint.h>
+#include <stdio.h>
 #include <string.h>
 #include <tuple>
 #include <unordered_set>

src/gfx/proto_palette.cpp

@@ -2,11 +2,7 @@
 
 #include "gfx/proto_palette.hpp"
 
-#include <algorithm>
-#include <array>
-#include <cassert>
-#include <stddef.h>
-#include <stdint.h>
+#include <assert.h>
 
 #include "helpers.hpp"
 

src/gfx/reverse.cpp

@@ -5,9 +5,9 @@
 #include <algorithm>
 #include <array>
 #include <assert.h>
-#include <cinttypes>
 #include <errno.h>
 #include <fstream>
+#include <inttypes.h>
 #include <optional>
 #include <png.h>
 #include <string.h>