Reduce the header declarations (#1342)

- Since we have style rules to include foo.hpp at the top of its
  corresponding foo.cpp, this takes any headers included by foo.hpp
  as being also guaranteed for foo.cpp.

- Use C-style <foo.h> instead of <cfoo>, since the latter only
  guarantees putting symbols in the `std` namespace, which we are
  not using for C functions (e.g. `printf` not `std::printf`).

- Remove now-unused `__PRETTY_FUNCTION__` reporting

src/link/main.cpp

@@ -7,18 +7,12 @@
 #include <inttypes.h>
 #include <limits.h>
 #include <stdarg.h>
-#include <stdint.h>
-#include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <string>
-#include <variant>
-#include <vector>
 
 #include "error.hpp"
 #include "extern/getopt.hpp"
 #include "itertools.hpp"
-#include "linkdefs.hpp"
 #include "platform.hpp"
 #include "script.hpp"
 #include "version.hpp"

src/link/output.cpp

@@ -6,7 +6,6 @@
 #include <assert.h>
 #include <deque>
 #include <inttypes.h>
-#include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -18,7 +17,6 @@
 #include "linkdefs.hpp"
 
 #include "link/main.hpp"
-#include "link/section.hpp"
 #include "link/symbol.hpp"
 
 #define BANK_SIZE 0x4000

src/link/patch.cpp

@@ -3,7 +3,6 @@
 #include "link/patch.hpp"
 
 #include <assert.h>
-#include <deque>
 #include <inttypes.h>
 #include <limits.h>
 #include <stdlib.h>
@@ -12,12 +11,10 @@
 
 #include "error.hpp"
 #include "helpers.hpp"
-#include "linkdefs.hpp"
 #include "opmath.hpp"
 #include "platform.hpp"
 
 #include "link/object.hpp"
-#include "link/section.hpp"
 #include "link/symbol.hpp"
 
 struct RPNStackEntry {

src/link/script.y

@@ -17,8 +17,8 @@
 	#include <array>
 	#include <assert.h>
 	#include <bit>
-	#include <cinttypes>
 	#include <fstream>
+	#include <inttypes.h>
 	#include <locale>
 	#include <stdio.h>
 	#include <string_view>

src/link/sdas_obj.cpp

@@ -8,12 +8,10 @@
 #include <inttypes.h>
 #include <memory>
 #include <stdint.h>
-#include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <tuple>
 #include <variant>
-#include <vector>
 
 #include "helpers.hpp"
 #include "linkdefs.hpp"

src/link/section.cpp

@@ -5,15 +5,10 @@
 #include <assert.h>
 #include <inttypes.h>
 #include <map>
-#include <memory>
 #include <stdlib.h>
 #include <string.h>
-#include <string>
 
 #include "error.hpp"
-#include "linkdefs.hpp"
-
-#include "link/main.hpp"
 
 std::map<std::string, std::unique_ptr<Section>> sections;
 

src/link/symbol.cpp

@@ -5,8 +5,6 @@
 #include <inttypes.h>
 #include <map>
 #include <stdlib.h>
-#include <string>
-#include <variant>
 
 #include "error.hpp"
 #include "helpers.hpp"