gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-08-22 23:04:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix large ds in linker script overflowing the PC

Browse Source
This commit is contained in:
Rangi
2026-07-14 00:42:42 -04:00
parent c0ff3d92ad
commit 19e60d9864
6 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/link/layout.cpp
+3 -1
View File
@@ -204,7 +204,9 @@ void layout_Pad(uint32_t length) {
uint16_t &pc = curAddr[activeType][activeBankIdx];
assume(pc >= typeInfo.startAddr);
if (uint16_t offset = pc - typeInfo.startAddr; length + offset > typeInfo.size) {
// `length + offset` can overflow `uint32_t`, so check just `length` first
if (uint16_t offset = pc - typeInfo.startAddr;
length > typeInfo.size || length + offset > typeInfo.size) {
scriptError(
"Cannot increase the current address by %u bytes: only %u bytes to $%04" PRIx16,
length,