gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-09-02 03:48:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Guard against undefined behavior in double2fix

Browse Source 
I haven't found input which triggers any, but this is more
technically correct just in case.
This commit is contained in:
Rangi
2026-07-06 22:38:06 -04:00
parent fe3b238dea
commit 1e4a060d9e
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/asm/fixpoint.cpp
+4 -1
View File
@@ -8,6 +8,8 @@
#include <numbers> #include <numbers>
#include <stdint.h> #include <stdint.h>
#include "helpers.hpp" // assume
static constexpr double tau = std::numbers::pi * 2; static constexpr double tau = std::numbers::pi * 2;
static double fix2double(int32_t i, int32_t q) { static double fix2double(int32_t i, int32_t q) {
@@ -21,7 +23,8 @@ static int32_t double2fix(double d, int32_t q) {
if (isinf(d)) { if (isinf(d)) {
return d < 0 ? INT32_MIN : INT32_MAX; return d < 0 ? INT32_MIN : INT32_MAX;
} }
return static_cast<int32_t>(round(d * pow(2.0, q))); double v = round(d * pow(2.0, q));
return v < INT32_MIN ? INT32_MIN : v > INT32_MAX ? INT32_MAX : static_cast<int32_t>(v);
} }
static double turn2rad(double t) { static double turn2rad(double t) {