gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-30 06:47:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect line numbers with some IF blocks

Browse Source 
If a line ended with a string's closing quote, or a newline escape, then
skipping over that line via IF/ELIF/ELSE would fail to count that line,
offsetting the rest of the file.
I have no idea why but for some reason 9829be1 changed *specifically*
`if_skip_to_else` to have incorrect behavior on string endings. The incorrect
behavior on newline escapes seems to have been here since the beginning.
Also added a test to check for both of those behaviors in both functions.

Honestly, it baffles me that nobody ever noticed. I didn't until I started
working on #395.
This commit is contained in:
ISSOtm
2019-09-01 03:42:50 +02:00
parent 9b40663d54
commit 20b2f5ee2f
6 changed files with 33 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/asm/correct-line-number.out.pipe Normal file
View File

@@ -0,0 +1,4 @@
warning: -(5):
Am I geting ahead of myself?
warning: -(11):
Hopefully not.