gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-22 11:12:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use STD*_FILENO constants (#1055)

Browse Source 
These are defined in platform.h, but not consistently used

Co-authored-by: Eldred Habert <eldredhabert0@gmail.com>
This commit is contained in:
Rangi
2022-09-25 04:02:53 -04:00
committed by GitHub
parent b8385a50e3
commit 2827374505
3 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/asm/output.c
View File

@@ -492,7 +492,7 @@ void out_WriteObject(void)
if (strcmp(objectName, "-") != 0) if (strcmp(objectName, "-") != 0)
f = fopen(objectName, "wb"); f = fopen(objectName, "wb");
else else
f = fdopen(1, "wb"); f = fdopen(STDOUT_FILENO, "wb");
if (!f) if (!f)
err("Couldn't write file '%s'", objectName); err("Couldn't write file '%s'", objectName);

4
src/link/main.c
View File

@@ -154,9 +154,9 @@ FILE *openFile(char const *fileName, char const *mode)
if (strcmp(fileName, "-") != 0) if (strcmp(fileName, "-") != 0)
file = fopen(fileName, mode); file = fopen(fileName, mode);
else if (mode[0] == 'r') else if (mode[0] == 'r')
file = fdopen(0, mode); file = fdopen(STDIN_FILENO, mode);
else else
file = fdopen(1, mode); file = fdopen(STDOUT_FILENO, mode);
if (!file) if (!file)
err("Could not open file \"%s\"", fileName); err("Could not open file \"%s\"", fileName);

7
src/link/object.c
View File

@@ -459,7 +459,12 @@ static struct Section *getMainSection(struct Section *section)
void obj_ReadFile(char const *fileName, unsigned int fileID) void obj_ReadFile(char const *fileName, unsigned int fileID)
{ {
FILE *file = strcmp("-", fileName) ? fopen(fileName, "rb") : stdin; FILE *file;
if (strcmp("-", fileName) != 0)
file = fopen(fileName, "rb");
else
file = fdopen(STDIN_FILENO, "rb"); // `stdin` is in text mode by default
if (!file) if (!file)
err("Could not open file %s", fileName); err("Could not open file %s", fileName);