gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 18:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make implicit truncation a warning

Browse Source
This commit is contained in:
ISSOtm
2020-02-05 13:20:51 +01:00
parent 35f7340dc9
commit 28473d314a
3 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
include/asm/warning.h
View File

@@ -21,6 +21,7 @@ enum WarningID {
WARNING_SHIFT, WARNING_SHIFT,
WARNING_USER, WARNING_USER,
WARNING_SHIFT_AMOUNT, WARNING_SHIFT_AMOUNT,
WARNING_TRUNCATION,
NB_WARNINGS, NB_WARNINGS,

4
src/asm/asmy.y
View File

@@ -1190,7 +1190,7 @@ constlist_32bit_entry : /* empty */
const_8bit : relocconst const_8bit : relocconst
{ {
if( (!rpn_isReloc(&$1)) && (($1.nVal < -128) || ($1.nVal > 255)) ) if( (!rpn_isReloc(&$1)) && (($1.nVal < -128) || ($1.nVal > 255)) )
yyerror("Expression must be 8-bit"); warning(WARNING_TRUNCATION, "Expression must be 8-bit");
$$ = $1; $$ = $1;
} }
; ;
@@ -1198,7 +1198,7 @@ const_8bit : relocconst
const_16bit : relocconst const_16bit : relocconst
{ {
if ((!rpn_isReloc(&$1)) && (($1.nVal < -32768) || ($1.nVal > 65535))) if ((!rpn_isReloc(&$1)) && (($1.nVal < -32768) || ($1.nVal > 65535)))
yyerror("Expression must be 16-bit"); warning(WARNING_TRUNCATION, "Expression must be 16-bit");
$$ = $1; $$ = $1;
} }
; ;

2
src/asm/warning.c
View File

@@ -37,6 +37,7 @@ static enum WarningState const defaultWarnings[NB_WARNINGS] = {
WARNING_DISABLED, /* Shifting undefined behavior */ WARNING_DISABLED, /* Shifting undefined behavior */
WARNING_ENABLED, /* User warnings */ WARNING_ENABLED, /* User warnings */
WARNING_DISABLED, /* Strange shift amount */ WARNING_DISABLED, /* Strange shift amount */
WARNING_ENABLED, /* Implicit truncation loses some bits */
}; };
static enum WarningState warningStates[NB_WARNINGS]; static enum WarningState warningStates[NB_WARNINGS];
@@ -72,6 +73,7 @@ static char const *warningFlags[NB_WARNINGS_ALL] = {
"shift", "shift",
"user", "user",
"shift-amount", "shift-amount",
"truncation",
/* Meta warnings */ /* Meta warnings */
"all", "all",