gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-21 02:32:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup code of rgbfix, rgbgfx and external libs

Browse Source 
Follow Linux kernel coding style.

Signed-off-by: Antonio Niño Díaz <antonio_nd@outlook.com>
This commit is contained in:
Antonio Niño Díaz
2018-01-01 16:52:43 +01:00
parent f41c532400
commit 2ffaf72e39
17 changed files with 289 additions and 289 deletions
Download Patch File Download Diff File Expand all files Collapse all files

112
src/fix/main.c
View File

@@ -24,8 +24,7 @@
#include "extern/err.h"
#include "extern/version.h"
static void
usage(void)
static void print_usage(void)
{
printf(
"usage: rgbfix [-CcjsVv] [-i game_id] [-k licensee_str] [-l licensee_id]\n"
@@ -34,8 +33,7 @@ usage(void)
exit(1);
}
int
main(int argc, char *argv[])
int main(int argc, char *argv[])
{
FILE *rom;
int ch;
@@ -81,10 +79,9 @@ main(int argc, char *argv[])
case 'i':
setid = true;
if (strlen(optarg) != 4) {
errx(1, "Game ID %s must be exactly 4 "
"characters", optarg);
}
if (strlen(optarg) != 4)
errx(1, "Game ID %s must be exactly 4 characters",
optarg);
id = optarg;
break;
@@ -94,10 +91,9 @@ main(int argc, char *argv[])
case 'k':
setnewlicensee = true;
if (strlen(optarg) != 2) {
errx(1, "New licensee code %s is not the "
"correct length of 2 characters", optarg);
}
if (strlen(optarg) != 2)
errx(1, "New licensee code %s is not the correct length of 2 characters",
optarg);
newlicensee = optarg;
break;
@@ -105,61 +101,59 @@ main(int argc, char *argv[])
setlicensee = true;
licensee = strtoul(optarg, &ep, 0);
if (optarg[0] == '\0' || *ep != '\0') {
if (optarg[0] == '\0' || *ep != '\0')
errx(1, "Invalid argument for option 'l'");
}
if (licensee < 0 || licensee > 0xFF) {
errx(1, "Argument for option 'l' must be "
"between 0 and 255");
}
if (licensee < 0 || licensee > 0xFF)
errx(1, "Argument for option 'l' must be between 0 and 255");
break;
case 'm':
setcartridge = true;
cartridge = strtoul(optarg, &ep, 0);
if (optarg[0] == '\0' || *ep != '\0') {
if (optarg[0] == '\0' || *ep != '\0')
errx(1, "Invalid argument for option 'm'");
}
if (cartridge < 0 || cartridge > 0xFF) {
errx(1, "Argument for option 'm' must be "
"between 0 and 255");
}
if (cartridge < 0 || cartridge > 0xFF)
errx(1, "Argument for option 'm' must be between 0 and 255");
break;
case 'n':
setversion = true;
version = strtoul(optarg, &ep, 0);
if (optarg[0] == '\0' || *ep != '\0') {
if (optarg[0] == '\0' || *ep != '\0')
errx(1, "Invalid argument for option 'n'");
}
if (version < 0 || version > 0xFF) {
errx(1, "Argument for option 'n' must be "
"between 0 and 255");
}
if (version < 0 || version > 0xFF)
errx(1, "Argument for option 'n' must be between 0 and 255");
break;
case 'p':
resize = true;
padvalue = strtoul(optarg, &ep, 0);
if (optarg[0] == '\0' || *ep != '\0') {
if (optarg[0] == '\0' || *ep != '\0')
errx(1, "Invalid argument for option 'p'");
}
if (padvalue < 0 || padvalue > 0xFF) {
errx(1, "Argument for option 'p' must be "
"between 0 and 255");
}
if (padvalue < 0 || padvalue > 0xFF)
errx(1, "Argument for option 'p' must be between 0 and 255");
break;
case 'r':
setramsize = true;
ramsize = strtoul(optarg, &ep, 0);
if (optarg[0] == '\0' || *ep != '\0') {
if (optarg[0] == '\0' || *ep != '\0')
errx(1, "Invalid argument for option 'r'");
}
if (ramsize < 0 || ramsize > 0xFF) {
errx(1, "Argument for option 'r' must be "
"between 0 and 255");
}
if (ramsize < 0 || ramsize > 0xFF)
errx(1, "Argument for option 'r' must be between 0 and 255");
break;
case 's':
super = true;
@@ -167,14 +161,13 @@ main(int argc, char *argv[])
case 't':
settitle = true;
if (strlen(optarg) > 16) {
errx(1, "Title %s is greater than the "
"maximum of 16 characters", optarg);
}
if (strlen(optarg) > 16)
errx(1, "Title \"%s\" is greater than the maximum of 16 characters",
optarg);
if (strlen(optarg) == 16)
warnx("Title %s is 16 chars, it is best to "
"keep it to 15 or fewer", optarg);
warnx("Title \"%s\" is 16 chars, it is best to keep it to 15 or fewer",
optarg);
title = optarg;
break;
@@ -185,7 +178,7 @@ main(int argc, char *argv[])
validate = true;
break;
default:
usage();
print_usage();
/* NOTREACHED */
}
}
@@ -194,15 +187,16 @@ main(int argc, char *argv[])
argv += optind;
if (argc == 0)
usage();
print_usage();
/*
* Open the ROM file
*/
if ((rom = fopen(argv[argc - 1], "rb+")) == NULL) {
rom = fopen(argv[argc - 1], "rb+");
if (rom == NULL)
err(1, "Error opening file %s", argv[argc - 1]);
}
/*
* Write changes to ROM
@@ -266,7 +260,7 @@ main(int argc, char *argv[])
* characters).
*/
fseek(rom,0x13F,SEEK_SET);
fseek(rom, 0x13F, SEEK_SET);
fwrite(id, 1, 4, rom);
}
@@ -332,8 +326,7 @@ main(int argc, char *argv[])
*/
if (!setlicensee)
warnx("You should probably set both '-s' and "
"'-l 0x33'");
warnx("You should probably set both '-s' and '-l 0x33'");
fseek(rom, 0x146, SEEK_SET);
fputc(3, rom);
@@ -360,6 +353,7 @@ main(int argc, char *argv[])
long romsize, newsize;
int headbyte;
uint8_t *buf;
fseek(rom, 0, SEEK_END);
romsize = ftell(rom);
newsize = 0x8000;
@@ -433,9 +427,8 @@ main(int argc, char *argv[])
* Offset 0x14D: Header Checksum
*/
uint8_t headcksum;
uint8_t headcksum = 0;
headcksum = 0;
fseek(rom, 0x134, SEEK_SET);
for (int i = 0; i < (0x14D - 0x134); ++i)
headcksum = headcksum - fgetc(rom) - 1;
@@ -447,15 +440,14 @@ main(int argc, char *argv[])
* Offset 0x14E–0x14F: Global Checksum
*/
uint16_t globalcksum;
globalcksum = 0;
uint16_t globalcksum = 0;
rewind(rom);
for (int i = 0; i < 0x14E; ++i)
globalcksum += fgetc(rom);
int byte;
fseek(rom, 0x150, SEEK_SET);
while ((byte = fgetc(rom)) != EOF)
globalcksum += byte;