From 306a83a4b4bbb78b23be02cee8428ce3331afa70 Mon Sep 17 00:00:00 2001
From: Eldred Habert <me@eldred.fr>
Date: Mon, 21 Sep 2026 19:05:47 +0200
Subject: [PATCH] Avoid double-zipping the binaries

https://github.blog/changelog/2026-02-26-github-actions-now-supports-uploading-and-downloading-non-zipped-artifacts/
---
 .github/workflows/create-release-artifacts.yml | 2 +-
 .github/workflows/testing.yml                  | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/create-release-artifacts.yml b/.github/workflows/create-release-artifacts.yml
index 5c711e08..3f5a7331 100644
--- a/.github/workflows/create-release-artifacts.yml
+++ b/.github/workflows/create-release-artifacts.yml
@@ -52,8 +52,8 @@ jobs:
       - name: Upload Windows binaries
         uses: actions/upload-artifact@v7
         with:
-          name: win${{ matrix.bits }}
           path: build/rgbds-win${{ matrix.bits }}.zip
+          archive: false
           if-no-files-found: error
 
   macos:
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
index c9e4261f..a0f2f28a 100644
--- a/.github/workflows/testing.yml
+++ b/.github/workflows/testing.yml
@@ -211,12 +211,12 @@ jobs:
       - name: Package binaries
         working-directory: build
         run: |
-          cpack -DCPACK_PACKAGE_FILE_NAME=rgbds-win${{ matrix.bits }} -G ZIP --verbose
+          cpack -DCPACK_PACKAGE_FILE_NAME=rgbds-canary-w${{ matrix.bits }}-${{ matrix.os }} -G ZIP --verbose
       - name: Upload Windows binaries
         uses: actions/upload-artifact@v7
         with:
-          name: rgbds-canary-w${{ matrix.bits }}-${{ matrix.os }}
-          path: build/rgbds-win${{ matrix.bits }}.zip
+          path: build/rgbds-canary-w${{ matrix.bits }}-${{ matrix.os }}.zip
+          archive: false
           if-no-files-found: error
       - name: Compute test dependency cache params
         id: test-deps-cache-params