gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-28 05:47:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove previously deprecated features (#1777)

Browse Source 
- Treating multi-unit strings as numbers
- `rgbasm -Wnumeric-string`
- `ldio [c], a` and `ldio a, [c]` (use `ldh`)
- `ld [c], a` and `ld a, [c]` (use `ldh`)
- `ldh [$xx], a` and `ldh a, [$xx]` (use `$FFxx`)
This commit is contained in:
Rangi
2025-08-05 16:24:10 -04:00
committed by GitHub
parent a3983b7b0f
commit 39f0f9edc0
30 changed files with 95 additions and 317 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/asm/db-dw-dl-string.asm
View File

@@ -11,7 +11,3 @@ SECTION "Test", ROM0
db "A" + 1
dw "A" + 1
dl "A" + 1
db 1, ("WXYZ") & $ff, -1
dw 1, ("WXYZ") & $ffff, -1
dl 1, ("WXYZ"), -1

6
test/asm/db-dw-dl-string.err
View File

@@ -1,6 +0,0 @@
warning: db-dw-dl-string.asm(15): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: db-dw-dl-string.asm(16): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: db-dw-dl-string.asm(17): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated

BIN
test/asm/db-dw-dl-string.out.bin
View File

Binary file not shown.

31
test/asm/deprecated-ldio.asm
View File

@@ -1,31 +0,0 @@
SECTION "LDIO", ROM0
ldh [c], a
ldh a, [c]
ldh [$11], a
ldh a, [$11]
ld [$ff00+c], a
ld a, [$ff00+c]
ld [$ff11], a
ld a, [$ff11]
ldio [c], a
ldio a, [c]
ldio [$ff11], a
ldio a, [$ff11]
LDH [C], A
LDH A, [C]
LDH [$11], A
LDH A, [$11]
LD [$FF00+C], A
LD A, [$FF00+C]
LD [$FF11], A
LD A, [$FF11]
LDIO [C], A
LDIO A, [C]
LDIO [$FF11], A
LDIO A, [$FF11]

24
test/asm/deprecated-ldio.err
View File

@@ -1,24 +0,0 @@
warning: deprecated-ldio.asm(5): [-Wobsolete]
LDH is deprecated with values from $00 to $FF; use $FF00 to $FFFF
warning: deprecated-ldio.asm(6): [-Wobsolete]
LDH is deprecated with values from $00 to $FF; use $FF00 to $FFFF
warning: deprecated-ldio.asm(13): [-Wobsolete]
LDIO is deprecated; use LDH
warning: deprecated-ldio.asm(14): [-Wobsolete]
LDIO is deprecated; use LDH
warning: deprecated-ldio.asm(15): [-Wobsolete]
LDIO is deprecated; use LDH
warning: deprecated-ldio.asm(16): [-Wobsolete]
LDIO is deprecated; use LDH
warning: deprecated-ldio.asm(20): [-Wobsolete]
LDH is deprecated with values from $00 to $FF; use $FF00 to $FFFF
warning: deprecated-ldio.asm(21): [-Wobsolete]
LDH is deprecated with values from $00 to $FF; use $FF00 to $FFFF
warning: deprecated-ldio.asm(28): [-Wobsolete]
LDIO is deprecated; use LDH
warning: deprecated-ldio.asm(29): [-Wobsolete]
LDIO is deprecated; use LDH
warning: deprecated-ldio.asm(30): [-Wobsolete]
LDIO is deprecated; use LDH
warning: deprecated-ldio.asm(31): [-Wobsolete]
LDIO is deprecated; use LDH

1
test/asm/deprecated-ldio.out.bin
View File

@@ -1 +0,0 @@
<EFBFBD><EFBFBD><EFBFBD><11><11><><EFBFBD><11><><11><><EFBFBD><EFBFBD><11><11><><EFBFBD><11><11><><EFBFBD><11><><11><><EFBFBD><EFBFBD><11>

5
test/asm/empty-strings.err
View File

@@ -1,2 +1,3 @@
warning: empty-strings.asm(5): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
error: empty-strings.asm(5):
Strings as numbers must be a single charmap unit
Assembly aborted with 1 error!

3
test/asm/invalid-ldh.asm Normal file
View File

@@ -0,0 +1,3 @@
SECTION "test", ROM0
ldh [$11], a
ldh a, [$22]

5
test/asm/invalid-ldh.err Normal file
View File

@@ -0,0 +1,5 @@
error: invalid-ldh.asm(2):
Source address $11 not between $FF00 to $FFFF
error: invalid-ldh.asm(3):
Source address $22 not between $FF00 to $FFFF
Assembly aborted with 2 errors!

12
test/asm/multiple-charmaps.asm
View File

@@ -43,7 +43,7 @@ charmap "ab", $0
new_ map1
print_mapped "ab"
print_mapped "ab" ; error
new_ map2, main
@@ -51,7 +51,7 @@ charmap "ab", $0
set_ map1
print_mapped "ab"
print_mapped "ab" ; error
new_ map3
@@ -70,7 +70,7 @@ charmap "cd", $2
set_ map3
print_mapped "ab"
print_mapped "cd"
print_mapped "cd" ; error
set_ main
@@ -92,8 +92,8 @@ charmap "ef", $3
push_set_ map3
print_mapped "ab"
print_mapped "cd"
print_mapped "ef"
print_mapped "cd" ; error
print_mapped "ef" ; error
pop_
@@ -101,7 +101,7 @@ charmap "ef", $3
pop_
print_mapped "ab"
print_mapped "ab" ; error
new_ map1

26
test/asm/multiple-charmaps.err
View File

@@ -1,21 +1,21 @@
warning: multiple-charmaps.asm(46) -> multiple-charmaps.asm::print_mapped(34): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: multiple-charmaps.asm(54) -> multiple-charmaps.asm::print_mapped(34): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
error: multiple-charmaps.asm(46) -> multiple-charmaps.asm::print_mapped(34):
Strings as numbers must be a single charmap unit
error: multiple-charmaps.asm(54) -> multiple-charmaps.asm::print_mapped(34):
Strings as numbers must be a single charmap unit
warning: multiple-charmaps.asm(64): [-Wcharmap-redef]
Overriding charmap mapping
warning: multiple-charmaps.asm(73) -> multiple-charmaps.asm::print_mapped(34): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: multiple-charmaps.asm(95) -> multiple-charmaps.asm::print_mapped(34): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: multiple-charmaps.asm(96) -> multiple-charmaps.asm::print_mapped(34): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: multiple-charmaps.asm(104) -> multiple-charmaps.asm::print_mapped(34): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
error: multiple-charmaps.asm(73) -> multiple-charmaps.asm::print_mapped(34):
Strings as numbers must be a single charmap unit
error: multiple-charmaps.asm(95) -> multiple-charmaps.asm::print_mapped(34):
Strings as numbers must be a single charmap unit
error: multiple-charmaps.asm(96) -> multiple-charmaps.asm::print_mapped(34):
Strings as numbers must be a single charmap unit
error: multiple-charmaps.asm(104) -> multiple-charmaps.asm::print_mapped(34):
Strings as numbers must be a single charmap unit
error: multiple-charmaps.asm(106) -> multiple-charmaps.asm::new_(9):
Charmap 'map1' already exists
error: multiple-charmaps.asm(108) -> multiple-charmaps.asm::set_(15):
Charmap 'map5' doesn't exist
error: multiple-charmaps.asm(110) -> multiple-charmaps.asm::pop_(30):
No entries in the charmap stack
Assembly aborted with 3 errors!
Assembly aborted with 9 errors!

12
test/asm/multiple-charmaps.out
View File

@@ -1,11 +1,11 @@
main charmap
$0
newcharmap map1
$6162
$0
newcharmap map2, main
$0
setcharmap map1
$6162
$0
newcharmap map3
$1
newcharmap map4, map3
@@ -13,7 +13,7 @@ $1
$2
setcharmap map3
$1
$6364
$0
setcharmap main
$0
modify main charmap
@@ -24,12 +24,12 @@ pushc
setcharmap map2
pushc map3
$1
$6364
$6566
$0
$0
popc
$0
popc
$6162
$0
newcharmap map1
setcharmap map5
popc

6
test/asm/multivalue-charmap.asm
View File

@@ -24,12 +24,12 @@ dl "AB" ; dl $01234567, $fedcba98
charmap "C", $01, $23, $45, $67
charmap "D", $fe, $dc, $ba, $98
assert "C" == $01234567
assert "D" == $fedcba98
assert CHARVAL("C", 0) == $01 && CHARVAL("C", 3) == $67
assert CHARVAL("D", 1) == $dc && CHARVAL("D", 2) == $ba
db "CD" ; db $01, $23, $45, $67, $fe, $dc, $ba, $98
dw "CD" ; dw $01, $23, $45, $67, $fe, $dc, $ba, $98
charmap "E", $01, $2345, $6789ab, $cdef
assert "E" == $0145abef
assert CHARSIZE("E") == 4 && CHARVAL("E", 2) == $6789ab
db "E" ; db $01, $2345, $6789ab, $cdef (truncated to $01, $45, $ab, $ef)
dl "E" ; dl $01, $2345, $6789ab, $cdef

8
test/asm/multivalue-charmap.err
View File

@@ -2,13 +2,5 @@ warning: multivalue-charmap.asm(11): [-Wtruncation]
All character units must be 8-bit
warning: multivalue-charmap.asm(22): [-Wtruncation]
All character units must be 8-bit
warning: multivalue-charmap.asm(27): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: multivalue-charmap.asm(28): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: multivalue-charmap.asm(33): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: multivalue-charmap.asm(33): [-Wtruncation]
All character units must be 8-bit
warning: multivalue-charmap.asm(34): [-Wtruncation]
All character units must be 8-bit

10
test/asm/nested-bad-interpolation.err
View File

@@ -6,12 +6,12 @@ error: nested-bad-interpolation.asm(1):
syntax error, unexpected end of line
error: nested-bad-interpolation.asm(2):
Interpolated symbol "b" is a reserved keyword; add a '#' prefix to use it as a raw symbol
warning: nested-bad-interpolation.asm(2): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
error: nested-bad-interpolation.asm(2):
Strings as numbers must be a single charmap unit
error: nested-bad-interpolation.asm(3):
Interpolated symbol "c" is a reserved keyword; add a '#' prefix to use it as a raw symbol
error: nested-bad-interpolation.asm(3):
Interpolated symbol "" does not exist
warning: nested-bad-interpolation.asm(3): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
Assembly aborted with 6 errors!
error: nested-bad-interpolation.asm(3):
Strings as numbers must be a single charmap unit
Assembly aborted with 8 errors!

2
test/asm/raw-string-symbol-errors.asm
View File

@@ -4,7 +4,7 @@ macro m
endm
assert (#n) == 42
assert (#s) == $656c6c6f
assert (#s) == 0
assert (#m) == 0
assert (#u) == 0

10
test/asm/raw-string-symbol-errors.err
View File

@@ -1,5 +1,5 @@
warning: raw-string-symbol-errors.asm(7): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
error: raw-string-symbol-errors.asm(7):
Strings as numbers must be a single charmap unit
error: raw-string-symbol-errors.asm(8):
'm' is not a numeric symbol
error: raw-string-symbol-errors.asm(11):
@@ -8,8 +8,8 @@ error: raw-string-symbol-errors.asm(13):
'm' is not a string symbol
error: raw-string-symbol-errors.asm(14):
'u' is not a string symbol
warning: raw-string-symbol-errors.asm(17): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
error: raw-string-symbol-errors.asm(17):
Strings as numbers must be a single charmap unit
error: raw-string-symbol-errors.asm(18):
'm' is not a numeric symbol
error: raw-string-symbol-errors.asm(19):
@@ -24,4 +24,4 @@ error: raw-string-symbol-errors.asm(27):
's' was already purged
error: raw-string-symbol-errors.asm(29):
's' is not a string symbol
Assembly aborted with 11 errors!
Assembly aborted with 13 errors!

25
test/asm/warn-numeric-string.asm
View File

@@ -1,25 +0,0 @@
opt Wno-unmapped-char
charmap "<NULL>", $00
SECTION "ROM", ROM0
MACRO try
OPT \1
; no warning
db "A" * 2
db ("<NULL>")
; warn at level 1
dl ("AB<NULL>CD")
dl "<NULL" + ">NULL>"
; warn at level 2
dl (STRCAT("A", "B"))
dl "A<NULL>Z" + 1
ENDM
try Wno-numeric-string
try Wnumeric-string
try Wnumeric-string=0
try Wnumeric-string=1
try Wnumeric-string=2
try Werror=numeric-string=1
try Werror=numeric-string=2

84
test/asm/warn-numeric-string.err
View File

@@ -1,84 +0,0 @@
warning: warn-numeric-string.asm(19) -> warn-numeric-string.asm::try(7): [-Wobsolete]
Warning flag "numeric-string" is deprecated
warning: warn-numeric-string.asm(19) -> warn-numeric-string.asm::try(12): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(19) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(19) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(19) -> warn-numeric-string.asm::try(15): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(19) -> warn-numeric-string.asm::try(16): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(20) -> warn-numeric-string.asm::try(7): [-Wobsolete]
Warning flag "numeric-string" is deprecated
warning: warn-numeric-string.asm(20) -> warn-numeric-string.asm::try(12): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(20) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(20) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(20) -> warn-numeric-string.asm::try(15): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(20) -> warn-numeric-string.asm::try(16): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(21) -> warn-numeric-string.asm::try(7): [-Wobsolete]
Warning flag "numeric-string" is deprecated
warning: warn-numeric-string.asm(21) -> warn-numeric-string.asm::try(12): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(21) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(21) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(21) -> warn-numeric-string.asm::try(15): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(21) -> warn-numeric-string.asm::try(16): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(22) -> warn-numeric-string.asm::try(7): [-Wobsolete]
Warning flag "numeric-string" is deprecated
warning: warn-numeric-string.asm(22) -> warn-numeric-string.asm::try(12): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(22) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(22) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(22) -> warn-numeric-string.asm::try(15): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(22) -> warn-numeric-string.asm::try(16): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(23) -> warn-numeric-string.asm::try(7): [-Wobsolete]
Warning flag "numeric-string" is deprecated
warning: warn-numeric-string.asm(23) -> warn-numeric-string.asm::try(12): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(23) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(23) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(23) -> warn-numeric-string.asm::try(15): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(23) -> warn-numeric-string.asm::try(16): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(24) -> warn-numeric-string.asm::try(7): [-Wobsolete]
Warning flag "numeric-string" is deprecated
warning: warn-numeric-string.asm(24) -> warn-numeric-string.asm::try(12): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(24) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(24) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(24) -> warn-numeric-string.asm::try(15): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(24) -> warn-numeric-string.asm::try(16): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(25) -> warn-numeric-string.asm::try(7): [-Wobsolete]
Warning flag "numeric-string" is deprecated
warning: warn-numeric-string.asm(25) -> warn-numeric-string.asm::try(12): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(25) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(25) -> warn-numeric-string.asm::try(13): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(25) -> warn-numeric-string.asm::try(15): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated
warning: warn-numeric-string.asm(25) -> warn-numeric-string.asm::try(16): [-Wobsolete]
Treating multi-unit strings as numbers is deprecated

5
test/link/invalid-patches.out
View File

@@ -1,10 +1,9 @@
error: invalid-patches.asm(10): JR target must be between -128 and 127 bytes away, not 190; use JP instead
warning: invalid-patches.asm(9): [-Wobsolete]
LDH is deprecated with values from $00 to $FF; use $FF00 to $FFFF
error: invalid-patches.asm(9): Address $0 for LDH is not in HRAM range
error: invalid-patches.asm(8): Requested SIZEOF() of section "NonexistentSection", which was not found
error: invalid-patches.asm(7): Requested STARTOF() of section "NonexistentSection", which was not found
error: invalid-patches.asm(6): Requested BANK() of section "NonexistentSection", which was not found
error: invalid-patches.asm(5): Requested BANK() of symbol "NonexistentSymbol", which was not found
error: invalid-patches.asm(4): Exponent by negative value -1
error: invalid-patches.asm(3): Modulo by 0
Linking failed with 7 errors
Linking failed with 8 errors