gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 18:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle unknown MBCs, since raw numeric values are accepted

Browse Source
This commit is contained in:
Rangi42
2025-07-26 14:15:05 -04:00
parent aa46c79db6
commit 3bc8b1ff7c
3 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/fix/mbc.cpp
View File

@@ -96,11 +96,13 @@ static void fatalWithMBCNames(char const *fmt, ...) {
} }
char const *mbc_Name(MbcType type) { char const *mbc_Name(MbcType type) {
return mbcData[type].first; auto search = mbcData.find(type);
return search != mbcData.end() ? search->second.first : "(unknown)";
} }
bool mbc_HasRAM(MbcType type) { bool mbc_HasRAM(MbcType type) {
return mbcData[type].second; auto search = mbcData.find(type);
return search != mbcData.end() && search->second.second;
} }
static void skipWhitespace(char const *&ptr) { static void skipWhitespace(char const *&ptr) {

2
test/fix/bad-mbc-number.err Normal file
View File

@@ -0,0 +1,2 @@
warning: [-Wmbc]
MBC "(unknown)" has no RAM, but RAM size was set to 2

1
test/fix/bad-mbc-number.flags Normal file
View File

@@ -0,0 +1 @@
-r 2 -m 42