gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 18:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix spurious truncation warning (#1238)

Browse Source
This commit is contained in:
Rangi
2023-11-20 16:51:51 -05:00
committed by GitHub
parent 232416b30d
commit 3c0879a3c6
4 changed files with 49 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
man/rgbasm.1
View File

@@ -298,7 +298,7 @@ or
.Fl Wno-truncation .Fl Wno-truncation
disables this warning. disables this warning.
.Fl Wtruncation=1 .Fl Wtruncation=1
warns when an N-bit value's absolute value is 2**N or greater. warns when an N-bit value is 2**N or greater, or less than -2**N.
.Fl Wtruncation=2 .Fl Wtruncation=2
or just or just
.Fl Wtruncation .Fl Wtruncation

2
src/asm/rpn.cpp
View File

@@ -292,7 +292,7 @@ void rpn_CheckNBit(struct Expression const *expr, uint8_t n)
if (rpn_isKnown(expr)) { if (rpn_isKnown(expr)) {
int32_t val = expr->val; int32_t val = expr->val;
if (val <= -(1 << n) || val >= 1 << n) if (val < -(1 << n) || val >= 1 << n)
warning(WARNING_TRUNCATION_1, "Expression must be %u-bit\n", n); warning(WARNING_TRUNCATION_1, "Expression must be %u-bit\n", n);
else if (val < -(1 << (n - 1))) else if (val < -(1 << (n - 1)))
warning(WARNING_TRUNCATION_2, "Expression must be %u-bit\n", n); warning(WARNING_TRUNCATION_2, "Expression must be %u-bit\n", n);

2
test/asm/warn-truncation.asm
View File

@@ -27,6 +27,8 @@ MACRO try
; warn at level 2 ; warn at level 2
db ~(1 << BAR_F) db ~(1 << BAR_F)
dw -wLabel dw -wLabel
db ~$ff
dw ~$ffff
ENDM ENDM
try Wno-truncation try Wno-truncation

78
test/asm/warn-truncation.err
View File

@@ -1,15 +1,3 @@
warning: warn-truncation.asm(33) -> warn-truncation.asm::try(23): [-Wtruncation]
Expression must be 8-bit
warning: warn-truncation.asm(33) -> warn-truncation.asm::try(24): [-Wtruncation]
Expression must be 8-bit
warning: warn-truncation.asm(33) -> warn-truncation.asm::try(25): [-Wtruncation]
Expression must be 16-bit
warning: warn-truncation.asm(33) -> warn-truncation.asm::try(26): [-Wtruncation]
Expression must be 16-bit
warning: warn-truncation.asm(33) -> warn-truncation.asm::try(28): [-Wtruncation]
Expression must be 8-bit
warning: warn-truncation.asm(33) -> warn-truncation.asm::try(29): [-Wtruncation]
Expression must be 16-bit
warning: warn-truncation.asm(35) -> warn-truncation.asm::try(23): [-Wtruncation] warning: warn-truncation.asm(35) -> warn-truncation.asm::try(23): [-Wtruncation]
Expression must be 8-bit Expression must be 8-bit
warning: warn-truncation.asm(35) -> warn-truncation.asm::try(24): [-Wtruncation] warning: warn-truncation.asm(35) -> warn-truncation.asm::try(24): [-Wtruncation]
@@ -18,35 +6,59 @@ warning: warn-truncation.asm(35) -> warn-truncation.asm::try(25): [-Wtruncation]
Expression must be 16-bit Expression must be 16-bit
warning: warn-truncation.asm(35) -> warn-truncation.asm::try(26): [-Wtruncation] warning: warn-truncation.asm(35) -> warn-truncation.asm::try(26): [-Wtruncation]
Expression must be 16-bit Expression must be 16-bit
warning: warn-truncation.asm(36) -> warn-truncation.asm::try(23): [-Wtruncation] warning: warn-truncation.asm(35) -> warn-truncation.asm::try(28): [-Wtruncation]
Expression must be 8-bit Expression must be 8-bit
warning: warn-truncation.asm(36) -> warn-truncation.asm::try(24): [-Wtruncation] warning: warn-truncation.asm(35) -> warn-truncation.asm::try(29): [-Wtruncation]
Expression must be 16-bit
warning: warn-truncation.asm(35) -> warn-truncation.asm::try(30): [-Wtruncation]
Expression must be 8-bit Expression must be 8-bit
warning: warn-truncation.asm(36) -> warn-truncation.asm::try(25): [-Wtruncation] warning: warn-truncation.asm(35) -> warn-truncation.asm::try(31): [-Wtruncation]
Expression must be 16-bit Expression must be 16-bit
warning: warn-truncation.asm(36) -> warn-truncation.asm::try(26): [-Wtruncation] warning: warn-truncation.asm(37) -> warn-truncation.asm::try(23): [-Wtruncation]
Expression must be 16-bit
warning: warn-truncation.asm(36) -> warn-truncation.asm::try(28): [-Wtruncation]
Expression must be 8-bit Expression must be 8-bit
warning: warn-truncation.asm(36) -> warn-truncation.asm::try(29): [-Wtruncation] warning: warn-truncation.asm(37) -> warn-truncation.asm::try(24): [-Wtruncation]
Expression must be 16-bit
error: warn-truncation.asm(37) -> warn-truncation.asm::try(23): [-Werror=truncation]
Expression must be 8-bit Expression must be 8-bit
error: warn-truncation.asm(37) -> warn-truncation.asm::try(24): [-Werror=truncation] warning: warn-truncation.asm(37) -> warn-truncation.asm::try(25): [-Wtruncation]
Expression must be 16-bit
warning: warn-truncation.asm(37) -> warn-truncation.asm::try(26): [-Wtruncation]
Expression must be 16-bit
warning: warn-truncation.asm(38) -> warn-truncation.asm::try(23): [-Wtruncation]
Expression must be 8-bit Expression must be 8-bit
error: warn-truncation.asm(37) -> warn-truncation.asm::try(25): [-Werror=truncation] warning: warn-truncation.asm(38) -> warn-truncation.asm::try(24): [-Wtruncation]
Expression must be 16-bit
error: warn-truncation.asm(37) -> warn-truncation.asm::try(26): [-Werror=truncation]
Expression must be 16-bit
error: warn-truncation.asm(38) -> warn-truncation.asm::try(23): [-Werror=truncation]
Expression must be 8-bit Expression must be 8-bit
error: warn-truncation.asm(38) -> warn-truncation.asm::try(24): [-Werror=truncation] warning: warn-truncation.asm(38) -> warn-truncation.asm::try(25): [-Wtruncation]
Expression must be 16-bit
warning: warn-truncation.asm(38) -> warn-truncation.asm::try(26): [-Wtruncation]
Expression must be 16-bit
warning: warn-truncation.asm(38) -> warn-truncation.asm::try(28): [-Wtruncation]
Expression must be 8-bit Expression must be 8-bit
error: warn-truncation.asm(38) -> warn-truncation.asm::try(25): [-Werror=truncation] warning: warn-truncation.asm(38) -> warn-truncation.asm::try(29): [-Wtruncation]
Expression must be 16-bit Expression must be 16-bit
error: warn-truncation.asm(38) -> warn-truncation.asm::try(26): [-Werror=truncation] warning: warn-truncation.asm(38) -> warn-truncation.asm::try(30): [-Wtruncation]
Expression must be 16-bit
error: warn-truncation.asm(38) -> warn-truncation.asm::try(28): [-Werror=truncation]
Expression must be 8-bit Expression must be 8-bit
error: warn-truncation.asm(38) -> warn-truncation.asm::try(29): [-Werror=truncation] warning: warn-truncation.asm(38) -> warn-truncation.asm::try(31): [-Wtruncation]
Expression must be 16-bit
error: warn-truncation.asm(39) -> warn-truncation.asm::try(23): [-Werror=truncation]
Expression must be 8-bit
error: warn-truncation.asm(39) -> warn-truncation.asm::try(24): [-Werror=truncation]
Expression must be 8-bit
error: warn-truncation.asm(39) -> warn-truncation.asm::try(25): [-Werror=truncation]
Expression must be 16-bit
error: warn-truncation.asm(39) -> warn-truncation.asm::try(26): [-Werror=truncation]
Expression must be 16-bit
error: warn-truncation.asm(40) -> warn-truncation.asm::try(23): [-Werror=truncation]
Expression must be 8-bit
error: warn-truncation.asm(40) -> warn-truncation.asm::try(24): [-Werror=truncation]
Expression must be 8-bit
error: warn-truncation.asm(40) -> warn-truncation.asm::try(25): [-Werror=truncation]
Expression must be 16-bit
error: warn-truncation.asm(40) -> warn-truncation.asm::try(26): [-Werror=truncation]
Expression must be 16-bit
error: warn-truncation.asm(40) -> warn-truncation.asm::try(28): [-Werror=truncation]
Expression must be 8-bit
error: warn-truncation.asm(40) -> warn-truncation.asm::try(29): [-Werror=truncation]
Expression must be 16-bit
error: warn-truncation.asm(40) -> warn-truncation.asm::try(30): [-Werror=truncation]
Expression must be 8-bit
error: warn-truncation.asm(40) -> warn-truncation.asm::try(31): [-Werror=truncation]
Expression must be 16-bit Expression must be 16-bit