Some refactoring and cleanup (#1806)

* Use clang-tidy `misc-include-cleaner` for IWYU `#include` cleanup

* Use `std::optional<size_t>` instead of `ssize_t`

* Rename some functions in linkdefs.hpp

* Fix header order

include/asm/actions.hpp

@@ -4,14 +4,16 @@
 #define RGBDS_ASM_ACTIONS_HPP
 
 #include <optional>
+#include <stddef.h>
 #include <stdint.h>
 #include <string>
 #include <string_view>
 #include <variant>
 #include <vector>
 
-#include "asm/output.hpp" // AssertionType
-#include "asm/rpn.hpp"    // RPNCommand
+#include "linkdefs.hpp" // AssertionType, RPNCommand
+
+#include "asm/rpn.hpp" // Expression
 
 struct AlignmentSpec {
 	uint8_t alignment;

include/asm/charmap.hpp

@@ -4,6 +4,7 @@
 #define RGBDS_ASM_CHARMAP_HPP
 
 #include <optional>
+#include <stddef.h>
 #include <stdint.h>
 #include <string>
 #include <string_view>

include/asm/lexer.hpp

@@ -6,6 +6,7 @@
 #include <deque>
 #include <memory>
 #include <optional>
+#include <stddef.h>
 #include <stdint.h>
 #include <string>
 #include <variant>

include/asm/main.hpp

@@ -7,8 +7,6 @@
 #include <stdio.h>
 #include <string>
 
-#include "verbosity.hpp"
-
 enum MissingInclude {
 	INC_ERROR,    // A missing included file is an error that halts assembly
 	GEN_EXIT,     // A missing included file is assumed to be generated; exit normally

include/asm/output.hpp

@@ -6,7 +6,6 @@
 #include <memory>
 #include <stdint.h>
 #include <string>
-#include <unordered_map>
 #include <vector>
 
 #include "linkdefs.hpp"

include/asm/section.hpp

@@ -6,9 +6,9 @@
 #include <deque>
 #include <memory>
 #include <optional>
+#include <stddef.h>
 #include <stdint.h>
 #include <string>
-#include <unordered_map>
 #include <vector>
 
 #include "linkdefs.hpp"

include/asm/symbol.hpp

@@ -5,9 +5,7 @@
 
 #include <memory>
 #include <stdint.h>
-#include <string.h>
 #include <string>
-#include <string_view>
 #include <time.h>
 #include <utility>
 #include <variant>

include/diagnostics.hpp

@@ -9,8 +9,8 @@
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <string.h>
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "helpers.hpp"

include/file.hpp

@@ -8,7 +8,6 @@
 #include <ios>
 #include <iostream>
 #include <streambuf>
-#include <string.h>
 #include <string>
 #include <variant>
 

include/fix/warning.hpp

@@ -3,6 +3,8 @@
 #ifndef RGBDS_FIX_WARNING_HPP
 #define RGBDS_FIX_WARNING_HPP
 
+#include <stdint.h>
+
 #include "diagnostics.hpp"
 
 enum WarningLevel {

include/gfx/main.hpp

@@ -5,13 +5,12 @@
 
 #include <array>
 #include <optional>
+#include <stddef.h>
 #include <stdint.h>
 #include <string>
-#include <utility>
 #include <vector>
 
 #include "helpers.hpp"
-#include "verbosity.hpp"
 
 #include "gfx/rgba.hpp"
 

include/gfx/pal_sorting.hpp

@@ -5,6 +5,7 @@
 
 #include <array>
 #include <optional>
+#include <stddef.h>
 #include <vector>
 
 #include "gfx/rgba.hpp"

include/gfx/png.hpp

@@ -3,8 +3,8 @@
 #ifndef RGBDS_GFX_PNG_HPP
 #define RGBDS_GFX_PNG_HPP
 
-#include <fstream>
 #include <stdint.h>
+#include <streambuf>
 #include <vector>
 
 #include "gfx/rgba.hpp"

include/link/section.hpp

@@ -3,9 +3,6 @@
 #ifndef RGBDS_LINK_SECTION_HPP
 #define RGBDS_LINK_SECTION_HPP
 
-// GUIDELINE: external code MUST NOT BE AWARE of the data structure used!
-
-#include <deque>
 #include <memory>
 #include <stdint.h>
 #include <string>
@@ -13,8 +10,6 @@
 
 #include "linkdefs.hpp"
 
-#include "link/main.hpp"
-
 struct FileStackNode;
 struct Section;
 struct Symbol;

include/linkdefs.hpp

@@ -101,18 +101,18 @@ extern struct SectionTypeInfo {
 
 // Tells whether a section has data in its object file definition,
 // depending on type.
-static inline bool sect_HasData(SectionType type) {
+static inline bool sectTypeHasData(SectionType type) {
 	assume(type != SECTTYPE_INVALID);
 	return type == SECTTYPE_ROM0 || type == SECTTYPE_ROMX;
 }
 
 // Returns a memory region's end address (last byte), e.g. 0x7FFF
-static inline uint16_t endaddr(SectionType type) {
+static inline uint16_t sectTypeEndAddr(SectionType type) {
 	return sectionTypeInfo[type].startAddr + sectionTypeInfo[type].size - 1;
 }
 
 // Returns a memory region's number of banks, or 1 for regions without banking
-static inline uint32_t nbbanks(SectionType type) {
+static inline uint32_t sectTypeBanks(SectionType type) {
 	return sectionTypeInfo[type].lastBank - sectionTypeInfo[type].firstBank + 1;
 }