Rewrite RGBFIX

- Make it work inside pipelines
- Add RGBFIX tests to the suite
- Be more flexible in accepted MBC names
- Add warnings for dangerous or nonsensical input params
- Improve man page

test/fix/.gitignore

@@ -0,0 +1 @@
+/padding*_*

test/fix/README.md

@@ -0,0 +1,16 @@
+# RGBFIX tests
+
+These tests check that RGBFIX behaves properly.
+
+## Structure of a test
+
+- `test.bin`: The file passed as input to RGBFIX.
+- `test.flags`: The command-line flags passed to RGBFIX's invocation.
+  Actually, only the first line is considered; the rest of the file may contain comments about the test.
+- `test.gb`: The expected output.
+  May not exist, generally when the test expects an error, in which case the comparison is skipped.
+- `test.err`: The expected error output.
+
+## Special tests
+
+- `noexist.err` is the expected error output when RGBFIX is given a non-existent input file.

test/fix/bad-fix-char.bin

@@ -0,0 +1,3 @@
+<EFBFBD><EFBFBD>
<1B>!H0<48>;<<>N˗<4E><CB97><EFBFBD>=<3D><><EFBFBD><EFBFBD>^{KC}b<12>Q<EFBFBD>&<14>3<EFBFBD> <20>/]
<01><08><><EFBFBD>d<EFBFBD><64>Z=<3D><><EFBFBD>b<EFBFBD>a<EFBFBD>i:<3A>eS<65>><18><>U@<40>Ay<ae<61><65><EFBFBD>$vf<76>孈┚<13><>g<>	VC<56><43>~><3E><><EFBFBD><EFBFBD><11><>	<09>s_Cӛ<0C><>&nWFoK<04><18><>X`'<27><><EFBFBD><EFBFBD><EFBFBD><EFBFBD>bl<17>{<7B><><EFBFBD><EFBFBD>
+<EFBFBD><0F><><EFBFBD><EFBFBD>8<EFBFBD><38><EFBFBD><$:V<0F>"㳙ځh<DA81><68>D<EFBFBD><44>ж<15><>Qc<51><63><EFBFBD><1E>㸺Z<E3B8BA><5A>T<><54><EFBFBD><EFBFBD><EFBFBD><EFBFBD><EFBFBD>Vۼ<56>tŒ<0F><>4<EFBFBD>B<><1E>dT<><54>	<09>I<1A><>
+<EFBFBD>(/׻<><D7BB>{h<>:<3A><>Qm<51>$*|

test/fix/bad-fix-char.err

@@ -0,0 +1,3 @@
+warning: Ignoring 'm' in fix spec
+warning: Ignoring 'a' in fix spec
+warning: Ignoring 'o' in fix spec

test/fix/bad-fix-char.flags

@@ -0,0 +1 @@
+-f lmao

test/fix/color.bin

@@ -0,0 +1,2 @@
+<EFBFBD><EFBFBD>+2l}~<7E><>Ѧ<><D1A6>}<7D><>1x<31><78><EFBFBD><EFBFBD>&)Y<18>q*<2A><><EFBFBD><EFBFBD>ɒ<EFBFBD><C992>^ H<>p@v6}<7D><>[<5B><>&<26><><EFBFBD>h<EFBFBD><68><EFBFBD>Bn~<7E>T<EFBFBD>0<><30>uf<75>\<5C>8<EFBFBD><38><EFBFBD><EFBFBD><EFBFBD><EFBFBD><EFBFBD><EFBFBD><13>Ñ<EFBFBD>W<EFBFBD><57><EFBFBD><EFBFBD>		5^Bq<<3C>K<EFBFBD>"S%<25><>U!<0F><>r,7<10><16>g<16>4Ȩ<><C8A8><10><><EFBFBD><EFBFBD><EFBFBD><1C>hL<68><4C>؝<EFBFBD>)<29><1A><><EFBFBD>6U@<19>׍`ݑT<DD91>T<EFBFBD><0B><><EFBFBD>
Dɦ<44>8z<38>5<EFBFBD><35>~A<>鱽ܜ<E9B1BD>|
+<EFBFBD>><3E>]<5D>/<2F>K<EFBFBD><4B><EFBFBD>d~<7E><>"gF*AU<>"W<>7]}<7D><>/<2F>}<<3C><>s[lx<07>ܔ}Ы[<5B><><EFBFBD>8<EFBFBD><1E><><EFBFBD><EFBFBD><EFBFBD>

test/fix/color.flags

@@ -0,0 +1 @@
+-C

test/fix/color.gb

@@ -0,0 +1,2 @@
+<EFBFBD><EFBFBD>+2l}~<7E><>Ѧ<><D1A6>}<7D><>1x<31><78><EFBFBD><EFBFBD>&)Y<18>q*<2A><><EFBFBD><EFBFBD>ɒ<EFBFBD><C992>^ H<>p@v6}<7D><>[<5B><>&<26><><EFBFBD>h<EFBFBD><68><EFBFBD>Bn~<7E>T<EFBFBD>0<><30>uf<75>\<5C>8<EFBFBD><38><EFBFBD><EFBFBD><EFBFBD><EFBFBD><EFBFBD><EFBFBD><13>Ñ<EFBFBD>W<EFBFBD><57><EFBFBD><EFBFBD>		5^Bq<<3C>K<EFBFBD>"S%<25><>U!<0F><>r,7<10><16>g<16>4Ȩ<><C8A8><10><><EFBFBD><EFBFBD><EFBFBD><1C>hL<68><4C>؝<EFBFBD>)<29><1A><><EFBFBD>6U@<19>׍`ݑT<DD91>T<EFBFBD><0B><><EFBFBD>
Dɦ<44>8z<38>5<EFBFBD><35>~A<>鱽ܜ<E9B1BD>|
+<EFBFBD>><3E>]<5D>/<2F>K<EFBFBD><4B><EFBFBD>d~<7E><>"gF*AU<>"W<>7]}<7D><>/<2F>}<<3C><>s[lx<07>ܔ}Ы[<5B><><EFBFBD>8<EFBFBD><1E><><EFBFBD><EFBFBD><EFBFBD>

test/fix/compatible.flags

@@ -0,0 +1 @@
+-c

test/fix/empty.err

@@ -0,0 +1,2 @@
+FATAL: "<filename>" too short, expected at least 336 ($150) bytes, got only 0
+Fixing "<filename>" failed with 1 error

test/fix/fix-override.err

@@ -0,0 +1 @@
+warning: 'l' overriding 'L' in fix spec

test/fix/fix-override.flags

@@ -0,0 +1 @@
+-f Ll

test/fix/gameid-trunc.err

@@ -0,0 +1 @@
+warning: Truncating game ID "FOUR!" to 4 chars

test/fix/gameid-trunc.flags

@@ -0,0 +1 @@
+-i 'FOUR!'

test/fix/gameid.flags

@@ -0,0 +1 @@
+-i RGBD

test/fix/global-large.flags

@@ -0,0 +1 @@
+-fg

test/fix/global-larger.flags

@@ -0,0 +1 @@
+-fg

test/fix/global-trash.flags

@@ -0,0 +1 @@
+-f G

test/fix/global.flags

@@ -0,0 +1 @@
+-f g

test/fix/header-edit.flags

@@ -0,0 +1,2 @@
+-Cf h
+Checks that the header checksum properly accounts for header modifications

test/fix/header-trash.flags

@@ -0,0 +1 @@
+-f H

test/fix/header.flags

@@ -0,0 +1 @@
+-f h

test/fix/jp.flags

@@ -0,0 +1 @@
+-j

test/fix/logo-trash.flags

@@ -0,0 +1 @@
+-f L

test/fix/logo.flags

@@ -0,0 +1 @@
+-f l

test/fix/mbc.flags

@@ -0,0 +1 @@
+-m 177

test/fix/mbcless-ram.err

@@ -0,0 +1 @@
+warning: MBC "ROM" has no RAM, but RAM size was set to 2

test/fix/mbcless-ram.flags

@@ -0,0 +1 @@
+-m ROM -r 2

test/fix/new-lic-trunc.bin

@@ -0,0 +1,3 @@
+<EFBFBD><13><>i& <20><><EFBFBD>y<EFBFBD><79>S<EFBFBD><53><EFBFBD><EFBFBD>aJ<04><><EFBFBD>'ZD<5A>y<EFBFBD><79><EFBFBD>1n<31>
+<EFBFBD><13><>9<EFBFBD>Q<EFBFBD>H<EFBFBD>p<EFBFBD><18>yF<79><15><><EFBFBD><EFBFBD><EFBFBD>ߘ<EFBFBD><DF98>8^<5E><>]<5D>b<EFBFBD><62>	F<19><>mœ<6D>
+<EFBFBD><14>ьM<D18C><4D>F<EFBFBD><46>W<EFBFBD><57>w<16>k<EFBFBD><6B><EFBFBD> O`<60><><EFBFBD><18>U<EFBFBD>0<EFBFBD><30>r<EFBFBD><72><EFBFBD><EFBFBD>Ιܥ<CE99><DCA5>7"<1D><>"f<><66><EFBFBD><EFBFBD>fw<08> X<><58>:<3A>޸<EFBFBD><DEB8>Xp<58>V<EFBFBD>Ī\-<2D>`x<><78><EFBFBD>*N<><4E>y<EFBFBD>a4<0E>J<EFBFBD><4A><EFBFBD><EFBFBD><EFBFBD><EFBFBD><EFBFBD>܊<EFBFBD>p<EFBFBD><70><EFBFBD>.7<EFBFBD>c+<2B>Q<EFBFBD><51>Վ<EFBFBD>B<EFBFBD>He<48>z<EFBFBD><7A><EFBFBD>1<EFBFBD>O<n_&KHh<48><05><>v<13><><EFBFBD>x<EFBFBD><78><07>Y<EFBFBD><59><1D>A<7F><41><EFBFBD><EFBFBD>;C<>o<EFBFBD>l<EFBFBD><6C>:<3A><0C><><EFBFBD><EFBFBD>̒<0F>ܩ!<21>f<><16><16><>P<EFBFBD>`@<12>:<3A>z<EFBFBD>v<EFBFBD><76><EFBFBD>d<EFBFBD><64>Z<EFBFBD>"<22>a*m*.:?<3F><><EFBFBD><EFBFBD><EFBFBD>Y˛c3<63>Ƞ>#`<60><>\_<>w<EFBFBD><77><EFBFBD>

test/fix/new-lic-trunc.err

@@ -0,0 +1 @@
+warning: Truncating new licensee "HOMEBREW" to 2 chars

test/fix/new-lic-trunc.flags

@@ -0,0 +1 @@
+-k HOMEBREW

test/fix/new-lic-trunc.gb

@@ -0,0 +1,3 @@
+<EFBFBD><13><>i& <20><><EFBFBD>y<EFBFBD><79>S<EFBFBD><53><EFBFBD><EFBFBD>aJ<04><><EFBFBD>'ZD<5A>y<EFBFBD><79><EFBFBD>1n<31>
+<EFBFBD><13><>9<EFBFBD>Q<EFBFBD>H<EFBFBD>p<EFBFBD><18>yF<79><15><><EFBFBD><EFBFBD><EFBFBD>ߘ<EFBFBD><DF98>8^<5E><>]<5D>b<EFBFBD><62>	F<19><>mœ<6D>
+<EFBFBD><14>ьM<D18C><4D>F<EFBFBD><46>W<EFBFBD><57>w<16>k<EFBFBD><6B><EFBFBD> O`<60><><EFBFBD><18>U<EFBFBD>0<EFBFBD><30>r<EFBFBD><72><EFBFBD><EFBFBD>Ιܥ<CE99><DCA5>7"<1D><>"f<><66><EFBFBD><EFBFBD>fw<08> X<><58>:<3A>޸<EFBFBD><DEB8>Xp<58>V<EFBFBD>Ī\-<2D>`x<><78><EFBFBD>*N<><4E>y<EFBFBD>a4<0E>J<EFBFBD><4A><EFBFBD><EFBFBD><EFBFBD><EFBFBD><EFBFBD>܊<EFBFBD>p<EFBFBD><70><EFBFBD>.7<EFBFBD>c+<2B>Q<EFBFBD><51>Վ<EFBFBD>B<EFBFBD>He<48>z<EFBFBD><7A><EFBFBD>1<EFBFBD>O<n_&KHh<48><05><>v<13><><EFBFBD>x<EFBFBD><78><07>Y<EFBFBD><59><1D>A<7F><41><EFBFBD><EFBFBD>;C<>o<EFBFBD>l<EFBFBD><6C>:<3A><0C><><EFBFBD><EFBFBD>̒<0F>ܩ!<21>f<><16><16><>P<EFBFBD>`@<12>:<3A>z<EFBFBD>v<EFBFBD><76><EFBFBD>d<EFBFBD><64>Z<EFBFBD>"<22>a*m*.:?<3F><><EFBFBD><EFBFBD><EFBFBD>YHOc3<63>Ƞ>#`<60><>\_<>w<EFBFBD><77><EFBFBD>

test/fix/new-lic.bin

@@ -0,0 +1,3 @@
+<EFBFBD><13><>i& <20><><EFBFBD>y<EFBFBD><79>S<EFBFBD><53><EFBFBD><EFBFBD>aJ<04><><EFBFBD>'ZD<5A>y<EFBFBD><79><EFBFBD>1n<31>
+<EFBFBD><13><>9<EFBFBD>Q<EFBFBD>H<EFBFBD>p<EFBFBD><18>yF<79><15><><EFBFBD><EFBFBD><EFBFBD>ߘ<EFBFBD><DF98>8^<5E><>]<5D>b<EFBFBD><62>	F<19><>mœ<6D>
+<EFBFBD><14>ьM<D18C><4D>F<EFBFBD><46>W<EFBFBD><57>w<16>k<EFBFBD><6B><EFBFBD> O`<60><><EFBFBD><18>U<EFBFBD>0<EFBFBD><30>r<EFBFBD><72><EFBFBD><EFBFBD>Ιܥ<CE99><DCA5>7"<1D><>"f<><66><EFBFBD><EFBFBD>fw<08> X<><58>:<3A>޸<EFBFBD><DEB8>Xp<58>V<EFBFBD>Ī\-<2D>`x<><78><EFBFBD>*N<><4E>y<EFBFBD>a4<0E>J<EFBFBD><4A><EFBFBD><EFBFBD><EFBFBD><EFBFBD><EFBFBD>܊<EFBFBD>p<EFBFBD><70><EFBFBD>.7<EFBFBD>c+<2B>Q<EFBFBD><51>Վ<EFBFBD>B<EFBFBD>He<48>z<EFBFBD><7A><EFBFBD>1<EFBFBD>O<n_&KHh<48><05><>v<13><><EFBFBD>x<EFBFBD><78><07>Y<EFBFBD><59><1D>A<7F><41><EFBFBD><EFBFBD>;C<>o<EFBFBD>l<EFBFBD><6C>:<3A><0C><><EFBFBD><EFBFBD>̒<0F>ܩ!<21>f<><16><16><>P<EFBFBD>`@<12>:<3A>z<EFBFBD>v<EFBFBD><76><EFBFBD>d<EFBFBD><64>Z<EFBFBD>"<22>a*m*.:?<3F><><EFBFBD><EFBFBD><EFBFBD>Y˛c3<63>Ƞ>#`<60><>\_<>w<EFBFBD><77><EFBFBD>

test/fix/new-lic.flags

@@ -0,0 +1 @@
+-k HB

test/fix/new-lic.gb

@@ -0,0 +1,3 @@
+<EFBFBD><13><>i& <20><><EFBFBD>y<EFBFBD><79>S<EFBFBD><53><EFBFBD><EFBFBD>aJ<04><><EFBFBD>'ZD<5A>y<EFBFBD><79><EFBFBD>1n<31>
+<EFBFBD><13><>9<EFBFBD>Q<EFBFBD>H<EFBFBD>p<EFBFBD><18>yF<79><15><><EFBFBD><EFBFBD><EFBFBD>ߘ<EFBFBD><DF98>8^<5E><>]<5D>b<EFBFBD><62>	F<19><>mœ<6D>
+<EFBFBD><14>ьM<D18C><4D>F<EFBFBD><46>W<EFBFBD><57>w<16>k<EFBFBD><6B><EFBFBD> O`<60><><EFBFBD><18>U<EFBFBD>0<EFBFBD><30>r<EFBFBD><72><EFBFBD><EFBFBD>Ιܥ<CE99><DCA5>7"<1D><>"f<><66><EFBFBD><EFBFBD>fw<08> X<><58>:<3A>޸<EFBFBD><DEB8>Xp<58>V<EFBFBD>Ī\-<2D>`x<><78><EFBFBD>*N<><4E>y<EFBFBD>a4<0E>J<EFBFBD><4A><EFBFBD><EFBFBD><EFBFBD><EFBFBD><EFBFBD>܊<EFBFBD>p<EFBFBD><70><EFBFBD>.7<EFBFBD>c+<2B>Q<EFBFBD><51>Վ<EFBFBD>B<EFBFBD>He<48>z<EFBFBD><7A><EFBFBD>1<EFBFBD>O<n_&KHh<48><05><>v<13><><EFBFBD>x<EFBFBD><78><07>Y<EFBFBD><59><1D>A<7F><41><EFBFBD><EFBFBD>;C<>o<EFBFBD>l<EFBFBD><6C>:<3A><0C><><EFBFBD><EFBFBD>̒<0F>ܩ!<21>f<><16><16><>P<EFBFBD>`@<12>:<3A>z<EFBFBD>v<EFBFBD><76><EFBFBD>d<EFBFBD><64>Z<EFBFBD>"<22>a*m*.:?<3F><><EFBFBD><EFBFBD><EFBFBD>YHBc3<63>Ƞ>#`<60><>\_<>w<EFBFBD><77><EFBFBD>

test/fix/noexist.err

@@ -0,0 +1,2 @@
+FATAL: Failed to open "noexist" for reading+writing: No such file or directory
+Fixing "noexist" failed with 1 error

test/fix/old-lic-hex.flags

@@ -0,0 +1 @@
+-l 0x2a

test/fix/old-lic.bin

@@ -0,0 +1,2 @@
+<EFBFBD>EZ/:<3A><><EFBFBD><7F><7F>Ѐ<EFBFBD><02>J/<2F><><EFBFBD><EFBFBD>_<<3C>&<26>A<EFBFBD><41><EFBFBD><EFBFBD><EFBFBD>XgAP 
+`<60>1@Wh<><68>||ø<>e뻬e^"7(*YV<59><56>T<EFBFBD><54><EFBFBD>OY!<21><03><04>̔]<5D><><EFBFBD>=<3D>
<01><>y<EFBFBD>V~x<>a<>]<5D>;<3B><><EFBFBD>¡<EFBFBD>zUm<0C><>z:d@֪<>b<EFBFBD> 'vʆq<02>W<EFBFBD><14>_<EFBFBD><5F><17><><EFBFBD>2)G<05>v(k<><6B><EFBFBD>g,<2C>p*@<40><>!<21>Dõ<44>0k<14><>
<01><><EFBFBD>e<EFBFBD>%ǚod<6F><64><EFBFBD>$r<11><><EFBFBD><<3C>:<3A><>cgi<67>"aF'=f<><66><1F><>EcVcL.03"w),<2C>	HQi<51>D<EFBFBD>f<EFBFBD>3<EFBFBD>s(-$?a0<61>@<40><>.O<>B{y<>z<EFBFBD>ʫ<1A>	h<>/\<0B>S<>]<5D>o<EFBFBD><6F>m'2D#/
gr<67>W3<>Χ<><CEA7>&U<><55><EFBFBD>EgMh<4D>-A<>6<><36><EFBFBD><EFBFBD><EFBFBD>4M|1<>q0O<30><4F>*$<24>O<EFBFBD>/n<><6E><EFBFBD>g<EFBFBD><67>2R<32><52>Q<EFBFBD>X<>_<07><><EFBFBD>[숔<>p<EFBFBD><70>\<5C>)ƧTS<54>T<EFBFBD>aP*'[<0F>x<EFBFBD><78>>߅<>Ub[Ԧ<>9s<39><73>I<EFBFBD><49>P

test/fix/old-lic.flags

@@ -0,0 +1 @@
+-l 42

test/fix/old-lic.gb

@@ -0,0 +1,2 @@
+<EFBFBD>EZ/:<3A><><EFBFBD><7F><7F>Ѐ<EFBFBD><02>J/<2F><><EFBFBD><EFBFBD>_<<3C>&<26>A<EFBFBD><41><EFBFBD><EFBFBD><EFBFBD>XgAP 
+`<60>1@Wh<><68>||ø<>e뻬e^"7(*YV<59><56>T<EFBFBD><54><EFBFBD>OY!<21><03><04>̔]<5D><><EFBFBD>=<3D>
<01><>y<EFBFBD>V~x<>a<>]<5D>;<3B><><EFBFBD>¡<EFBFBD>zUm<0C><>z:d@֪<>b<EFBFBD> 'vʆq<02>W<EFBFBD><14>_<EFBFBD><5F><17><><EFBFBD>2)G<05>v(k<><6B><EFBFBD>g,<2C>p*@<40><>!<21>Dõ<44>0k<14><>
<01><><EFBFBD>e<EFBFBD>%ǚod<6F><64><EFBFBD>$r<11><><EFBFBD><<3C>:<3A><>cgi<67>"aF'=f<><66><1F><>EcVcL.03"w),<2C>	HQi<51>D<EFBFBD>f<EFBFBD>3<EFBFBD>s(-$?a0<61>@<40><>.O<>B{y<>z<EFBFBD>ʫ<1A>	h<>/\<0B>S<>]<5D>o<EFBFBD><6F>m'2D#/
gr<67>W3<>Χ<><CEA7>&U<><55><EFBFBD>EgMh<4D>-A<>*6<><36><EFBFBD><EFBFBD><EFBFBD>4M|1<>q0O<30><4F>*$<24>O<EFBFBD>/n<><6E><EFBFBD>g<EFBFBD><67>2R<32><52>Q<EFBFBD>X<>_<07><><EFBFBD>[숔<>p<EFBFBD><70>\<5C>)ƧTS<54>T<EFBFBD>aP*'[<0F>x<EFBFBD><78>>߅<>Ub[Ԧ<>9s<39><73>I<EFBFBD><49>P

test/fix/padding-bigperfect.flags

@@ -0,0 +1 @@
+-p0xff