Rewrite RGBFIX

- Make it work inside pipelines
- Add RGBFIX tests to the suite
- Be more flexible in accepted MBC names
- Add warnings for dangerous or nonsensical input params
- Improve man page

test/fix/.gitignore

@@ -0,0 +1 @@
+/padding*_*

test/fix/README.md

@@ -0,0 +1,16 @@
+# RGBFIX tests
+
+These tests check that RGBFIX behaves properly.
+
+## Structure of a test
+
+- `test.bin`: The file passed as input to RGBFIX.
+- `test.flags`: The command-line flags passed to RGBFIX's invocation.
+  Actually, only the first line is considered; the rest of the file may contain comments about the test.
+- `test.gb`: The expected output.
+  May not exist, generally when the test expects an error, in which case the comparison is skipped.
+- `test.err`: The expected error output.
+
+## Special tests
+
+- `noexist.err` is the expected error output when RGBFIX is given a non-existent input file.

test/fix/bad-fix-char.bin

@@ -0,0 +1,3 @@
+‡Ý
à!H0‡;<ýNË—ñãí=ÌÊÏç^{KC}b“Q¤&<14>3ð ñ/]
¿—¹”d<E2809D>ÙZ=ÃÀ¢bÄaËi:öeSŸ>ñ›U@¼Ay<aeš‰¹$vfÅå­ˆ┚ý¬gŒ	VC†ò~>•‘¨þ©†	³s_CÓ›Úç&nWFoKÚšíX`'ñêÁ§ë·blƒ{‡›Œ¿
+‹¯­çÎ8îù†<$:VÍ"ã³™Ú<E284A2>h™ÑD©¤Ð¶ñ­QcµïØÐ㸺Zû§T†ž©ø½¨ºVÛ¼ÝtÅ’ªÏ4ªBèÐdT“«	ÄI<1A>‡
+Ô(/×»ç¿{hÝ:ƒ<>QmÓ$*|

test/fix/bad-fix-char.err

@@ -0,0 +1,3 @@
+warning: Ignoring 'm' in fix spec
+warning: Ignoring 'a' in fix spec
+warning: Ignoring 'o' in fix spec

test/fix/bad-fix-char.flags

@@ -0,0 +1 @@
+-f lmao

test/fix/color.bin

@@ -0,0 +1,2 @@
+╧ы+2l}~Ч╨я╕├Ж}╧Я1xЙаШЩ&)Y├q*▀ОТ═и▓┌г^ H─p@v6}Юг[┬╙&оЧ┘hё▒лBn~пT┘0Ьнuf┬\╗8╫≥÷жуЗ■ВЖц▒ЬW╫╬Ф╥		5^Bq<░K╫"S%╤ВU!▓╦r,7┌Нg┘4х╗┴▌╔╖╜А░ЗhL╟жь²У)√÷┘У6U@Ёв█`щ▒TзT├М╕·
Dи╕▓8zс5╡·~AбИ╠╫э°Щ|
+╕>Т]Е/╧K╠▄Ыd~ис"gF*AU╩"W▌7]}≈ы/Ц}<▀─s[lx■э■}п╚[МлО8Ё█≥╛А═

test/fix/color.flags

@@ -0,0 +1 @@
+-C

test/fix/color.gb

@@ -0,0 +1,2 @@
+╧ы+2l}~Ч╨я╕├Ж}╧Я1xЙаШЩ&)Y├q*▀ОТ═и▓┌г^ H─p@v6}Юг[┬╙&оЧ┘hё▒лBn~пT┘0Ьнuf┬\╗8╫≥÷жуЗ■ВЖц▒ЬW╫╬Ф╥		5^Bq<░K╫"S%╤ВU!▓╦r,7┌Нg┘4х╗┴▌╔╖╜А░ЗhL╟жь²У)√÷┘У6U@Ёв█`щ▒TзT├М╕·
Dи╕▓8zс5╡·~AбИ╠╫э°Щ|
+╕>Т]Е/╧K╠▄Ыd~ис"gF*AU╩"W▌7]}≈ы/Ц}<▀─s[lx■э■}п╚[МлО8Ё█≥╛А═

test/fix/compatible.flags

@@ -0,0 +1 @@
+-c

test/fix/empty.err

@@ -0,0 +1,2 @@
+FATAL: "<filename>" too short, expected at least 336 ($150) bytes, got only 0
+Fixing "<filename>" failed with 1 error

test/fix/fix-override.err

@@ -0,0 +1 @@
+warning: 'l' overriding 'L' in fix spec

test/fix/fix-override.flags

@@ -0,0 +1 @@
+-f Ll

test/fix/gameid-trunc.err

@@ -0,0 +1 @@
+warning: Truncating game ID "FOUR!" to 4 chars

test/fix/gameid-trunc.flags

@@ -0,0 +1 @@
+-i 'FOUR!'

test/fix/gameid.flags

@@ -0,0 +1 @@
+-i RGBD

test/fix/global-large.flags

@@ -0,0 +1 @@
+-fg

test/fix/global-larger.flags

@@ -0,0 +1 @@
+-fg

test/fix/global-trash.flags

@@ -0,0 +1 @@
+-f G

test/fix/global.flags

@@ -0,0 +1 @@
+-f g

test/fix/header-edit.flags

@@ -0,0 +1,2 @@
+-Cf h
+Checks that the header checksum properly accounts for header modifications

test/fix/header-trash.flags

@@ -0,0 +1 @@
+-f H

test/fix/header.flags

@@ -0,0 +1 @@
+-f h

test/fix/jp.flags

@@ -0,0 +1 @@
+-j

test/fix/logo-trash.flags

@@ -0,0 +1 @@
+-f L

test/fix/logo.flags

@@ -0,0 +1 @@
+-f l

test/fix/mbc.flags

@@ -0,0 +1 @@
+-m 177

test/fix/mbcless-ram.err

@@ -0,0 +1 @@
+warning: MBC "ROM" has no RAM, but RAM size was set to 2

test/fix/mbcless-ram.flags

@@ -0,0 +1 @@
+-m ROM -r 2

test/fix/new-lic-trunc.bin

@@ -0,0 +1,3 @@
+€ÁÓi& š˙ĹyŕĺSĐěäŇaJ¨ň‘'ZDÉyşč§1nź
+¬íŮ9µQńHĽpçąyF›ź”»ŃŐß<C590>ĐÖ8^ŞŠ]Ŕbł˘	F‰§mĹ“š
+ױьM–‡FíîWóŐwţk÷°± O`ŘÚíčUě0ńär©íşĆΙܥâ±7"®”"fęŕ<C499>ďfw– Xë<58>:Đ޸ň˝XpéVËÄŞ\-¶`xť˛ř*NđŐy†a4ÄJĹç´ÄëˇăÜŠĽp—„ľ.7öc+ÝQ<C39D>řŐŽ·B÷He<48>zĽ–§1ĘO<n_&KHhŁ´‹v‘Žűx榢Y˘—ČAŮÇćĚ;Cęożlý :ü®Ą®żĚ’ýÜ©!–fřěľ<>PĄ`@¸:‡z‰v‰˝ädéŁZÓ"±a*m*.:?¤ŁďżĎYË›c3”Č >#`çí\_Úw<C39A>™Ď

test/fix/new-lic-trunc.err

@@ -0,0 +1 @@
+warning: Truncating new licensee "HOMEBREW" to 2 chars

test/fix/new-lic-trunc.flags

@@ -0,0 +1 @@
+-k HOMEBREW

test/fix/new-lic-trunc.gb

@@ -0,0 +1,3 @@
+€ÁÓi& šÿÅyàåSÐìäÒaJ¨ò‘'ZDÉyºè§1nŸ
+¬íÙ9µQñH¼pç¹yF›Ÿ”»ÑÕߘÐÖ8^ªŠ]Àb³¢	F‰§mÅ“š
+ױьM–‡FíîWóÕwþk÷°± O`ØÚíèUì0ñär©íºÆΙܥâ±7"®”"fêàˆïfw– Xë<58>:ÐÞ¸ò½XpéVËĪ\-¶`x<>²ø*NðÕy†a4ÄJÅç´Äë¡ãÜŠ¼p—„¾.7öc+ÝQ<C39D>øÕŽ·B÷He<48>z¼–§1ÊO<n_&KHh£´‹v‘Žûx榢Y¢—ÈAÙÇæÌ;Cêo¿lý :ü®¥®¿Ì’ýÜ©!–føì¾<>P¥`@¸:‡z‰v‰½ädé£ZÓ"±a*m*.:?¤£ï¿ÏYHOc3”È >#`çí\_Úw<C39A>™Ï

test/fix/new-lic.bin

@@ -0,0 +1,3 @@
+€ÁÓi& š˙ĹyŕĺSĐěäŇaJ¨ň‘'ZDÉyşč§1nź
+¬íŮ9µQńHĽpçąyF›ź”»ŃŐß<C590>ĐÖ8^ŞŠ]Ŕbł˘	F‰§mĹ“š
+ױьM–‡FíîWóŐwţk÷°± O`ŘÚíčUě0ńär©íşĆΙܥâ±7"®”"fęŕ<C499>ďfw– Xë<58>:Đ޸ň˝XpéVËÄŞ\-¶`xť˛ř*NđŐy†a4ÄJĹç´ÄëˇăÜŠĽp—„ľ.7öc+ÝQ<C39D>řŐŽ·B÷He<48>zĽ–§1ĘO<n_&KHhŁ´‹v‘Žűx榢Y˘—ČAŮÇćĚ;Cęożlý :ü®Ą®żĚ’ýÜ©!–fřěľ<>PĄ`@¸:‡z‰v‰˝ädéŁZÓ"±a*m*.:?¤ŁďżĎYË›c3”Č >#`çí\_Úw<C39A>™Ď

test/fix/new-lic.flags

@@ -0,0 +1 @@
+-k HB

test/fix/new-lic.gb

@@ -0,0 +1,3 @@
+€ÁÓi& š˙ĹyŕĺSĐěäŇaJ¨ň‘'ZDÉyşč§1nź
+¬íŮ9µQńHĽpçąyF›ź”»ŃŐß<C590>ĐÖ8^ŞŠ]Ŕbł˘	F‰§mĹ“š
+ױьM–‡FíîWóŐwţk÷°± O`ŘÚíčUě0ńär©íşĆΙܥâ±7"®”"fęŕ<C499>ďfw– Xë<58>:Đ޸ň˝XpéVËÄŞ\-¶`xť˛ř*NđŐy†a4ÄJĹç´ÄëˇăÜŠĽp—„ľ.7öc+ÝQ<C39D>řŐŽ·B÷He<48>zĽ–§1ĘO<n_&KHhŁ´‹v‘Žűx榢Y˘—ČAŮÇćĚ;Cęożlý :ü®Ą®żĚ’ýÜ©!–fřěľ<>PĄ`@¸:‡z‰v‰˝ädéŁZÓ"±a*m*.:?¤ŁďżĎYHBc3”Č >#`çí\_Úw<C39A>™Ď

test/fix/noexist.err

@@ -0,0 +1,2 @@
+FATAL: Failed to open "noexist" for reading+writing: No such file or directory
+Fixing "noexist" failed with 1 error

test/fix/old-lic-hex.flags

@@ -0,0 +1 @@
+-l 0x2a

test/fix/old-lic.bin

@@ -0,0 +1,2 @@
+”EZ/:ÂÔΠøЀšÜJ/ŒÝõÊ_<ð&ÑA­¢Ž˜ÃXgAP 
+`°1@Wh<>õ||ø»e뻬e^"7(*YV<59>ÍTõœ‘OY!Þâ Ì”]‚ˆ’=Î
ðÈy–V~xæaÛ]á;Ÿúý¡ÀzUmòüz:d@ÖªØb¸ 'vʆqËWŒÚ_ÂæºÓì2)G<05>v(k¨ª”g,<2C>p*@ùÚ!¶Dõ„0kãÿ
§á<C2A7>eË%ÇšodÛñÎ$r‰ÚÊ<è:”æcgiŒ"aF'=f䳚ºEcVcL.03"w),æ	HQi‚DŸfÝ3<C39D>s(-$?a0ó@†¦.O¡B{yÍz‰Ê«½	hØ/\šSŠ]óoúåm'2D#/
grÕW3¸Χ<C38E>°&UÓÌ÷EgMhÚ-A¾6ƒ…²ÿ…4M|1âq0Oì­*$²Où/n²ú•gžš2R»æQˆXú_½¬“[숔ÔpÒÚ\°)ƧTS±T”aP*'[ïx÷Ò>ß…¤Ub[Ô¦ã9sÎçI‰ÊP

test/fix/old-lic.flags

@@ -0,0 +1 @@
+-l 42

test/fix/old-lic.gb

@@ -0,0 +1,2 @@
+”EZ/:ÂÔΠøЀšÜJ/ŒÝõÊ_<ð&ÑA­¢Ž˜ÃXgAP 
+`°1@Wh<>õ||ø»e뻬e^"7(*YV<59>ÍTõœ‘OY!Þâ Ì”]‚ˆ’=Î
ðÈy–V~xæaÛ]á;Ÿúý¡ÀzUmòüz:d@ÖªØb¸ 'vʆqËWŒÚ_ÂæºÓì2)G<05>v(k¨ª”g,<2C>p*@ùÚ!¶Dõ„0kãÿ
§á<C2A7>eË%ÇšodÛñÎ$r‰ÚÊ<è:”æcgiŒ"aF'=f䳚ºEcVcL.03"w),æ	HQi‚DŸfÝ3<C39D>s(-$?a0ó@†¦.O¡B{yÍz‰Ê«½	hØ/\šSŠ]óoúåm'2D#/
grÕW3¸Χ<C38E>°&UÓÌ÷EgMhÚ-A¾*6ƒ…²ÿ…4M|1âq0Oì­*$²Où/n²ú•gžš2R»æQˆXú_½¬“[숔ÔpÒÚ\°)ƧTS±T”aP*'[ïx÷Ò>ß…¤Ub[Ô¦ã9sÎçI‰ÊP

test/fix/padding-bigperfect.flags

@@ -0,0 +1 @@
+-p0xff