gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 10:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't consider difference of invalid labels constant

Browse Source 
If a label is defined outside of a section, avoid trying to obtain its
value.
This commit is contained in:
Jakub Kądziołka
2020-10-12 13:28:00 +02:00
parent 4419f0d54f
commit 4c5d5c7085
4 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/asm/rpn.c
View File

@@ -307,7 +307,9 @@ bool rpn_IsDiffConstant(struct Expression const *src, struct Symbol const *sym)
if (!sym1 || !sym || sym1->type != SYM_LABEL || sym->type != SYM_LABEL) if (!sym1 || !sym || sym1->type != SYM_LABEL || sym->type != SYM_LABEL)
return false; return false;
return sym_GetSection(sym1) == sym_GetSection(sym); struct Section const *section1 = sym_GetSection(sym1);
struct Section const *section2 = sym_GetSection(sym);
return section1 && (section1 == section2);
} }
static bool isDiffConstant(struct Expression const *src1, static bool isDiffConstant(struct Expression const *src1,

3
test/asm/use-label-outside-section.asm Normal file
View File

@@ -0,0 +1,3 @@
lab:
PRINTV lab-lab
PRINTT "\n"

5
test/asm/use-label-outside-section.err Normal file
View File

@@ -0,0 +1,5 @@
ERROR: use-label-outside-section.asm(1):
Label "lab" created outside of a SECTION
ERROR: use-label-outside-section.asm(2):
Expected constant expression: 'lab' is not constant at assembly time
error: Assembly aborted (2 errors)!

1
test/asm/use-label-outside-section.out Normal file
View File

@@ -0,0 +1 @@
$0