gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-21 10:42:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix possible null pointer dereference

Browse Source 
It's possible that if the FILE passed to yy_create_buffer is at the
end-of file, there may be a null pointer dereference.

This should hopefully fix that.

Found with clang-tools' scan-build:

src/asm/lexer.c:281:25: warning: Array access (via field 'pBuffer')
 results in a null pointer dereference
        pBuffer->pBuffer[size] = 0;
                 ~~~~~~~       ^
1 warning generated.

Signed-off-by: JL2210 <larrowe.semaj11@gmail.com>
This commit is contained in:
JL2210
2020-04-08 17:25:26 -04:00
parent 40f8e33e6c
commit 5863cd10b8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/asm/lexer.c
View File

@@ -254,7 +254,7 @@ YY_BUFFER_STATE yy_create_buffer(FILE *f)
else if (capacity == 0) else if (capacity == 0)
capacity = 1; capacity = 1;
while (!feof(f)) { do {
if (buf == NULL || size >= capacity) { if (buf == NULL || size >= capacity) {
if (buf) if (buf)
capacity *= 2; capacity *= 2;
@@ -273,7 +273,7 @@ YY_BUFFER_STATE yy_create_buffer(FILE *f)
fatalerror("%s: fread error", __func__); fatalerror("%s: fread error", __func__);
size += read_count; size += read_count;
} } while (!feof(f));
pBuffer->pBufferRealStart = buf; pBuffer->pBufferRealStart = buf;
pBuffer->pBufferStart = buf + SAFETYMARGIN; pBuffer->pBufferStart = buf + SAFETYMARGIN;