From 599ce757a1f644aba35d692cec68202944f7163f Mon Sep 17 00:00:00 2001 From: ISSOtm Date: Fri, 2 Dec 2022 23:57:54 +0100 Subject: [PATCH] Force Windows builds to use our zlib and libpng Otherwise we will have a few problems if, say, a system version was detected and picked up instead of ours... --- .github/workflows/create-release-artifacts.yaml | 6 ++++-- .github/workflows/testing.yml | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/create-release-artifacts.yaml b/.github/workflows/create-release-artifacts.yaml index b78ba104..a9797ff5 100644 --- a/.github/workflows/create-release-artifacts.yaml +++ b/.github/workflows/create-release-artifacts.yaml @@ -43,16 +43,18 @@ jobs: run: | cmake --install zbuild - name: Build libpng + shell: bash run: | - cmake -S libpng -B pngbuild -A ${{ matrix.platform }} -Wno-dev -DCMAKE_INSTALL_PREFIX=install_dir -DPNG_SHARED=ON -DPNG_STATIC=ON -DPNG_TESTS=OFF + cmake -S libpng -B pngbuild -A ${{ matrix.platform }} -Wno-dev -DCMAKE_INSTALL_PREFIX=install_dir -DPNG_SHARED=ON -DPNG_STATIC=OFF -DPNG_TESTS=OFF -DPNG_BUILD_ZLIB=ON -DZLIB_INCLUDE_DIR="$PWD"/install_dir/include -DZLIB_LIBRARY="$PWD"/install_dir/lib/zlib.lib cmake --build pngbuild --config Release -j if: steps.cache.outputs.cache-hit != 'true' - name: Install libpng run: | cmake --install pngbuild - name: Build Windows binaries + shell: bash run: | - cmake -S . -B build -A ${{ matrix.platform }} -DCMAKE_INSTALL_PREFIX=install_dir -DCMAKE_BUILD_TYPE=Release + cmake -S . -B build -A ${{ matrix.platform }} -DCMAKE_INSTALL_PREFIX=install_dir -DCMAKE_BUILD_TYPE=Release -DZLIB_LIBRARY="$PWD"/install_dir/lib/zlib.lib -DZLIB_INCLUDE_DIR="$PWD"/install_dir/include -DPNG_LIBRARY="$PWD"/install_dir/lib/libpng16.lib -DPNG_INCLUDE_DIR="$PWD"/install_dir/include cmake --build build --config Release -j --verbose cmake --install build --verbose --prefix install_dir --strip - name: Package binaries diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index dd9d2ad7..4b0753d6 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -113,16 +113,18 @@ jobs: run: | cmake --install zbuild - name: Build libpng + shell: bash run: | - cmake -S libpng -B pngbuild -A ${{ matrix.platform }} -Wno-dev -DCMAKE_INSTALL_PREFIX=install_dir -DPNG_SHARED=ON -DPNG_STATIC=ON -DPNG_TESTS=OFF + cmake -S libpng -B pngbuild -A ${{ matrix.platform }} -Wno-dev -DCMAKE_INSTALL_PREFIX=install_dir -DPNG_SHARED=ON -DPNG_STATIC=OFF -DPNG_TESTS=OFF -DPNG_BUILD_ZLIB=ON -DZLIB_INCLUDE_DIR="$PWD"/install_dir/include -DZLIB_LIBRARY="$PWD"/install_dir/lib/zlib.lib cmake --build pngbuild --config Release -j if: steps.cache.outputs.cache-hit != 'true' - name: Install libpng run: | cmake --install pngbuild - name: Build Windows binaries + shell: bash run: | - cmake -S . -B build -A ${{ matrix.platform }} -DCMAKE_INSTALL_PREFIX=install_dir -DCMAKE_BUILD_TYPE=Release + cmake -S . -B build -A ${{ matrix.platform }} -DCMAKE_INSTALL_PREFIX=install_dir -DCMAKE_BUILD_TYPE=Release -DZLIB_LIBRARY="$PWD"/install_dir/lib/zlib.lib -DZLIB_INCLUDE_DIR="$PWD"/install_dir/include -DPNG_LIBRARY="$PWD"/install_dir/lib/libpng16.lib -DPNG_INCLUDE_DIR="$PWD"/install_dir/include cmake --build build --config Release -j --verbose cmake --install build --verbose --prefix install_dir - name: Package binaries