gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-09-23 14:17:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid signed overflow in RGBLINK's +, -, and * (#2060)

Browse Source 
RGBASM computes these with unsigned arithmetic and casts back, since
signed overflow is UB in C++, but RGBLINK's RPN evaluator used `int32_t`
directly, so `src/link/patch.cpp` tripped UBSan on lines 117, 121, and
124. Share the three operators through `opmath.cpp` so both evaluators
stay in step.
This commit is contained in:
Max Freedom Pollard
2026-09-07 16:15:07 -04:00
committed by GitHub
parent fdd6cece30
commit 631ef003e7
7 changed files with 35 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/link/patch.cpp
+3 -3
View File
@@ -114,14 +114,14 @@ static int32_t computeRPNExpr(Patch const &patch, std::vector<Symbol> const &fil
int32_t value;
switch (command) {
case RPN_ADD:
value = popRPN(patch) + popRPN(patch);
value = op_add(popRPN(patch), popRPN(patch));
break;
case RPN_SUB:
value = popRPN(patch);
value = popRPN(patch) - value;
value = op_sub(popRPN(patch), value);
break;
case RPN_MUL:
value = popRPN(patch) * popRPN(patch);
value = op_mul(popRPN(patch), popRPN(patch));
break;
case RPN_DIV:
value = popRPN(patch);