gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-08-22 06:44:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor warning diagnostic code to reduce repeated output logic

Browse Source
This commit is contained in:
Rangi
2026-07-04 23:02:16 -04:00
committed by Rangi
parent de36a11be7
commit 6e643406a2
9 changed files with 174 additions and 253 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gfx/warning.cpp
+13 -46
View File
@@ -47,65 +47,32 @@ void requireZeroErrors() {
}
void error(char const *fmt, ...) {
va_list ap;
style_Set(stderr, STYLE_RED, true);
fputs("error: ", stderr);
style_Reset(stderr);
va_start(ap, fmt);
vfprintf(stderr, fmt, ap);
va_end(ap);
putc('\n', stderr);
va_list args;
va_start(args, fmt);
verrorx(fmt, args);
va_end(args);
warnings.incrementErrors();
}
[[noreturn]]
void fatal(char const *fmt, ...) {
va_list ap;
style_Set(stderr, STYLE_RED, true);
fputs("FATAL: ", stderr);
style_Reset(stderr);
va_start(ap, fmt);
vfprintf(stderr, fmt, ap);
va_end(ap);
putc('\n', stderr);
va_list args;
va_start(args, fmt);
vfatalx(fmt, args);
va_end(args);
warnings.incrementErrors();
giveUp();
}
void warning(WarningID id, char const *fmt, ...) {
char const *flag = warnings.warningFlags[id].name;
va_list ap;
switch (warnings.getWarningBehavior(id)) {
case WarningBehavior::DISABLED:
break;
case WarningBehavior::ENABLED:
style_Set(stderr, STYLE_YELLOW, true);
fputs("warning: ", stderr);
style_Reset(stderr);
va_start(ap, fmt);
vfprintf(stderr, fmt, ap);
va_end(ap);
style_Set(stderr, STYLE_YELLOW, true);
fprintf(stderr, " [-W%s]\n", flag);
style_Reset(stderr);
break;
case WarningBehavior::ERROR:
style_Set(stderr, STYLE_RED, true);
fputs("error: ", stderr);
style_Reset(stderr);
va_start(ap, fmt);
vfprintf(stderr, fmt, ap);
va_end(ap);
style_Set(stderr, STYLE_RED, true);
fprintf(stderr, " [-Werror=%s]\n", flag);
style_Reset(stderr);
va_list args;
va_start(args, fmt);
WarningBehavior behavior = printDiagnostic(warnings, id, fmt, args);
va_end(args);
if (behavior == WarningBehavior::ERROR) {
warnings.incrementErrors();
break;
}
}