gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 18:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow ROMX and WRAMX sections in restricted modes

Browse Source 
Closes #462, although with this implementation `BANK("some ROMX section")` would
return 0 instead of 1, which I think is benign anyways
This commit is contained in:
ISSOtm
2020-01-16 22:24:05 +01:00
parent 89917ef688
commit 71fe652556
3 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/link/section.c
View File

@@ -111,12 +111,20 @@ static void doSanityChecks(struct Section *section, void *ptr)
if (section->type < 0 || section->type >= SECTTYPE_INVALID)
fail("Section \"%s\" has an invalid type.", section->name);
if (is32kMode && section->type == SECTTYPE_ROMX)
fail("%s: ROMX sections cannot be used with option -t.",
section->name);
if (isWRA0Mode && section->type == SECTTYPE_WRAMX)
fail("%s: WRAMX sections cannot be used with options -w or -d.",
section->name);
if (is32kMode && section->type == SECTTYPE_ROMX) {
if (section->isBankFixed && section->bank != 1)
fail("%s: ROMX sections must be in bank 1 with option -t.",
section->name);
else
section->type = SECTTYPE_ROM0;
}
if (isWRA0Mode && section->type == SECTTYPE_WRAMX) {
if (section->isBankFixed && section->bank != 1)
fail("%s: WRAMX sections must be in bank 1 with options -w or -d.",
section->name);
else
section->type = SECTTYPE_WRAMX;
}
if (isDmgMode && section->type == SECTTYPE_VRAM && section->bank == 1)
fail("%s: VRAM bank 1 can't be used with option -d.",
section->name);

3
test/link/romx-tiny-t.out
View File

@@ -1,2 +1 @@
warning: rx: ROMX sections cannot be used with option -t.
error: Sanity checks failed
error: Unable to place "r0a" (ROM0 section) anywhere

2
test/link/wramx-dmg-mode-d.out
View File

@@ -1,2 +0,0 @@
warning: wx: WRAMX sections cannot be used with options -w or -d.
error: Sanity checks failed