Make quote marks consistent in error/warning messages (#1791)

- "Double quotes" for strings (filenames, section names, CLI option arguments, etc)
- 'Single quotes' for characters and CLI option flags
- `Backticks` for keywords and identifiers (symbol names, charmap names, etc)

CLI option flags also have their leading dashes

test/link/bank-const/out.err

@@ -1,3 +1,3 @@
-error: Requested BANK() of non-label symbol "CONSTANT"
+error: Requested `BANK()` of non-label symbol `CONSTANT`
     at bank-const/b.asm(2)
 Linking failed with 1 error

test/link/cascading-errors-fatal-assert.out

@@ -1,4 +1,4 @@
-error: Undefined symbol "UnknownSymbol"
+error: Undefined symbol `UnknownSymbol`
     at cascading-errors-fatal-assert.asm(1)
 FATAL: Failed to evaluate assertion
     at cascading-errors-fatal-assert.asm(1)

test/link/cascading-errors.out

@@ -1,21 +1,21 @@
-error: Undefined symbol "Foo"
+error: Undefined symbol `Foo`
     at cascading-errors.asm(18)
-error: Undefined symbol "Bar"
+error: Undefined symbol `Bar`
     at cascading-errors.asm(19)
-error: Undefined symbol "hNonExist"
+error: Undefined symbol `hNonExist`
     at cascading-errors.asm(16)
-error: Undefined symbol "NonExist"
+error: Undefined symbol `NonExist`
     at cascading-errors.asm(14)
-error: Undefined symbol "Foo"
+error: Undefined symbol `Foo`
     at cascading-errors.asm(12)
-error: Undefined symbol "Foo"
+error: Undefined symbol `Foo`
     at cascading-errors.asm(10)
 error: Division by 0
     at cascading-errors.asm(10)
-error: Undefined symbol "Foo"
+error: Undefined symbol `Foo`
     at cascading-errors.asm(9)
-error: Undefined symbol "Bar"
+error: Undefined symbol `Bar`
     at cascading-errors.asm(9)
-error: Undefined symbol "Bar"
+error: Undefined symbol `Bar`
     at cascading-errors.asm(8)
 Linking failed with 10 errors

test/link/invalid-bank-t.out

@@ -1,2 +1,2 @@
-error: Section "test" has type ROMX, which must be in bank 1 (if any) with option `-t`
+error: Section "test" has type `ROMX`, which must be in bank 1 (if any) with option '-t'
 Linking failed with 1 error

test/link/invalid-patches.out

@@ -1,14 +1,14 @@
-error: JR target must be between -128 and 127 bytes away, not 190; use JP instead
+error: `JR` target must be between -128 and 127 bytes away, not 190; use `JP` instead
     at invalid-patches.asm(10)
-error: Address $0 for LDH is not in HRAM range; use LD instead
+error: Address $0 for `LDH` is not in HRAM range; use `LD` instead
     at invalid-patches.asm(9)
-error: Requested SIZEOF() of undefined section "NonexistentSection"
+error: Requested `SIZEOF()` of undefined section "NonexistentSection"
     at invalid-patches.asm(8)
-error: Requested STARTOF() of undefined section "NonexistentSection"
+error: Requested `STARTOF()` of undefined section "NonexistentSection"
     at invalid-patches.asm(7)
-error: Requested BANK() of undefined section "NonexistentSection"
+error: Requested `BANK()` of undefined section "NonexistentSection"
     at invalid-patches.asm(6)
-error: Requested BANK() of undefined symbol "NonexistentSymbol"
+error: Requested `BANK()` of undefined symbol `NonexistentSymbol`
     at invalid-patches.asm(5)
 error: Exponent by negative value -1
     at invalid-patches.asm(4)

test/link/invalid-ram-types-d.out

@@ -1,3 +1,3 @@
-error: Section "test1" has type WRAMX, which must be in bank 1 with options `-w` or `-d`
-error: Section "test2" has type VRAM, which must be in bank 0 with option `-d`
+error: Section "test1" has type `WRAMX`, which must be in bank 1 with options '-w' or '-d'
+error: Section "test2" has type `VRAM`, which must be in bank 0 with option '-d'
 Linking failed with 2 errors

test/link/ldh-bad.out

@@ -1,3 +1,3 @@
-error: Address $1234 for LDH is not in HRAM range; use LD instead
+error: Address $1234 for `LDH` is not in HRAM range; use `LD` instead
     at ldh-bad.asm(2)
 Linking failed with 1 error

test/link/rst-bad.out

@@ -1,3 +1,3 @@
-error: Value $1 is not a RST vector; use CALL instead
+error: Value $1 is not a `RST` vector; use `CALL` instead
     at rst-bad.asm(2)
 Linking failed with 1 error

test/link/scramble-invalid/out.err

@@ -1,2 +1,2 @@
-FATAL: Unexpected character ':' in spec for option 'S'
+FATAL: Unexpected character ':' in spec for option '-S'
 Linking aborted with 1 error

test/link/script-oob-bank-num.out

@@ -1,9 +1,9 @@
-error: script-oob-bank-num.link(1): ROM0 bank 1 doesn't exist (the maximum is 0)
-error: script-oob-bank-num.link(2): ROMX bank 0 doesn't exist (the minimum is 1)
-error: script-oob-bank-num.link(3): VRAM bank 2 doesn't exist (the maximum is 1)
-error: script-oob-bank-num.link(4): WRAM0 bank 1 doesn't exist (the maximum is 0)
-error: script-oob-bank-num.link(5): WRAMX bank 0 doesn't exist (the minimum is 1)
-error: script-oob-bank-num.link(6): WRAMX bank 8 doesn't exist (the maximum is 7)
-error: script-oob-bank-num.link(7): OAM bank 1 doesn't exist (the maximum is 0)
-error: script-oob-bank-num.link(8): HRAM bank 1 doesn't exist (the maximum is 0)
+error: script-oob-bank-num.link(1): ROM0 bank 1 does not exist (the maximum is 0)
+error: script-oob-bank-num.link(2): ROMX bank 0 does not exist (the minimum is 1)
+error: script-oob-bank-num.link(3): VRAM bank 2 does not exist (the maximum is 1)
+error: script-oob-bank-num.link(4): WRAM0 bank 1 does not exist (the maximum is 0)
+error: script-oob-bank-num.link(5): WRAMX bank 0 does not exist (the minimum is 1)
+error: script-oob-bank-num.link(6): WRAMX bank 8 does not exist (the maximum is 7)
+error: script-oob-bank-num.link(7): OAM bank 1 does not exist (the maximum is 0)
+error: script-oob-bank-num.link(8): HRAM bank 1 does not exist (the maximum is 0)
 Linking failed with 8 errors

test/link/script-unk-keyword.out

@@ -1,2 +1,2 @@
-error: script-unk-keyword.link(1): Unknown keyword "bonjour"
+error: script-unk-keyword.link(1): Unknown keyword `bonjour`
 Linking failed with 1 error

test/link/section-conflict/different-mod/out.err

@@ -1,4 +1,4 @@
-FATAL: Section "test" is defined as SECTION FRAGMENT, but also as SECTION UNION
+FATAL: Section "test" is defined as `SECTION FRAGMENT`, but also as `SECTION UNION`
     at section-conflict/different-mod/a.asm(1)
     and also:
     at section-conflict/different-mod/b.asm(1)

test/link/section-union/bad-types.out

@@ -1,10 +1,10 @@
-FATAL: Section "conflicting types" is defined with type HRAM, but also with type WRAM0
+FATAL: Section "conflicting types" is defined with type `HRAM`, but also with type `WRAM0`
     at section-union/bad-types.asm(7)
     and also:
     at section-union/bad-types.asm(7)
 Linking aborted with 1 error
 ---
-error: Section already exists but with type HRAM
+error: Section already exists but with type `HRAM`
     at <stdin>(18)
 FATAL: Cannot create section "conflicting types" (1 error)
     at <stdin>(18)

test/link/section-union/data-overlay.out

@@ -1,7 +1,7 @@
-FATAL: Section "overlaid data" is of type ROM0, which cannot be unionized
+FATAL: Section "overlaid data" is of type `ROM0`, which cannot be `UNION`ized
 Linking aborted with 1 error
 ---
-error: Cannot declare ROM sections as UNION
+error: Cannot declare ROM sections as `UNION`
     at <stdin>(18)
 FATAL: Cannot create section "overlaid data" (1 error)
     at <stdin>(18)

test/link/section-union/different-data.out

@@ -1,7 +1,7 @@
-FATAL: Section "different data" is of type ROM0, which cannot be unionized
+FATAL: Section "different data" is of type `ROM0`, which cannot be `UNION`ized
 Linking aborted with 1 error
 ---
-error: Cannot declare ROM sections as UNION
+error: Cannot declare ROM sections as `UNION`
     at <stdin>(16)
 FATAL: Cannot create section "different data" (1 error)
     at <stdin>(16)

test/link/section-union/different-size.out

@@ -1,7 +1,7 @@
-FATAL: Section "different section sizes" is of type ROM0, which cannot be unionized
+FATAL: Section "different section sizes" is of type `ROM0`, which cannot be `UNION`ized
 Linking aborted with 1 error
 ---
-error: Cannot declare ROM sections as UNION
+error: Cannot declare ROM sections as `UNION`
     at <stdin>(16)
 FATAL: Cannot create section "different section sizes" (1 error)
     at <stdin>(16)

test/link/section-union/different-syntaxes.out

@@ -1,7 +1,7 @@
-FATAL: Section "different syntaxes" is of type ROM0, which cannot be unionized
+FATAL: Section "different syntaxes" is of type `ROM0`, which cannot be `UNION`ized
 Linking aborted with 1 error
 ---
-error: Cannot declare ROM sections as UNION
+error: Cannot declare ROM sections as `UNION`
     at <stdin>(18)
 FATAL: Cannot create section "different syntaxes" (1 error)
     at <stdin>(18)

test/link/section-union/same-export/out.err

@@ -1,4 +1,4 @@
-FATAL: "Same" is defined as a label, but also as another label
+FATAL: `Same` is defined as a label, but also as another label
     at section-union/same-export/b.asm(2)
     and also:
     at section-union/same-export/a.asm(2)

test/link/section-union/split-data.out

@@ -1,7 +1,7 @@
-FATAL: Section "mutually-overlaid data" is of type ROM0, which cannot be unionized
+FATAL: Section "mutually-overlaid data" is of type `ROM0`, which cannot be `UNION`ized
 Linking aborted with 1 error
 ---
-error: Cannot declare ROM sections as UNION
+error: Cannot declare ROM sections as `UNION`
     at <stdin>(18)
 FATAL: Cannot create section "mutually-overlaid data" (1 error)
     at <stdin>(18)

test/link/sym-noexist.out

@@ -1,5 +1,5 @@
-error: Undefined symbol "nothing"
+error: Undefined symbol `nothing`
     at sym-noexist.asm(3)
-error: Undefined symbol "where"
+error: Undefined symbol `where`
     at sym-noexist.asm(2)
 Linking failed with 2 errors

test/link/symbols/conflict/out.err

@@ -1,4 +1,4 @@
-FATAL: "SAME" is defined as 2, but also as 1
+FATAL: `SAME` is defined as 2, but also as 1
     at symbols/conflict/b.asm(1)
     and also:
     at symbols/conflict/a.asm(1)

test/link/symbols/unknown/out.err

@@ -1,4 +1,4 @@
-error: Undefined symbol "Label"
+error: Undefined symbol `Label`
     at symbols/unknown/a.asm(2)
     4 symbols with that name are defined but not exported:
     at symbols/unknown/b.asm(2)

test/link/vram-fixed-dmg-mode-d.out

@@ -1,2 +1,2 @@
-error: Section "v1" has type VRAM, which must be in bank 0 with option `-d`
+error: Section "v1" has type `VRAM`, which must be in bank 0 with option '-d'
 Linking failed with 1 error