gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 10:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Take care of miscellaneous commented TODOs (#1676)

Browse Source
This commit is contained in:
Rangi
2025-05-02 16:44:12 -04:00
committed by GitHub
parent 8cf6c5423a
commit 7c6f778ae7
11 changed files with 60 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/asm/label-diff.asm
View File

@@ -1,6 +1,3 @@
PUSHS
SECTION "floating", ROM0
Known: ; This symbol is known to be a label, but its value is not known yet
@@ -15,15 +12,14 @@ SECTION "fixed 2", ROM0[69]
Constant2: ; Same as above
ENDSECTION ; Ensure we are in neither section
MACRO print_diff
PRINTLN (\1) - (\2)
PRINTLN (\2) - (\1)
ENDM
POPS ; Ensure we are in neither section
; TODO: uncomment all that can be, there is seriously room for improvement here
; Diffing two constants should work
print_diff Constant, Constant2
; Diffing two labels in the same SECTION as well

54
test/asm/label-diff.err
View File

@@ -1,37 +1,37 @@
error: label-diff.asm(28) -> label-diff.asm::print_diff(19):
Expected constant expression: 'Known' is not constant at assembly time
error: label-diff.asm(28) -> label-diff.asm::print_diff(20):
Expected constant expression: 'Known' is not constant at assembly time
error: label-diff.asm(30) -> label-diff.asm::print_diff(19):
Expected constant expression: 'Unknown' is not constant at assembly time
error: label-diff.asm(30) -> label-diff.asm::print_diff(20):
Expected constant expression: 'Unknown' is not constant at assembly time
error: label-diff.asm(32) -> label-diff.asm::print_diff(19):
Expected constant expression: 'Known' is not constant at assembly time
error: label-diff.asm(32) -> label-diff.asm::print_diff(20):
Expected constant expression: 'Known' is not constant at assembly time
error: label-diff.asm(32) -> label-diff.asm::print_diff(21):
Expected constant expression: 'Known' is not constant at assembly time
Expected constant expression: 'Unknown' is not constant at assembly time
error: label-diff.asm(34) -> label-diff.asm::print_diff(19):
Expected constant expression: 'Unknown' is not constant at assembly time
error: label-diff.asm(34) -> label-diff.asm::print_diff(20):
Expected constant expression: 'Unknown' is not constant at assembly time
error: label-diff.asm(34) -> label-diff.asm::print_diff(21):
Expected constant expression: 'Unknown' is not constant at assembly time
error: label-diff.asm(36) -> label-diff.asm::print_diff(20):
Expected constant expression: 'Known' is not constant at assembly time
error: label-diff.asm(36) -> label-diff.asm::print_diff(21):
Expected constant expression: 'Unknown' is not constant at assembly time
error: label-diff.asm(38) -> label-diff.asm::print_diff(20):
Expected constant expression: 'Unknown' is not constant at assembly time
error: label-diff.asm(38) -> label-diff.asm::print_diff(21):
Expected constant expression: 'Unknown2' is not constant at assembly time
error: label-diff.asm(45) -> label-diff.asm::print_diff(20):
error: label-diff.asm(41) -> label-diff.asm::print_diff(19):
Expected constant expression: 'Known' is not constant at assembly time
error: label-diff.asm(45) -> label-diff.asm::print_diff(21):
error: label-diff.asm(41) -> label-diff.asm::print_diff(20):
Expected constant expression: 'Known' is not constant at assembly time
error: label-diff.asm(47) -> label-diff.asm::print_diff(20):
error: label-diff.asm(43) -> label-diff.asm::print_diff(19):
Expected constant expression: 'Unknown' is not constant at assembly time
error: label-diff.asm(47) -> label-diff.asm::print_diff(21):
error: label-diff.asm(43) -> label-diff.asm::print_diff(20):
Expected constant expression: 'Unknown' is not constant at assembly time
error: label-diff.asm(54) -> label-diff.asm::print_diff(19):
Expected constant expression: PC is not constant at assembly time
error: label-diff.asm(54) -> label-diff.asm::print_diff(20):
Expected constant expression: PC is not constant at assembly time
error: label-diff.asm(56) -> label-diff.asm::print_diff(19):
Expected constant expression: 'Known' is not constant at assembly time
error: label-diff.asm(56) -> label-diff.asm::print_diff(20):
Expected constant expression: PC is not constant at assembly time
error: label-diff.asm(58) -> label-diff.asm::print_diff(19):
Expected constant expression: 'Unknown' is not constant at assembly time
error: label-diff.asm(58) -> label-diff.asm::print_diff(20):
Expected constant expression: PC is not constant at assembly time
error: label-diff.asm(58) -> label-diff.asm::print_diff(21):
Expected constant expression: PC is not constant at assembly time
error: label-diff.asm(60) -> label-diff.asm::print_diff(20):
Expected constant expression: 'Known' is not constant at assembly time
error: label-diff.asm(60) -> label-diff.asm::print_diff(21):
Expected constant expression: PC is not constant at assembly time
error: label-diff.asm(62) -> label-diff.asm::print_diff(20):
Expected constant expression: 'Unknown' is not constant at assembly time
error: label-diff.asm(62) -> label-diff.asm::print_diff(21):
Expected constant expression: PC is not constant at assembly time
error: Assembly aborted (18 errors)!

8
test/asm/unique-id.asm
View File

@@ -7,9 +7,9 @@ macro m
ENDR
warn_unique
endm
; TODO: Ideally we'd test now as well, but it'd cause a fatal error
;warn_unique
m
;warn_unique
warn_unique
m
warn_unique
m
warn_unique

14
test/asm/unique-id.err
View File

@@ -1,3 +1,9 @@
error: unique-id.asm(11):
'\@' cannot be used outside of a macro or REPT/FOR block
while expanding symbol "warn_unique"
warning: unique-id.asm(11): [-Wuser]
!
while expanding symbol "warn_unique"
warning: unique-id.asm(12) -> unique-id.asm::m(4): [-Wuser]
_u1!
while expanding symbol "warn_unique"
@@ -10,6 +16,12 @@ while expanding symbol "warn_unique"
warning: unique-id.asm(12) -> unique-id.asm::m(8): [-Wuser]
_u1!
while expanding symbol "warn_unique"
error: unique-id.asm(13):
'\@' cannot be used outside of a macro or REPT/FOR block
while expanding symbol "warn_unique"
warning: unique-id.asm(13): [-Wuser]
!
while expanding symbol "warn_unique"
warning: unique-id.asm(14) -> unique-id.asm::m(4): [-Wuser]
_u4!
while expanding symbol "warn_unique"
@@ -28,4 +40,4 @@ while expanding symbol "warn_unique"
warning: unique-id.asm(15): [-Wuser]
!
while expanding symbol "warn_unique"
error: Assembly aborted (1 error)!
error: Assembly aborted (3 errors)!

9
test/gfx/rgbgfx_test.cpp
View File

@@ -173,11 +173,6 @@ public:
png_set_read_fn(png, this, readData);
png_set_sig_bytes(png, pngHeader.size());
// TODO: png_set_crc_action(png, PNG_CRC_ERROR_QUIT, PNG_CRC_WARN_DISCARD);
// Skipping chunks we don't use should improve performance
// TODO: png_set_keep_unknown_chunks(png, ...);
// Process all chunks up to but not including the image data
png_read_info(png, info);
@@ -202,9 +197,7 @@ public:
}
}
// Set up transformations; to turn everything into RGBA888
// TODO: it's not necessary to uniformize the pixel data (in theory), and not doing
// so *might* improve performance, and should reduce memory usage.
// Set up transformations to turn everything into RGBA888 for simplicity of handling
// Convert grayscale to RGB
switch (colorType & ~PNG_COLOR_MASK_ALPHA) {