From 8025c2ae6641caefae2744aa2c7be3abff5cba01 Mon Sep 17 00:00:00 2001
From: ISSOtm <me@eldred.fr>
Date: Sat, 28 Mar 2026 11:31:49 +0100
Subject: [PATCH] Require uploaded artifacts to be non-empty

We can get silent failures otherwise
---
 .github/workflows/coverage.yml                 | 1 +
 .github/workflows/create-release-artifacts.yml | 3 +++
 .github/workflows/testing.yml                  | 5 +++++
 3 files changed, 9 insertions(+)

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
index f8e7b43c..261cad2e 100644
--- a/.github/workflows/coverage.yml
+++ b/.github/workflows/coverage.yml
@@ -32,3 +32,4 @@ jobs:
           path: |
             coverage
             dummy-file-to-keep-directory-structure.txt
+          if-no-files-found: error
diff --git a/.github/workflows/create-release-artifacts.yml b/.github/workflows/create-release-artifacts.yml
index 0192be7f..640653c2 100644
--- a/.github/workflows/create-release-artifacts.yml
+++ b/.github/workflows/create-release-artifacts.yml
@@ -60,6 +60,7 @@ jobs:
         with:
           name: win${{ matrix.bits }}
           path: rgbds-win${{ matrix.bits }}.zip
+          if-no-files-found: error
 
   macos:
     runs-on: macos-14
@@ -91,6 +92,7 @@ jobs:
         with:
           name: macos
           path: rgbds-macos.zip
+          if-no-files-found: error
 
   linux:
     runs-on: ubuntu-22.04 # Oldest supported, for best glibc compatibility.
@@ -118,6 +120,7 @@ jobs:
         with:
           name: linux
           path: rgbds-linux-x86_64.tar.xz
+          if-no-files-found: error
 
   release:
     runs-on: ubuntu-latest
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
index beccc050..46f8f73e 100644
--- a/.github/workflows/testing.yml
+++ b/.github/workflows/testing.yml
@@ -63,6 +63,7 @@ jobs:
         with:
           name: rgbds-canary-${{ matrix.os }}-${{ matrix.cxx }}-${{ matrix.buildsys }}
           path: bins
+          if-no-files-found: error
       - name: Compute test dependency cache params
         id: test-deps-cache-params
         shell: bash
@@ -120,6 +121,7 @@ jobs:
         with:
           name: rgbds-canary-macos-static
           path: bins
+          if-no-files-found: error
       - name: Compute test dependency cache params
         id: test-deps-cache-params
         shell: bash
@@ -188,6 +190,7 @@ jobs:
         with:
           name: rgbds-canary-w${{ matrix.bits }}-${{ matrix.os }}
           path: bins
+          if-no-files-found: error
       - name: Compute test dependency cache params
         id: test-deps-cache-params
         shell: bash
@@ -263,6 +266,7 @@ jobs:
         with:
           name: rgbds-canary-mingw-win${{ matrix.bits }}
           path: bins
+          if-no-files-found: error
       - name: Upload Windows test binaries
         uses: actions/upload-artifact@v4
         with:
@@ -270,6 +274,7 @@ jobs:
           path: |
             test/gfx/randtilegen.exe
             test/gfx/rgbgfx_test.exe
+          if-no-files-found: error
 
   windows-mingw-testing:
     needs: windows-mingw-build