gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-21 02:32:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable more sanitizers in make develop (#1588)

Browse Source 
- `-fsanitize=undefined` encompasses multiple checks we were specifying

- "detect_leaks=1" for `__asan_default_options` checks for memory leaks
  (except for with macOS clang++, which does not support LSan)

- `-fsanitize=float-divide-by-zero` is an extra UBSan check
  (and reveals a UB bug to fix with fixed-point `DIV` and `LOG`)
This commit is contained in:
Rangi
2024-12-31 04:02:20 -05:00
committed by GitHub
parent 72b2a4d7c0
commit 8363f25d47
6 changed files with 32 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/asm/fixpoint.cpp
View File

@@ -73,7 +73,11 @@ int32_t fix_Mul(int32_t i, int32_t j, int32_t q) {
}
int32_t fix_Div(int32_t i, int32_t j, int32_t q) {
return double2fix(fix2double(i, q) / fix2double(j, q), q);
double dividend = fix2double(i, q);
double divisor = fix2double(j, q);
if (fpclassify(divisor) == FP_ZERO)
return dividend < 0 ? INT32_MIN : dividend > 0 ? INT32_MAX : 0;
return double2fix(dividend / divisor, q);
}
int32_t fix_Mod(int32_t i, int32_t j, int32_t q) {
@@ -85,7 +89,10 @@ int32_t fix_Pow(int32_t i, int32_t j, int32_t q) {
}
int32_t fix_Log(int32_t i, int32_t j, int32_t q) {
return double2fix(log(fix2double(i, q)) / log(fix2double(j, q)), q);
double divisor = log(fix2double(j, q));
if (fpclassify(divisor) == FP_ZERO)
return INT32_MAX;
return double2fix(log(fix2double(i, q)) / divisor, q);
}
int32_t fix_Round(int32_t i, int32_t q) {