From 877ce79a3919025339057b0dbf5e6136360da8eb Mon Sep 17 00:00:00 2001 From: Rangi <35663410+Rangi42@users.noreply.github.com> Date: Sun, 27 Sep 2026 11:51:24 -0400 Subject: [PATCH] Remove non-functioning and unused `--installed-rgbds` flag from `run-tests.sh` (#2174) --- test/run-tests.sh | 28 +++------------------------- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/test/run-tests.sh b/test/run-tests.sh index 1d209f7c..61b8315f 100755 --- a/test/run-tests.sh +++ b/test/run-tests.sh @@ -18,8 +18,6 @@ Options: --only-free skip tests that build nonfree codebases --jobs build external codebases with `make -j` --os skip tests known to fail on (e.g. `macos-14`) - --installed-rgbds use the system installed RGBDS - (only compatible with external codebases) EOF } @@ -28,7 +26,6 @@ EOF nonfree=true internal=true external=true -installedrgbds=false make_jobs= osname= while [[ $# -gt 0 ]]; do @@ -46,9 +43,6 @@ while [[ $# -gt 0 ]]; do --only-free) nonfree=false ;; - --installed-rgbds) - installedrgbds=true - ;; --jobs) shift make_jobs="-j$1" @@ -73,26 +67,10 @@ if ! "$internal" && ! "$external"; then false fi -if "$internal" && "$installedrgbds"; then - echo "Please specify --only-external with --installed-rgbds" - echo "(internal tests don't support running with system-installed RGBDS)" - false -fi - # Refuse to run if RGBDS isn't available -if "$installedrgbds"; then - is_installed() { - command -v "$1" >/dev/null 2>&1 - } - if ! (is_installed rgbasm && is_installed rgblink && is_installed rgbfix && is_installed rgbgfx); then - echo "Please install RGBDS before running the tests" - false - fi -else - if [[ ! ( -x ../rgbasm && -x ../rgblink && -x ../rgbfix && -x ../rgbgfx ) ]]; then - echo "Please build RGBDS before running the tests" - false - fi +if [[ ! ( -x ../rgbasm && -x ../rgblink && -x ../rgbfix && -x ../rgbgfx ) ]]; then + echo "Please build RGBDS before running the tests" + false fi # Tests included with the repository