gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-21 10:42:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add more checks to section creation in RGBASM

Browse Source 
Fixes rednex#471, but also backports a couple more checks from RGBLINK
This commit is contained in:
ISSOtm
2020-02-04 02:05:33 +01:00
parent a4fe274c25
commit 8c4b473d6f
5 changed files with 37 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/asm/section.c
View File

@@ -159,6 +159,8 @@ static void setCurrentSection(struct Section *pSect)
void out_NewSection(char const *pzName, uint32_t secttype, int32_t org,
struct SectionSpec const *attributes)
{
uint32_t align = 1 << attributes->alignment;
if (attributes->bank != -1) {
if (secttype != SECTTYPE_ROMX && secttype != SECTTYPE_VRAM
&& secttype != SECTTYPE_SRAM && secttype != SECTTYPE_WRAMX)
@@ -171,6 +173,26 @@ void out_NewSection(char const *pzName, uint32_t secttype, int32_t org,
bankranges[secttype][1]);
}
if (align != 1) {
/* It doesn't make sense to have both set */
uint32_t mask = align - 1;
if (org != -1) {
if (org & mask)
yyerror("Section \"%s\"'s fixed address doesn't match its alignment",
pzName);
else
align = 1; /* Ignore it if it's satisfied */
}
}
if (org != -1) {
if (org < startaddr[secttype] || org > endaddr(secttype))
yyerror("Section \"%s\"'s fixed address %#x is outside of range [%#x; %#x]",
pzName, org, startaddr[secttype],
endaddr(secttype));
}
setCurrentSection(findSection(pzName, secttype, org, attributes->bank,
1 << attributes->alignment));
}