From 8e92383fa35e1955d891d1e6de9c70a8cc82ff25 Mon Sep 17 00:00:00 2001 From: ISSOtm Date: Tue, 21 Jul 2020 21:05:54 +0200 Subject: [PATCH] Enable -Wobsolete by default The fact that deprecations were common and quickly acted upon was raised by some users --- src/asm/rgbasm.1 | 4 +--- src/asm/warning.c | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/asm/rgbasm.1 b/src/asm/rgbasm.1 index cca7e1cc..e8063e6c 100644 --- a/src/asm/rgbasm.1 +++ b/src/asm/rgbasm.1 @@ -219,14 +219,12 @@ This warning is enabled by Warn when a string too long to fit in internal buffers is encountered. This warning is enabled by .Fl Wall . -.It Fl Wobsolete +.It Fl Wno-obsolete Warn when obsolete constructs such as the .Ic jp [hl] instruction or .Ic HOME section type are encountered. -This warning is enabled by -.Fl Wextra . .It Fl Wshift Warn when shifting right a negative value. Use a division by 2^N instead. diff --git a/src/asm/warning.c b/src/asm/warning.c index 163fe7ba..83a8bdab 100644 --- a/src/asm/warning.c +++ b/src/asm/warning.c @@ -35,7 +35,7 @@ static enum WarningState const defaultWarnings[NB_WARNINGS] = { WARNING_DISABLED, /* Empty entry in `db`, `dw` or `dl` */ WARNING_DISABLED, /* Constants too large */ WARNING_DISABLED, /* String too long for internal buffers */ - WARNING_DISABLED, /* Obsolete things */ + WARNING_ENABLED, /* Obsolete things */ WARNING_DISABLED, /* Shifting undefined behavior */ WARNING_DISABLED, /* Strange shift amount */ WARNING_ENABLED, /* Implicit truncation loses some bits */ @@ -101,7 +101,6 @@ static uint8_t const _wallCommands[] = { /* Warnings that are less likely to indicate an error */ static uint8_t const _wextraCommands[] = { WARNING_EMPTY_ENTRY, - WARNING_OBSOLETE, META_WARNING_DONE };