gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 10:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Derive operator!= from operator== (#1660)

Browse Source
This commit is contained in:
Rangi
2025-02-15 12:37:42 +01:00
committed by GitHub
parent 62309d5c87
commit 993879a2ed
6 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/create-release-artifacts.yml vendored
View File

@@ -100,7 +100,7 @@ jobs:
path: rgbds-${{ env.version }}-macos.zip path: rgbds-${{ env.version }}-macos.zip
linux: linux:
runs-on: ubuntu-20.04 # Oldest supported, for best glibc compatibility. runs-on: ubuntu-22.04 # Oldest supported, for best glibc compatibility.
steps: steps:
- name: Get version from tag - name: Get version from tag
shell: bash shell: bash
@@ -112,7 +112,7 @@ jobs:
- name: Install deps - name: Install deps
shell: bash shell: bash
run: | run: |
./.github/scripts/install_deps.sh ubuntu-20.04 ./.github/scripts/install_deps.sh ubuntu-22.04
- name: Build binaries - name: Build binaries
run: | run: |
make -kj WARNFLAGS="-Wall -Wextra -pedantic -static" PKG_CONFIG="pkg-config --static" Q= make -kj WARNFLAGS="-Wall -Wextra -pedantic -static" PKG_CONFIG="pkg-config --static" Q=

2
.github/workflows/testing.yml vendored
View File

@@ -7,7 +7,7 @@ jobs:
unix: unix:
strategy: strategy:
matrix: matrix:
os: [ubuntu-20.04, ubuntu-22.04, macos-14] os: [ubuntu-22.04, macos-14]
cxx: [g++, clang++] cxx: [g++, clang++]
buildsys: [make, cmake] buildsys: [make, cmake]
exclude: exclude:

1
include/gfx/rgba.hpp
View File

@@ -38,7 +38,6 @@ struct Rgba {
} }
bool operator==(Rgba const &rhs) const { return toCSS() == rhs.toCSS(); } bool operator==(Rgba const &rhs) const { return toCSS() == rhs.toCSS(); }
bool operator!=(Rgba const &rhs) const { return !operator==(rhs); }
// CGB colors are RGB555, so we use bit 15 to signify that the color is transparent instead // CGB colors are RGB555, so we use bit 15 to signify that the color is transparent instead
// Since the rest of the bits don't matter then, we return 0x8000 exactly. // Since the rest of the bits don't matter then, we return 0x8000 exactly.

2
include/itertools.hpp
View File

@@ -25,7 +25,6 @@ class EnumSeq {
auto operator*() const { return _value; } auto operator*() const { return _value; }
bool operator==(Iterator const &rhs) const { return _value == rhs._value; } bool operator==(Iterator const &rhs) const { return _value == rhs._value; }
bool operator!=(Iterator const &rhs) const { return !operator==(rhs); }
}; };
public: public:
@@ -59,7 +58,6 @@ public:
bool operator==(ZipIterator const &rhs) const { bool operator==(ZipIterator const &rhs) const {
return std::get<0>(_iters) == std::get<0>(rhs._iters); return std::get<0>(_iters) == std::get<0>(rhs._iters);
} }
bool operator!=(ZipIterator const &rhs) const { return !operator==(rhs); }
}; };
template<typename... Ts> template<typename... Ts>

1
src/gfx/pal_packing.cpp
View File

@@ -87,7 +87,6 @@ private:
Iter() = default; Iter() = default;
bool operator==(Iter const &rhs) const { return _iter == rhs._iter; } bool operator==(Iter const &rhs) const { return _iter == rhs._iter; }
bool operator!=(Iter const &rhs) const { return !operator==(rhs); }
Iter &operator++() { Iter &operator++() {
++_iter; ++_iter;

1
src/gfx/process.cpp
View File

@@ -466,7 +466,6 @@ public:
} }
bool operator==(Iterator const &rhs) const { return coords() == rhs.coords(); } bool operator==(Iterator const &rhs) const { return coords() == rhs.coords(); }
bool operator!=(Iterator const &rhs) const { return !operator==(rhs); }
}; };
public: public: