From 9b3d19c3f2c5292ef0a8920f1c3ea9e573514054 Mon Sep 17 00:00:00 2001 From: Rangi42 Date: Sun, 15 Sep 2024 00:00:39 -0400 Subject: [PATCH] Prefer `snprintf` to `sprintf` This also simplifies advancing `ptr` --- src/gfx/process.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gfx/process.cpp b/src/gfx/process.cpp index 44973d86..f6bd3aef 100644 --- a/src/gfx/process.cpp +++ b/src/gfx/process.cpp @@ -627,8 +627,7 @@ static std::tuple, std::vector> static char buf[sizeof(", $XXXX, $XXXX, $XXXX, $XXXX")]; char *ptr = buf; for (uint16_t cgbColor : list) { - sprintf(ptr, ", $%04x", cgbColor); - ptr += QUOTEDSTRLEN(", $XXXX"); + ptr += snprintf(ptr, sizeof(", $XXXX"), ", $%04x", cgbColor); } return &buf[QUOTEDSTRLEN(", ")]; };