mirror of
https://github.com/gbdev/rgbds.git
synced 2025-11-20 18:22:07 +00:00
Make RGBASM overwrite output files atomically
Fixes rednex/#446. I am not sure this is the best (in cases where the target directory is not writable but the target file is), but maybe this can be toggled via a flag, for example.
This commit is contained in:
@@ -16,6 +16,8 @@
|
|||||||
#include <stdint.h>
|
#include <stdint.h>
|
||||||
#include <stdlib.h>
|
#include <stdlib.h>
|
||||||
#include <string.h>
|
#include <string.h>
|
||||||
|
#include <unistd.h>
|
||||||
|
#include <libgen.h>
|
||||||
|
|
||||||
#include "asm/asm.h"
|
#include "asm/asm.h"
|
||||||
#include "asm/charmap.h"
|
#include "asm/charmap.h"
|
||||||
@@ -532,13 +534,25 @@ static void checksectionoverflow(uint32_t delta_size)
|
|||||||
*/
|
*/
|
||||||
void out_WriteObject(void)
|
void out_WriteObject(void)
|
||||||
{
|
{
|
||||||
|
/* Write to a temporary file in the target's folder */
|
||||||
|
char *objectNameCopy = strdup(tzObjectname);
|
||||||
|
char const *dirPath = dirname(objectNameCopy);
|
||||||
|
char tmpFileName[strlen(dirPath) + 1 + 16 + 1];
|
||||||
|
|
||||||
|
sprintf(tmpFileName, "%s/rgbasm_tmpXXXXXX", dirPath);
|
||||||
|
free(objectNameCopy);
|
||||||
|
int fd = mkstemp(tmpFileName);
|
||||||
|
|
||||||
FILE *f;
|
FILE *f;
|
||||||
struct PatchSymbol *pSym;
|
struct PatchSymbol *pSym;
|
||||||
struct Section *pSect;
|
struct Section *pSect;
|
||||||
|
|
||||||
|
if (fd == -1)
|
||||||
|
err(1, "Couldn't create temporary file");
|
||||||
|
|
||||||
addexports();
|
addexports();
|
||||||
|
|
||||||
f = fopen(tzObjectname, "wb");
|
f = fdopen(fd, "wb");
|
||||||
if (f == NULL)
|
if (f == NULL)
|
||||||
fatalerror("Couldn't write file '%s'\n", tzObjectname);
|
fatalerror("Couldn't write file '%s'\n", tzObjectname);
|
||||||
|
|
||||||
@@ -560,6 +574,11 @@ void out_WriteObject(void)
|
|||||||
}
|
}
|
||||||
|
|
||||||
fclose(f);
|
fclose(f);
|
||||||
|
close(fd);
|
||||||
|
|
||||||
|
if (rename(tmpFileName, tzObjectname) != 0)
|
||||||
|
err(1, "Couldn't create object file (temp file kept as %s)",
|
||||||
|
tmpFileName);
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
|||||||
Reference in New Issue
Block a user