From b252877b05165d460c067f2b57489a2aee2c663c Mon Sep 17 00:00:00 2001 From: Rangi Date: Sun, 28 Jun 2026 17:38:50 -0400 Subject: [PATCH] Comment why we use Ninja as the generator for CMake --- .github/workflows/create-release-artifacts.yml | 3 +++ .github/workflows/testing.yml | 3 +++ 2 files changed, 6 insertions(+) diff --git a/.github/workflows/create-release-artifacts.yml b/.github/workflows/create-release-artifacts.yml index a070c2d4..d5457768 100644 --- a/.github/workflows/create-release-artifacts.yml +++ b/.github/workflows/create-release-artifacts.yml @@ -22,6 +22,9 @@ env: # to prevent divergence between testing and release workflows. DEPS_ROOT_DIR: ~/_deps +# We use Ninja as the generator for CMake below because it provides synchronous output by default, +# and only shows full command lines when they fail. + jobs: windows: runs-on: windows-2022 diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 1bd29ff3..46dd1799 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -30,6 +30,9 @@ defaults: run: shell: bash +# We use Ninja as the generator for CMake below because it provides synchronous output by default, +# and only shows full command lines when they fail. + jobs: unix: strategy: