gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 10:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable -Wpedantic

Browse Source 
Fix a few warnings related needed to build the source with this option.

Add new exception to .checkpatch.conf.

Signed-off-by: Antonio Niño Díaz <antonio_nd@outlook.com>
This commit is contained in:
Antonio Niño Díaz
2018-04-01 00:47:35 +01:00
parent 4d13d57491
commit b28a16c0da
5 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.checkpatch.conf
View File

@@ -53,6 +53,9 @@
# Prefer stdint.h types over kernel types # Prefer stdint.h types over kernel types
--ignore PREFER_KERNEL_TYPES --ignore PREFER_KERNEL_TYPES
# Don't ask to replace sscanf by kstrto
--ignore SSCANF_TO_KSTRTO
# Parentheses can make the code clearer # Parentheses can make the code clearer
--ignore UNNECESSARY_PARENTHESES --ignore UNNECESSARY_PARENTHESES

2
Makefile
View File

@@ -26,7 +26,7 @@ PNGLDLIBS := `${PKG_CONFIG} --static --libs-only-l libpng`
VERSION_STRING := `git describe --tags --dirty --always 2>/dev/null` VERSION_STRING := `git describe --tags --dirty --always 2>/dev/null`
WARNFLAGS := -Wall -Werror WARNFLAGS := -Werror -Wall -Wpedantic
# Overridable CFLAGS # Overridable CFLAGS
CFLAGS := -g CFLAGS := -g

1
src/asm/lexer.c
View File

@@ -640,7 +640,6 @@ scanagain:
/* Check for line continuation character */ /* Check for line continuation character */
if (*pLexBuffer == '\\') { if (*pLexBuffer == '\\') {
/* /*
* Look for line continuation character after a series of * Look for line continuation character after a series of
* spaces. This is also useful for files that use Windows line * spaces. This is also useful for files that use Windows line

5
src/asm/main.c
View File

@@ -147,10 +147,13 @@ void opt_Parse(char *s)
case 'z': case 'z':
if (strlen(&s[1]) <= 2) { if (strlen(&s[1]) <= 2) {
int32_t result; int32_t result;
unsigned int fillchar;
result = sscanf(&s[1], "%x", &newopt.fillchar); result = sscanf(&s[1], "%x", &fillchar);
if (!((result == EOF) || (result == 1))) if (!((result == EOF) || (result == 1)))
errx(1, "Invalid argument for option 'z'"); errx(1, "Invalid argument for option 'z'");
newopt.fillchar = fillchar;
} else { } else {
errx(1, "Invalid argument for option 'z'"); errx(1, "Invalid argument for option 'z'");
} }

4
src/gfx/makepng.c
View File

@@ -317,9 +317,9 @@ static void rgba_png_palette(struct PNGImage *img,
png_color **palette_ptr_ptr, int *num_colors) png_color **palette_ptr_ptr, int *num_colors)
{ {
if (png_get_valid(img->png, img->info, PNG_INFO_PLTE)) if (png_get_valid(img->png, img->info, PNG_INFO_PLTE))
return rgba_PLTE_palette(img, palette_ptr_ptr, num_colors); rgba_PLTE_palette(img, palette_ptr_ptr, num_colors);
else else
return rgba_build_palette(img, palette_ptr_ptr, num_colors); rgba_build_palette(img, palette_ptr_ptr, num_colors);
} }
static void rgba_PLTE_palette(struct PNGImage *img, static void rgba_PLTE_palette(struct PNGImage *img,