gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-21 02:32:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix uninitialized memory use with -MT and -MQ

Browse Source 
This didn't break unless the first uninitialized byte was non-zero,
which happened to be the case on someone's Windows machine.

Would it be worth it setting up Valgrind in CI?
This commit is contained in:
ISSOtm
2020-05-06 19:19:10 +02:00
parent 645473e336
commit b299f6fb3b
1 changed files with 32 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/asm/main.c
View File

@@ -454,7 +454,6 @@ int main(int argc, char *argv[])
/* Long-only options */ /* Long-only options */
case 0: case 0:
if (depType) {
switch (depType) { switch (depType) {
case 'G': case 'G':
oGeneratedMissingIncludes = true; oGeneratedMissingIncludes = true;
@@ -472,9 +471,16 @@ int main(int argc, char *argv[])
ep = make_escape(ep); ep = make_escape(ep);
nTargetFileNameLen += strlen(ep) + 1; nTargetFileNameLen += strlen(ep) + 1;
if (!tzTargetFileName) {
/* On first alloc, make an empty str */
tzTargetFileName =
malloc(nTargetFileNameLen + 1);
*tzTargetFileName = '\0';
} else {
tzTargetFileName = tzTargetFileName =
realloc(tzTargetFileName, realloc(tzTargetFileName,
nTargetFileNameLen + 1); nTargetFileNameLen + 1);
}
if (tzTargetFileName == NULL) if (tzTargetFileName == NULL)
err(1, "Cannot append new file to target file list"); err(1, "Cannot append new file to target file list");
strcat(tzTargetFileName, ep); strcat(tzTargetFileName, ep);
@@ -486,7 +492,6 @@ int main(int argc, char *argv[])
*ptr = '\0'; *ptr = '\0';
break; break;
} }
}
break; break;
/* Unrecognized options */ /* Unrecognized options */