gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 18:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Warn when SGB compatibility is set without old licensee 0x33

Browse Source
This commit is contained in:
Rangi42
2023-10-31 23:37:55 -04:00
committed by Eldred Habert
parent e7d0428a2e
commit b4dbb5093a
6 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/fix/main.c
View File

@@ -967,6 +967,10 @@ static void processFile(int input, int output, char const *name, off_t fileSize)
if (oldLicensee != UNSPECIFIED)
overwriteByte(rom0, 0x14B, oldLicensee, "old licensee code");
else if (sgb && rom0[0x14B] != 0x33)
fprintf(stderr,
"warning: SGB compatibility enabled, but old licensee was %#x, not 0x33\n",
rom0[0x14B]);
if (romVersion != UNSPECIFIED)
overwriteByte(rom0, 0x14C, romVersion, "mask ROM version number");

BIN
test/fix/sgb-old-licensee.bin Normal file
View File

Binary file not shown.

2
test/fix/sgb-old-licensee.err Normal file
View File

@@ -0,0 +1,2 @@
warning: Overwrote a non-zero byte in the SGB flag
warning: SGB compatibility enabled, but old licensee was 0xc5, not 0x33

1
test/fix/sgb-old-licensee.flags Normal file
View File

@@ -0,0 +1 @@
-s

BIN
test/fix/sgb.bin
View File

Binary file not shown.

BIN
test/fix/sgb.gb
View File

Binary file not shown.