gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-09-05 21:37:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correct assumption to avoid UB with 1 << 31

Browse Source
This commit is contained in:
Rangi
2026-07-09 21:36:34 -04:00
parent 39e7e064c9
commit b8011947a8
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/asm/rpn.cpp
+2 -2
View File
@@ -485,8 +485,8 @@ void Expression::checkNBit(uint8_t n) const {
} }
bool checkNBit(int32_t v, uint8_t n, char const *name) { bool checkNBit(int32_t v, uint8_t n, char const *name) {
assume(n != 0); // That doesn't make sense assume(n != 0); // That doesn't make sense
assume(n < CHAR_BIT * sizeof(int)); // Otherwise `1 << n` is UB assume(n < CHAR_BIT * sizeof(int) - 1); // Otherwise `1 << n` is UB
if (v < -(1 << n) || v >= 1 << n) { if (v < -(1 << n) || v >= 1 << n) {
warning( warning(
src/link/patch.cpp
+2 -2
View File
@@ -521,8 +521,8 @@ void patch_CheckAssertions() {
} }
static void checkPatchSize(Patch const &patch, int32_t v, uint8_t n) { static void checkPatchSize(Patch const &patch, int32_t v, uint8_t n) {
assume(n != 0); // That doesn't make sense assume(n != 0); // That doesn't make sense
assume(n < CHAR_BIT * sizeof(int)); // Otherwise `1 << n` is UB assume(n < CHAR_BIT * sizeof(int) - 1); // Otherwise `1 << n` is UB
if (v < -(1 << n) || v >= 1 << n) { if (v < -(1 << n) || v >= 1 << n) {
diagnosticAt( diagnosticAt(