From bdac0ce053f14ef9e9fd4f39ed88a73ab614bea6 Mon Sep 17 00:00:00 2001 From: Rangi42 Date: Fri, 2 May 2025 21:29:14 -0400 Subject: [PATCH] Remove unplanned TODO comments in src/gfx/pal_spec.cpp ACT palette files support a transparent color index, but RGBGFX cannot apply *one* such transparent color; it would need every palette's first color to be transparent. Also ACT files tend to say the first color is transparent anyway, which the user may not have intended. ACO palette files can specify version 2 color data, but it's required to come after version 1 data, and the colors themselves already exist in the earlier v1 data; v2 just adds UTF-16 names. Thus, we do not need to be handling these data in those formats. --- src/gfx/pal_spec.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/gfx/pal_spec.cpp b/src/gfx/pal_spec.cpp index 480b8061..65f8fef9 100644 --- a/src/gfx/pal_spec.cpp +++ b/src/gfx/pal_spec.cpp @@ -413,7 +413,6 @@ static void parseACTFile(std::filebuf &file) { uint16_t nbColors = 256; if (len == 772) { nbColors = readBE(&buf[768]); - // TODO: apparently there is a "transparent color index"? What? if (nbColors > 256 || nbColors == 0) { error("Invalid number of colors in ACT file (%" PRIu16 ")", nbColors); return; @@ -524,9 +523,6 @@ static void parseACOFile(std::filebuf &file) { return; } } - - // TODO: maybe scan the v2 data instead (if present) - // `codecvt` can be used to convert from UTF-16 to UTF-8 } static void parseGBCFile(std::filebuf &file) {