gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 10:12:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

No more flexible array members (not standard C++) (#1307)

Browse Source 
* Replace FAMs with `std::vector`s (or one `std::string`) in four `struct`s

* Anonymous types declared in an anonymous union are also non-standard
  Only Clang complains about this (-Wnested-anon-types)
This commit is contained in:
Sylvie
2024-02-22 16:22:37 -05:00
committed by GitHub
parent 6d29d2a67e
commit c0d534f5ad
12 changed files with 170 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
include/asm/symbol.hpp
View File

@@ -23,6 +23,12 @@ enum SymbolType {
SYM_REF // Forward reference to a label
};
// Only used in an anonymous union by `struct Symbol`
struct strValue {
size_t size;
char *value;
};
struct Symbol {
char name[MAXSYMLEN + 1];
enum SymbolType type;
@@ -36,18 +42,12 @@ struct Symbol {
union {
// If sym_IsNumeric
int32_t value;
int32_t (*numCallback)(void);
int32_t (*numCallback)(void); // If hasCallback
// For SYM_MACRO
struct {
size_t size;
char *value;
} macro;
struct strValue macro;
// For SYM_EQUS
struct {
size_t size;
char *value;
} equs;
char const *(*strCallback)(void);
struct strValue equs;
char const *(*strCallback)(void); // If hasCallback
};
uint32_t ID; // ID of the symbol in the object file (-1 if none)