gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-20 18:22:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #509 from JL2210/zero-alloc-use-fix-3

Browse Source 
Fix use of zero-allocated memory
This commit is contained in:
Eldred Habert
2020-04-13 02:50:58 +02:00
committed by GitHub
parent 9bec983923 57639f3765
commit cdb4c5f553
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/link/patch.c
View File

@@ -82,10 +82,20 @@ static inline void clearRPNStack(void)
static void pushRPN(int32_t value) static void pushRPN(int32_t value)
{ {
if (stack.size >= stack.capacity) { if (stack.size >= stack.capacity) {
stack.capacity *= 2; static const size_t increase_factor = 2;
if (stack.capacity > SIZE_MAX / increase_factor)
errx(1, "Overflow in RPN stack resize");
stack.capacity *= increase_factor;
stack.buf = stack.buf =
realloc(stack.buf, sizeof(*stack.buf) * stack.capacity); realloc(stack.buf, sizeof(*stack.buf) * stack.capacity);
if (!stack.buf) /*
* Static analysis tools complain that the capacity might become
* zero due to overflow, but fail to realize that it's caught by
* the overflow check above. Hence the stringent check below.
*/
if (!stack.buf || !stack.capacity)
err(1, "Failed to resize RPN stack"); err(1, "Failed to resize RPN stack");
} }