Add more test coverage for RGBASM (#1256)

This also fixes two bugs: `-1 >>> 32` was -1 not 0, and `macro_FreeArgs` should have been called but wasn't.

test/asm/assert-fatal.asm

@@ -0,0 +1 @@
+assert fatal, 2 + 2 == 5, "there are four lights"

test/asm/assert-fatal.err

@@ -0,0 +1,2 @@
+FATAL: assert-fatal.asm(1):
+    Assertion failed: there are four lights

test/asm/assert@-no-sect.asm

@@ -1 +1 @@
-assert @ || 1
+assert (@) || 1

test/asm/builtin-overwrite.asm

@@ -22,6 +22,10 @@ REDEF \1 = 0
 REDEF \1 = 0
 PRINTLN \1
 
+REDEF \1 EQU 0
+REDEF \1 EQU 0
+PRINTLN \1
+
 REDEF \1 EQUS "hello"
 REDEF \1 EQUS "hello"
 PRINTLN \1

test/asm/builtin-overwrite.err

@@ -1,49 +1,57 @@
-error: builtin-overwrite.asm(32) -> builtin-overwrite.asm::tickle(5):
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(5):
     Built-in symbol '__UTC_YEAR__' cannot be purged
-error: builtin-overwrite.asm(32) -> builtin-overwrite.asm::tickle(6):
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(6):
     Built-in symbol '__UTC_YEAR__' cannot be purged
-error: builtin-overwrite.asm(32) -> builtin-overwrite.asm::tickle(9):
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(9):
     '__UTC_YEAR__' already defined at <command-line>
-error: builtin-overwrite.asm(32) -> builtin-overwrite.asm::tickle(10):
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(10):
     '__UTC_YEAR__' already defined at <command-line>
-error: builtin-overwrite.asm(32) -> builtin-overwrite.asm::tickle(13):
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(13):
     '__UTC_YEAR__' already defined as constant at <command-line>
-error: builtin-overwrite.asm(32) -> builtin-overwrite.asm::tickle(14):
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(14):
     '__UTC_YEAR__' already defined as constant at <command-line>
-error: builtin-overwrite.asm(32) -> builtin-overwrite.asm::tickle(17):
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(17):
     '__UTC_YEAR__' already defined at <command-line>
-error: builtin-overwrite.asm(32) -> builtin-overwrite.asm::tickle(18):
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(18):
     '__UTC_YEAR__' already defined at <command-line>
-error: builtin-overwrite.asm(32) -> builtin-overwrite.asm::tickle(21):
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(21):
     '__UTC_YEAR__' already defined as constant at <command-line>
-error: builtin-overwrite.asm(32) -> builtin-overwrite.asm::tickle(22):
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(22):
     '__UTC_YEAR__' already defined as constant at <command-line>
-error: builtin-overwrite.asm(32) -> builtin-overwrite.asm::tickle(25):
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(25):
+    Built-in symbol '__UTC_YEAR__' cannot be redefined
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(26):
+    Built-in symbol '__UTC_YEAR__' cannot be redefined
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(29):
     '__UTC_YEAR__' already defined as non-EQUS at <command-line>
-error: builtin-overwrite.asm(32) -> builtin-overwrite.asm::tickle(26):
+error: builtin-overwrite.asm(36) -> builtin-overwrite.asm::tickle(30):
     '__UTC_YEAR__' already defined as non-EQUS at <command-line>
-error: builtin-overwrite.asm(33) -> builtin-overwrite.asm::tickle(5):
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(5):
     Built-in symbol '__ISO_8601_UTC__' cannot be purged
-error: builtin-overwrite.asm(33) -> builtin-overwrite.asm::tickle(6):
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(6):
     Built-in symbol '__ISO_8601_UTC__' cannot be purged
-error: builtin-overwrite.asm(33) -> builtin-overwrite.asm::tickle(9):
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(9):
     '__ISO_8601_UTC__' already defined at <command-line>
-error: builtin-overwrite.asm(33) -> builtin-overwrite.asm::tickle(10):
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(10):
     '__ISO_8601_UTC__' already defined at <command-line>
-error: builtin-overwrite.asm(33) -> builtin-overwrite.asm::tickle(13):
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(13):
     '__ISO_8601_UTC__' already defined as constant at <command-line>
-error: builtin-overwrite.asm(33) -> builtin-overwrite.asm::tickle(14):
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(14):
     '__ISO_8601_UTC__' already defined as constant at <command-line>
-error: builtin-overwrite.asm(33) -> builtin-overwrite.asm::tickle(17):
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(17):
     '__ISO_8601_UTC__' already defined at <command-line>
-error: builtin-overwrite.asm(33) -> builtin-overwrite.asm::tickle(18):
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(18):
     '__ISO_8601_UTC__' already defined at <command-line>
-error: builtin-overwrite.asm(33) -> builtin-overwrite.asm::tickle(21):
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(21):
     '__ISO_8601_UTC__' already defined as constant at <command-line>
-error: builtin-overwrite.asm(33) -> builtin-overwrite.asm::tickle(22):
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(22):
     '__ISO_8601_UTC__' already defined as constant at <command-line>
-error: builtin-overwrite.asm(33) -> builtin-overwrite.asm::tickle(25):
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(25):
+    '__ISO_8601_UTC__' already defined as non-EQU at <command-line>
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(26):
+    '__ISO_8601_UTC__' already defined as non-EQU at <command-line>
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(29):
     Built-in symbol '__ISO_8601_UTC__' cannot be redefined
-error: builtin-overwrite.asm(33) -> builtin-overwrite.asm::tickle(26):
+error: builtin-overwrite.asm(37) -> builtin-overwrite.asm::tickle(30):
     Built-in symbol '__ISO_8601_UTC__' cannot be redefined
-error: Assembly aborted (24 errors)!
+error: Assembly aborted (28 errors)!

test/asm/builtin-overwrite.out

@@ -4,6 +4,8 @@ $7C5
 $7C5
 $7C5
 $7C5
+$7C5
+1989-04-21T12:34:56Z
 1989-04-21T12:34:56Z
 1989-04-21T12:34:56Z
 1989-04-21T12:34:56Z

test/asm/charmap-inheritance.asm

@@ -21,3 +21,6 @@ SECTION "test", ROM0
 
 	; This uses 'foo' by deriving another charmap from it.
 	newcharmap bar, foo
+
+	; This is an error because 'eggs' does not exist.
+	newcharmap spam, eggs

test/asm/charmap-inheritance.err

@@ -0,0 +1,3 @@
+error: charmap-inheritance.asm(26):
+    Base charmap 'eggs' doesn't exist
+error: Assembly aborted (1 error)!

test/asm/crlf.asm

@@ -0,0 +1,9 @@
+; This file is encoded with DOS CR+LF line endings!
+
+DEF s EQUS "Hello, \
+world!"
+assert !strcmp("{s}", "Hello, world!")
+
+DEF t EQUS """Hello,
+world!"""
+assert !strcmp("{t}", "Hello,\nworld!")

test/asm/def-scoped.asm

@@ -0,0 +1,16 @@
+SECTION "test", ROM0
+
+; this is okay...
+Label:
+Label.local:
+
+; ...but these are not
+
+DEF n EQU 1
+DEF n.local EQU 2
+
+DEF x = 1
+DEF x.local = 2
+
+DEF s EQUS "..."
+DEF s.local EQUS "..."

test/asm/def-scoped.err

@@ -0,0 +1,7 @@
+error: def-scoped.asm(10):
+    syntax error, unexpected local identifier, expecting identifier
+error: def-scoped.asm(13):
+    syntax error, unexpected local identifier, expecting identifier
+error: def-scoped.asm(16):
+    syntax error, unexpected local identifier, expecting identifier
+error: Assembly aborted (3 errors)!

test/asm/diff-marks.asm

@@ -0,0 +1,3 @@
+SECTION "test", ROM0
+-	ld a, 0
++	xor a

test/asm/diff-marks.err

@@ -0,0 +1,5 @@
+error: diff-marks.asm(2):
+    syntax error, unexpected - at the beginning of the line (is it a leftover diff mark?)
+error: diff-marks.asm(3):
+    syntax error, unexpected + at the beginning of the line (is it a leftover diff mark?)
+error: Assembly aborted (2 errors)!

test/asm/div-mod.asm

@@ -22,9 +22,9 @@ MACRO test_mod
 ENDM
 
 MACRO test_each_mod
-	test_mod (\1), (\2)
-	test_mod (\1), -(\2)
-	test_mod -(\1), (\2)
+	test_mod +(\1), +(\2)
+	test_mod +(\1), -(\2)
+	test_mod -(\1), +(\2)
 	test_mod -(\1), -(\2)
 ENDM
 
@@ -38,8 +38,8 @@ MACRO test_pow
 ENDM
 
 MACRO test_each_pow
-	test_pow (\1), (\2)
-	test_pow -(\1), (\2)
+	test_pow +(\1), +(\2)
+	test_pow -(\1), +(\2)
 ENDM
 
 	test_each_mod 0, 1

test/asm/fail.asm

@@ -0,0 +1 @@
+fail "oops"

test/asm/fail.err

@@ -0,0 +1,2 @@
+FATAL: fail.asm(1):
+    oops

test/asm/invalid-instructions.asm

@@ -0,0 +1,8 @@
+SECTION "invalid", ROM0[$10000]
+	ld [hl], [hl]
+	ld a, [$00ff+c]
+	ld b, [c]
+	ld b, [bc]
+	ld b, [$4000]
+	bit 8, a
+	rst $40

test/asm/invalid-instructions.err

@@ -0,0 +1,17 @@
+error: invalid-instructions.asm(1):
+    Address $10000 is not 16-bit
+error: invalid-instructions.asm(2):
+    LD [HL],[HL] not a valid instruction
+error: invalid-instructions.asm(3):
+    Expected constant expression equal to $FF00 for "$ff00+c"
+error: invalid-instructions.asm(4):
+    Destination operand must be A
+error: invalid-instructions.asm(5):
+    Destination operand must be A
+error: invalid-instructions.asm(6):
+    Destination operand must be A
+error: invalid-instructions.asm(7):
+    Immediate value must be 3-bit
+error: invalid-instructions.asm(8):
+    Invalid address $40 for RST
+error: Assembly aborted (8 errors)!

test/asm/invalid-numbers.asm

@@ -0,0 +1,17 @@
+; no digits
+def x = $
+def x = `
+
+; too large
+def x = 9_876_543_210
+def x = $f_0000_0000
+def x = &400_0000_0000
+def x = %1_00000000_00000000_00000000_00000000
+def x = 65537.0q16
+
+; no precision suffix
+def x = 3.14q
+
+; invalid precision suffix
+def x = 3.14q40
+

test/asm/invalid-numbers.err

@@ -0,0 +1,19 @@
+error: invalid-numbers.asm(2):
+    Invalid integer constant, no digits after '$'
+error: invalid-numbers.asm(3):
+    Invalid graphics constant, no digits after '`'
+warning: invalid-numbers.asm(6): [-Wlarge-constant]
+    Integer constant is too large
+warning: invalid-numbers.asm(7): [-Wlarge-constant]
+    Integer constant is too large
+warning: invalid-numbers.asm(8): [-Wlarge-constant]
+    Integer constant is too large
+warning: invalid-numbers.asm(9): [-Wlarge-constant]
+    Integer constant is too large
+warning: invalid-numbers.asm(10): [-Wlarge-constant]
+    Magnitude of fixed-point constant is too large
+error: invalid-numbers.asm(13):
+    Invalid fixed-point constant, no significant digits after 'q'
+error: invalid-numbers.asm(16):
+    Fixed-point constant precision must be between 1 and 31
+error: Assembly aborted (4 errors)!

test/asm/math.asm

@@ -15,6 +15,7 @@ ENDM
 	test -(v 3)**(v 4) == (v -81)
 	test (v 1) << (v 30) == (v $4000_0000)
 	test (v 2)**(v 30) == (v $4000_0000)
+	test (v 37)/(v 2) == (v 18)
 
 	assert DIV(5.0, 2.0) == 2.5
 	assert DIV(-5.0, 2.0) == -2.5

test/asm/modzero-instr.asm

@@ -0,0 +1,2 @@
+SECTION "sec", ROM0
+	ld  a, 1 % 0

test/asm/modzero-instr.err

@@ -0,0 +1,2 @@
+FATAL: modzero-instr.asm(2):
+    Modulo by zero

test/asm/negative-exponent.asm

@@ -0,0 +1 @@
+assert 1 ** -1 == 1 ; mathematically yes, technically no

test/asm/negative-exponent.err

@@ -0,0 +1,2 @@
+FATAL: negative-exponent.asm(1):
+    Exponentiation by negative power

test/asm/purge-multiple.asm

@@ -0,0 +1,9 @@
+SECTION "s", ROM0
+u::
+def v = 0
+def w equ 1
+def x equs "2"
+MACRO y
+ENDM
+; purge many symbols at once to test parser reallocation
+PURGE u, v, w, x, y

test/asm/redef-equ.asm

@@ -19,5 +19,7 @@ ENDM
 	item 9
 	println LENGTH_SQUARES, SQUARES_1, SQUARES_2, SQUARES_3
 
+REDEF NEW EQU 7
+
 DEF N EQUS "X"
 REDEF N EQU 42

test/asm/redef-equ.err

@@ -1,3 +1,3 @@
-error: redef-equ.asm(23):
-    'N' already defined as non-EQU at redef-equ.asm(22)
+error: redef-equ.asm(25):
+    'N' already defined as non-EQU at redef-equ.asm(24)
 error: Assembly aborted (1 error)!

test/asm/redef-equs.asm

@@ -19,5 +19,7 @@ ENDM
 	list FOO, 1, A, 2, B
 	PRINTLN "{FOO}"
 
+REDEF NEW EQUS "NEW"
+
 DEF N EQU 42
 REDEF N EQUS "X"

test/asm/redef-equs.err

@@ -1,3 +1,3 @@
-error: redef-equs.asm(23):
-    'N' already defined as non-EQUS at redef-equs.asm(22)
+error: redef-equs.asm(25):
+    'N' already defined as non-EQUS at redef-equs.asm(24)
 error: Assembly aborted (1 error)!

test/asm/shift.asm

@@ -24,6 +24,16 @@ section "test", ROM0[0]
 	test -4 >> 2
 	test -1 >> -9001
 
+	test 100 << -2
+	test 1 >> -2
+
+	test 100 >>> 16
+	test 100 >>> -16
+	test 100 >>> 32
+	test 100 >>> -32
+	test -100 >>> 32
+	test -100 >>> -32
+
 	test $DEADBEEF >> 1
 	test $DEADBEEF >>> 1
 

test/asm/shift.err

@@ -24,5 +24,19 @@ warning: shift.asm(25) -> shift.asm::test(8): [-Wshift]
     Shifting right negative value -1
 warning: shift.asm(25) -> shift.asm::test(8): [-Wshift-amount]
     Shifting right by negative amount -9001
-warning: shift.asm(27) -> shift.asm::test(8): [-Wshift]
+warning: shift.asm(27) -> shift.asm::test(8): [-Wshift-amount]
+    Shifting left by negative amount -2
+warning: shift.asm(28) -> shift.asm::test(8): [-Wshift-amount]
+    Shifting right by negative amount -2
+warning: shift.asm(31) -> shift.asm::test(8): [-Wshift-amount]
+    Shifting right by negative amount -16
+warning: shift.asm(32) -> shift.asm::test(8): [-Wshift-amount]
+    Shifting right by large amount 32
+warning: shift.asm(33) -> shift.asm::test(8): [-Wshift-amount]
+    Shifting right by negative amount -32
+warning: shift.asm(34) -> shift.asm::test(8): [-Wshift-amount]
+    Shifting right by large amount 32
+warning: shift.asm(35) -> shift.asm::test(8): [-Wshift-amount]
+    Shifting right by negative amount -32
+warning: shift.asm(37) -> shift.asm::test(8): [-Wshift]
     Shifting right negative value -559038737

test/asm/shift.out

@@ -10,5 +10,13 @@
 -4 >> 1 = $FFFFFFFE
 -4 >> 2 = $FFFFFFFF
 -1 >> -9001 = $0
+100 << -2 = $19
+1 >> -2 = $4
+100 >>> 16 = $0
+100 >>> -16 = $640000
+100 >>> 32 = $0
+100 >>> -32 = $0
+-100 >>> 32 = $0
+-100 >>> -32 = $0
 $DEADBEEF >> 1 = $EF56DF77
 $DEADBEEF >>> 1 = $6F56DF77

test/asm/strfmt.asm

@@ -8,6 +8,8 @@ DEF N = 112
 DEF FMT EQUS "X"
 PRINTLN STRFMT("\tdb %#03{s:FMT} %% 26\t; %#03{FMT}", N, N % 26)
 
+PRINTLN STRFMT("%d = %#x = %#b = %#o != %f", 42, 42, 42, 42, 42.0)
+
 DEF TEMPLATE EQUS "\"%s are %s\\n\""
 PRINT STRFMT(TEMPLATE, "roses", "red")
 PRINT STRFMT(TEMPLATE, "violets", "blue")

test/asm/strfmt.err

@@ -1,11 +1,11 @@
-error: strfmt.asm(14):
+error: strfmt.asm(16):
     Formatting number as type 's'
-error: strfmt.asm(14):
+error: strfmt.asm(16):
     STRFMT: 1 unformatted argument(s)
-error: strfmt.asm(22):
-    STRFMT: Illegal '%' at end of format string
 error: strfmt.asm(24):
-    STRFMT: Invalid format spec for argument 1
+    STRFMT: Illegal '%' at end of format string
 error: strfmt.asm(26):
+    STRFMT: Invalid format spec for argument 1
+error: strfmt.asm(28):
     STRFMT: Not enough arguments for format spec, got: 1, need: 3
 error: Assembly aborted (5 errors)!

test/asm/strfmt.out

@@ -1,6 +1,7 @@
 Hello world! I am 15 years old today!
 signed -000000042 == unsigned 4294967254
 	db $70 % 26	; $08
+42 = $2a = %101010 = &52 != 42.00000
 roses are red
 violets are blue
 void are 0

test/asm/string-formatting.asm

@@ -10,7 +10,7 @@ def s equs "hello"
 	println "<{#-10s:s}> <{10s:s}>"
 
 macro foo
-	println "<{\1}>"
+	println "\1 <{\1}>"
 endm
 
 	foo  -6d:n ; space is trimmed

test/asm/string-formatting.out

@@ -2,4 +2,4 @@
 <4294967254> <-42> <&000037777777726>
 <3.14159> <-00123> <-123.0455932617>
 <hello     > <     hello>
-<300   >
+-6d:n <300   >

test/asm/trigonometry.asm

@@ -13,9 +13,11 @@ for Q, 2, 31
 	if Q > 2 ; can't represent 0.125 in Q.2
 		assert tan(0.125) == 1.0
 		assert atan(1.0) == 0.125
+		assert atan2(1.0, 1.0) == 0.125
 	else
 		assert tan(0.0) == 0.0
 		assert atan(0.0) == 0.0
+		assert atan2(0.0, 1.0) == 0.0
 	endc
 endr
 

test/asm/utc-time.asm

@@ -1,5 +1,5 @@
 MACRO between
-	assert (\1) <= (\2) && (\2) <= (\3)
+	assert (\2) >= (\1)  && (\2) <= (\3)
 ENDM
 
 	between 0, __UTC_YEAR__, 9999 ; Y10K problem...

test/link/all-instructions.asm

@@ -169,12 +169,16 @@ ENDM
 
     ld  [hl+],a
     ld  [hli],a
+    ldi [hl],a
     ld  [hl-],a
     ld  [hld],a
+    ldd [hl],a
     ld  a,[hl+]
     ld  a,[hli]
+    ldi a,[hl]
     ld  a,[hl-]
     ld  a,[hld]
+    ldd a,[hl]
 
     ; Jumps and Subroutines