gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-01-23 08:51:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid writing "XXX" since it's a conventional "TODO/FIXME" comment

Browse Source
This commit is contained in:
Rangi
2026-01-22 13:01:10 -05:00
parent ade898d815
commit d053025070
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
man/rgbasm.5
View File

@@ -2571,9 +2571,9 @@ The stack's number of entries is limited only by the amount of memory in your ma
.Ic PUSHO .Ic PUSHO
can also take a comma-separated list of options, to push the current set and apply the argument set at the same time: can also take a comma-separated list of options, to push the current set and apply the argument set at the same time:
.Bd -literal -offset indent .Bd -literal -offset indent
PUSHO b.X, g.oOX PUSHO b.#, g.oO#
DB %..XXXX.. DB %..####..
DW `..ooOOXX DW `..ooOO##
POPO POPO
.Ed .Ed
.Ss Excluding locations from backtraces .Ss Excluding locations from backtraces

4
src/gfx/process.cpp
View File

@@ -409,10 +409,10 @@ static std::pair<std::vector<size_t>, std::vector<Palette>>
} }
auto listColors = [](auto const &list) { auto listColors = [](auto const &list) {
static char buf[sizeof(", $XXXX, $XXXX, $XXXX, $XXXX")]; static char buf[sizeof(", $xxxx, $xxxx, $xxxx, $xxxx")];
char *ptr = buf; char *ptr = buf;
for (uint16_t color : list) { for (uint16_t color : list) {
ptr += snprintf(ptr, sizeof(", $XXXX"), ", $%04x", color); ptr += snprintf(ptr, sizeof(", $xxxx"), ", $%04x", color);
} }
return &buf[literal_strlen(", ")]; return &buf[literal_strlen(", ")];
}; };

4
test/link/cascading-errors.asm
View File

@@ -3,8 +3,8 @@ Zero:
; Pin the section such that a jr to 0 is out of range ; Pin the section such that a jr to 0 is out of range
SECTION "test", ROM0[$1000] SECTION "test", ROM0[$1000]
;; XXX: the fallback value used is the index of the symbol (in the object file?) ;; the fallback value for an undefined symbol used to be its index in the object file,
;; Is this intended? ;; but is now zero as of RGBLINK v1.0.1
dw Bar dw Bar
dw Foo / Bar dw Foo / Bar
dw Foo / Zero dw Foo / Zero